[core][rewriter] dpsc: handle destructuring in bindings

Author: velzie

rewriter/js/src/rewrite.rs

@@ -90,7 +90,6 @@ impl<'alloc: 'data, 'data> Rewrite<'alloc, 'data> {
 
 impl<'alloc: 'data, 'data> RewriteType<'alloc, 'data> {
 	fn into_inner(self, span: Span) -> SmallVec<[JsChange<'alloc, 'data>; 2]> {
-		dbg!(&self);
 		macro_rules! span {
 			(start) => {
 				Span::new(span.start, span.start)

rewriter/js/src/visitor.rs

@@ -4,12 +4,13 @@ use oxc::{
 	allocator::{Allocator, StringBuilder},
 	ast::ast::{
 		AssignmentExpression, AssignmentTarget, AssignmentTargetMaybeDefault,
-		AssignmentTargetProperty, BindingPattern, CallExpression, ComputedMemberExpression,
-		DebuggerStatement, ExportAllDeclaration, ExportNamedDeclaration, Expression, FunctionBody,
-		IdentifierReference, ImportDeclaration, ImportExpression, MemberExpression, MetaProperty,
-		NewExpression, ObjectExpression, ObjectPattern, ObjectPropertyKind, PrivateIdentifier,
-		PropertyKey, ReturnStatement, SimpleAssignmentTarget, StringLiteral, ThisExpression,
-		UnaryExpression, UnaryOperator, UpdateExpression,
+		AssignmentTargetProperty, BindingPattern, BindingPatternKind, BindingProperty,
+		CallExpression, ComputedMemberExpression, DebuggerStatement, ExportAllDeclaration,
+		ExportNamedDeclaration, Expression, FunctionBody, IdentifierReference, ImportDeclaration,
+		ImportExpression, MemberExpression, MetaProperty, NewExpression, ObjectExpression,
+		ObjectPattern, ObjectPropertyKind, PrivateIdentifier, PropertyKey, ReturnStatement,
+		SimpleAssignmentTarget, StringLiteral, ThisExpression, UnaryExpression, UnaryOperator,
+		UpdateExpression,
 	},
 	ast_visit::{Visit, walk},
 	span::{Atom, GetSpan, Span},
@@ -328,6 +329,53 @@ where
 		}
 	}
 
+	fn visit_binding_pattern(&mut self, it: &BindingPattern<'data>) {
+		match &it.kind {
+			BindingPatternKind::BindingIdentifier(p) => {
+				// let a = 0;
+				dbg!(&p);
+				walk::walk_binding_identifier(self, p);
+			}
+			BindingPatternKind::AssignmentPattern(p) => {
+				walk::walk_binding_pattern(self, &p.left);
+				walk::walk_expression(self, &p.right);
+				dbg!(&p);
+			}
+			BindingPatternKind::ObjectPattern(p) => {
+				for prop in &p.properties {
+					match &prop.key {
+						PropertyKey::StaticIdentifier(id) => {
+							if UNSAFE_GLOBALS.contains(&id.name.to_string().as_str()) {
+								if prop.shorthand {
+									// const { location } = self;
+									self.jschanges.add(rewrite!(
+										id.span(),
+										RebindProperty { ident: id.name }
+									));
+								} else {
+									// const { location: a } = self;
+									self.jschanges.add(rewrite!(
+										id.span(),
+										RewriteProperty { ident: id.name }
+									));
+								}
+							}
+						}
+						PropertyKey::PrivateIdentifier(_) => {
+							// doesn't matter
+						}
+						_ => {
+							// const { ["location"]: x } = self;
+							self.jschanges.add(rewrite!(prop.key.span(), WrapProperty));
+						}
+					}
+					walk::walk_binding_pattern(self, &prop.value);
+				}
+			}
+			_ => {}
+		}
+	}
+
 	fn visit_assignment_target(&mut self, it: &AssignmentTarget<'data>) {
 		match &it {
 			AssignmentTarget::StaticMemberExpression(s) => {