fix behavior of _top and _parent

Author: velzie

src/client/dom/open.ts

@@ -1,14 +1,18 @@
 import { rewriteUrl } from "../../shared";
 import { ScramjetClient } from "../client";
-import { SCRAMJETCLIENT } from "../../symbols";
+import {
+	SCRAMJETCLIENT,
+	SCRAMJETCLIENTNAME,
+	SCRAMJETFRAMENAME,
+} from "../../symbols";
 
 export default function (client: ScramjetClient) {
 	client.Proxy("window.open", {
 		apply(ctx) {
 			if (ctx.args[0]) ctx.args[0] = rewriteUrl(ctx.args[0], client.meta);
 
 			if (["_parent", "_top", "_unfencedTop"].includes(ctx.args[1]))
-				ctx.args[1] = "_self";
+				ctx.args[1] = SCRAMJETFRAMENAME; // TODO: this is still technically the wrong behavior
 
 			const realwin = ctx.call();
 

src/controller/frame.ts

@@ -1,13 +1,14 @@
 import { ScramjetController } from ".";
 import type { ScramjetClient } from "../client/client";
-import { SCRAMJETCLIENT, SCRAMJETFRAME } from "../symbols";
+import { SCRAMJETCLIENT, SCRAMJETFRAME, SCRAMJETFRAMENAME } from "../symbols";
 
 export class ScramjetFrame extends EventTarget {
 	constructor(
 		private controller: ScramjetController,
 		public frame: HTMLIFrameElement
 	) {
 		super();
+		frame.name = SCRAMJETFRAMENAME;
 		frame[SCRAMJETFRAME] = this;
 	}
 

src/shared/rewriters/html.ts

@@ -8,6 +8,7 @@ import { CookieStore } from "../cookie";
 import { unrewriteBlob } from "../../shared/rewriters/url";
 import { $scramjet } from "../../scramjet";
 import { getRewriter } from "./wasm";
+import { SCRAMJETCLIENTNAME, SCRAMJETFRAMENAME } from "../../symbols";
 
 const encoder = new TextEncoder();
 function rewriteHtmlInner(
@@ -231,7 +232,8 @@ export const htmlRules: {
 	},
 	{
 		fn: (value: string) => {
-			if (["_parent", "_top", "_unfencedTop"].includes(value)) return "_self";
+			if (["_parent", "_top", "_unfencedTop"].includes(value))
+				return SCRAMJETFRAMENAME; // TODO: ...
 			else return value;
 		},
 		target: ["a", "base"],

src/symbols.ts

@@ -2,3 +2,4 @@
 export const SCRAMJETCLIENTNAME = "scramjet client global";
 export const SCRAMJETCLIENT = Symbol.for(SCRAMJETCLIENTNAME);
 export const SCRAMJETFRAME = Symbol.for("scramjet frame handle");
+export const SCRAMJETFRAMENAME = "scramjet_frame";