[chrome] small history fixes

Author: velzie

packages/chrome/src/History.ts

@@ -82,14 +82,15 @@ export class History {
 
 	push(
 		url: URL,
+		title: string | null = null,
 		state: any = null,
 		navigate: boolean = true,
 		virtual: boolean = false
 	): HistoryState {
 		if (this.index + 1 < this.states.length)
 			// "fork" history tree, creating a new timeline
 			this.states.splice(this.index, this.states.length - this.index);
-		const hstate = new HistoryState({ url, state });
+		const hstate = new HistoryState({ url, state, title });
 		if (virtual) hstate.virtual = true;
 
 		if (url.href != "puter://newtab") browser.globalhistory.push(hstate);
@@ -106,11 +107,16 @@ export class History {
 
 		return this.states[this.index];
 	}
-	replace(url: URL, state: any, navigate: boolean = true): HistoryState {
+	replace(
+		url: URL,
+		title: string | null,
+		state: any,
+		navigate: boolean = true
+	): HistoryState {
 		if (this.index < this.states.length) {
 			this.current().url = url;
 			this.current().state = state;
-			this.current().title = null;
+			this.current().title = title;
 			this.current().favicon = null;
 		} else {
 			return this.push(url, state);
@@ -127,6 +133,7 @@ export class History {
 		return this.states[this.index];
 	}
 	go(delta: number, navigate: boolean = true): HistoryState {
+		const current = this.current();
 		this.index += delta;
 		if (this.index < 0) {
 			this.index = 0;
@@ -135,8 +142,9 @@ export class History {
 		}
 
 		let newstate = this.states[this.index];
+		console.error("going", newstate);
 
-		if (newstate.virtual) {
+		if (current.virtual) {
 			sendFrame(this.tab, "popstate", {
 				state: newstate.state,
 				url: newstate.url.href,

packages/chrome/src/IsolatedFrame.tsx

@@ -68,7 +68,7 @@ const cfg = {
 		syncxhr: false,
 		strictRewrites: true,
 		rewriterLogs: false,
-		captureErrors: true,
+		captureErrors: false,
 		cleanErrors: false,
 		scramitize: false,
 		sourcemaps: true,
@@ -822,17 +822,19 @@ const chromemethods: ChromeboundMethods = {
 
 	history_go: async (tab, { delta }) => {
 		if (tab) {
+			console.error("hist go" + delta);
 			tab.history.go(delta);
 		}
 	},
-	history_pushState: async (tab, { url, title }) => {
+	history_pushState: async (tab, { url, title, state }) => {
 		if (tab) {
-			tab.history.push(new URL(url), title, true);
+			console.error("hist push", url);
+			tab.history.push(new URL(url), title, state, false, true);
 		}
 	},
-	history_replaceState: async (tab, { url, title }) => {
+	history_replaceState: async (tab, { url, title, state }) => {
 		if (tab) {
-			tab.history.replace(new URL(url), title);
+			tab.history.replace(new URL(url), title, state, false);
 		}
 	},
 };