Skip to content

Commit 9251aae

Browse files
committed
[frontend] switch to ionicons and fix double add button
1 parent 3526ca7 commit 9251aae

File tree

5 files changed

+24
-32
lines changed

5 files changed

+24
-32
lines changed

frontend/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
},
1515
"dependencies": {
1616
"@iconify/types": "^2.0.0",
17-
"@ktibow/iconset-material-symbols": "^0.0.1749705809",
17+
"@ktibow/iconset-ion": "^8.0.13",
1818
"@mercuryworkshop/epoxy-transport": "^2.1.27",
1919
"@mercuryworkshop/scramjet": "workspace:scramjet",
2020
"dreamland": "workspace:dreamland",

frontend/src/Omnibox.tsx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
import type { Component } from "dreamland/core";
22
import { Icon } from "./ui/Icon";
33
import type { IconifyIcon } from "@iconify/types";
4-
import iconBack from "@ktibow/iconset-material-symbols/arrow-back";
5-
import iconForwards from "@ktibow/iconset-material-symbols/arrow-forward";
6-
import iconRefresh from "@ktibow/iconset-material-symbols/refresh";
7-
import iconExtension from "@ktibow/iconset-material-symbols/extension";
8-
import iconSettings from "@ktibow/iconset-material-symbols/settings";
9-
import iconShield from "@ktibow/iconset-material-symbols/shield";
10-
import iconStar from "@ktibow/iconset-material-symbols/star";
11-
import iconSearch from "@ktibow/iconset-material-symbols/search";
4+
import iconBack from "@ktibow/iconset-ion/arrow-back";
5+
import iconForwards from "@ktibow/iconset-ion/arrow-forward";
6+
import iconRefresh from "@ktibow/iconset-ion/refresh";
7+
import iconExtension from "@ktibow/iconset-ion/extension-puzzle-outline";
8+
import iconSettings from "@ktibow/iconset-ion/settings-outline";
9+
import iconShield from "@ktibow/iconset-ion/shield-outline";
10+
import iconStar from "@ktibow/iconset-ion/star-outline";
11+
import iconSearch from "@ktibow/iconset-ion/search";
1212
import { createMenu } from "./Menu";
1313
import { browser, client } from "./main";
1414

frontend/src/browser.tsx

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { ThemeVars, type Theme } from "./ui/theme";
33
import { Tabs, Tab } from "./tabs";
44
import { IconButton, Omnibox } from "./Omnibox";
55
import { scramjet } from "./main";
6-
import iconAdd from "@ktibow/iconset-material-symbols/add";
6+
import iconAdd from "@ktibow/iconset-ion/add";
77
import { popTab, pushTab, Shell } from "./Shell";
88
import { createMenu } from "./Menu";
99

@@ -239,19 +239,12 @@ export class Browser extends StatefulClass {
239239
return (
240240
<div>
241241
<ThemeVars colors={use(this.theme)} />
242-
<div style="display: flex; align-items: center; background: var(--aboutbrowser-frame-bg)">
243-
<Tabs
244-
tabs={use(this.tabs).bind()}
245-
activetab={use(this.activetab).bind()}
246-
destroyTab={(tab) => this.destroyTab(tab)}
247-
/>
248-
<IconButton
249-
icon={iconAdd}
250-
click={() => {
251-
this.newTab("tab 2");
252-
}}
253-
></IconButton>
254-
</div>
242+
<Tabs
243+
tabs={use(this.tabs).bind()}
244+
activetab={use(this.activetab).bind()}
245+
destroyTab={(tab) => this.destroyTab(tab)}
246+
addTab={() => this.newTab("title")}
247+
/>
255248
<Omnibox
256249
value={use(this.activetab.url)}
257250
navigate={(url) => this.navigate(url)}

frontend/src/tabs.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import iconClose from "@ktibow/iconset-material-symbols/close";
2-
import iconAdd from "@ktibow/iconset-material-symbols/add";
1+
import iconClose from "@ktibow/iconset-ion/close";
2+
import iconAdd from "@ktibow/iconset-ion/add";
33
import {
44
createState,
55
type Component,
@@ -394,7 +394,6 @@ export const Tabs: Component<
394394
};
395395
Tabs.css = `
396396
:scope {
397-
flex: 1;
398397
background: var(--aboutbrowser-frame-bg);
399398
padding: 6px 12px;
400399
height: calc(28px + 12px);

pnpm-lock.yaml

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)