dev(puterfs): move misc methods to extension

The get_capabilities and update_thumbnail methods in PuterFSProvider are
moved to the extension by this commit. This is prerequisite to the
removal of PuterFSProvider in the core.

Author: KernelDeimos

extensions/puterfs/main.js

@@ -79,6 +79,7 @@ const {
 
 const {
     FSNodeContext,
+    capabilities,
 } = extension.import('fs');
 
 const {
@@ -99,6 +100,25 @@ const {
 } = extension.import('fs').util;
 
 class PuterFSProvider {
+    // TODO: should this be a static member instead?
+    get_capabilities () {
+        return new Set([
+            capabilities.THUMBNAIL,
+            capabilities.UPDATE_THUMBNAIL,
+            capabilities.UUID,
+            capabilities.OPERATION_TRACE,
+            capabilities.READDIR_UUID_MODE,
+
+            capabilities.COPY_TREE,
+
+            capabilities.READ,
+            capabilities.WRITE,
+            capabilities.CASE_SENSITIVE,
+            capabilities.SYMLINK,
+            capabilities.TRASH,
+        ]);
+    }
+
     /**
      * Check if a given node exists.
      *
@@ -226,6 +246,41 @@ class PuterFSProvider {
         return node;
     }
 
+    async update_thumbnail ({ context, node, thumbnail }) {
+        const {
+            actor: inputActor,
+        } = context.values;
+        const actor = inputActor ?? Context.get('actor');
+
+        context = context ?? Context.get();
+        const services = context.get('services');
+
+        // TODO: this ACL check should not be here, but there's no LL method yet
+        //       and it's possible we will never implement the thumbnail
+        //       capability for any other filesystem type
+
+        const svc_acl = services.get('acl');
+        if ( ! await svc_acl.check(actor, node, 'write') ) {
+            throw await svc_acl.get_safe_acl_error(actor, node, 'write');
+        }
+
+        const uid = await node.get('uid');
+
+        const entryOp = await svc_fsEntry.update(uid, {
+            thumbnail,
+        });
+
+        (async () => {
+            await entryOp.awaitDone();
+            svc_event.emit('fs.write.file', {
+                node,
+                context,
+            });
+        })();
+
+        return node;
+    }
+
     async read ({ context, node, version_id, range }) {
         const svc_mountpoint = context.get('services').get('mountpoint');
         const storage = svc_mountpoint.get_storage(this.constructor.name);

src/backend/src/modules/puterfs/lib/PuterFSProvider.js

@@ -18,8 +18,6 @@
  */
 
 const putility = require('@heyputer/putility');
-const { Context } = require('../../../util/context');
-const fsCapabilities = require('../../../filesystem/definitions/capabilities');
 const config = require('../../../config.js');
 
 class PuterFSProvider extends putility.AdvancedBase {
@@ -31,21 +29,8 @@ class PuterFSProvider extends putility.AdvancedBase {
     }
 
     get_capabilities () {
-        return new Set([
-            fsCapabilities.THUMBNAIL,
-            fsCapabilities.UPDATE_THUMBNAIL,
-            fsCapabilities.UUID,
-            fsCapabilities.OPERATION_TRACE,
-            fsCapabilities.READDIR_UUID_MODE,
-
-            fsCapabilities.COPY_TREE,
-
-            fsCapabilities.READ,
-            fsCapabilities.WRITE,
-            fsCapabilities.CASE_SENSITIVE,
-            fsCapabilities.SYMLINK,
-            fsCapabilities.TRASH,
-        ]);
+        console.error('This .get_capabilities should not be called!');
+        throw new Error('This .get_capabilities should not be called!');
     }
 
     /**
@@ -106,37 +91,8 @@ class PuterFSProvider extends putility.AdvancedBase {
     }
 
     async update_thumbnail ({ context, node, thumbnail }) {
-        const {
-            actor: inputActor,
-        } = context.values;
-        const actor = inputActor ?? Context.get('actor');
-
-        context = context ?? Context.get();
-        const services = context.get('services');
-
-        const svc_fsEntry = services.get('fsEntryService');
-        const svc_event = services.get('event');
-
-        const svc_acl = services.get('acl');
-        if ( ! await svc_acl.check(actor, node, 'write') ) {
-            throw await svc_acl.get_safe_acl_error(actor, node, 'write');
-        }
-
-        const uid = await node.get('uid');
-
-        const entryOp = await svc_fsEntry.update(uid, {
-            thumbnail,
-        });
-
-        (async () => {
-            await entryOp.awaitDone();
-            svc_event.emit('fs.write.file', {
-                node,
-                context,
-            });
-        })();
-
-        return node;
+        console.error('This .update_thumbnail should not be called!');
+        throw new Error('This .update_thumbnail should not be called!');
     }
 
     /**