refactor(backend): remove PuterFSProvider from core

Author: KernelDeimos

extensions/puterfs/main.js

@@ -918,12 +918,10 @@ class PuterFSProvider {
     }
 }
 
-const { TmpProxyFSProvider } = extension.import('fs');
-
 extension.on('create.filesystem-types', event => {
     event.createFilesystemType('puterfs', {
         mount ({ path }) {
-            return new TmpProxyFSProvider(path, new PuterFSProvider(path));
+            return new PuterFSProvider(path);
         },
     });
 });

src/backend/src/filesystem/FilesystemService.js

@@ -28,7 +28,6 @@ const { UserActorType } = require('../services/auth/Actor');
 const { get_user } = require('../helpers');
 const BaseService = require('../services/BaseService');
 const { MANAGE_PERM_PREFIX } = require('../services/auth/permissionConts.mjs');
-const { PuterFSProvider } = require('../modules/puterfs/lib/PuterFSProvider.js');
 const { quot } = require('@heyputer/putility/src/libs/string.js');
 
 class FilesystemService extends BaseService {
@@ -95,7 +94,7 @@ class FilesystemService extends BaseService {
                     || permission.startsWith(`${MANAGE_PERM_PREFIX}:${MANAGE_PERM_PREFIX}:fs:`); // owner has implicit rule to give others manage access;
             },
             checker: async ({ actor, permission }) => {
-                if ( !(actor.type instanceof UserActorType) ) {
+                if ( ! (actor.type instanceof UserActorType) ) {
                     return undefined;
                 }
 
@@ -109,7 +108,7 @@ class FilesystemService extends BaseService {
                 const owner_id = await node.get('user_id');
 
                 // These conditions should never happen
-                if ( ! owner_id || ! actor.type.user.id ) {
+                if ( !owner_id || !actor.type.user.id ) {
                     throw new Error('something unexpected happened');
                 }
 
@@ -330,8 +329,8 @@ class FilesystemService extends BaseService {
         }
 
         if ( ! (selector instanceof NodeSelector) ) {
-            throw new Error('FileSystemService could not resolve the specified node value ' +
-                quot('' + selector) + ` (type: ${typeof selector}) ` +
+            throw new Error(`FileSystemService could not resolve the specified node value ${
+                quot(`${ selector}`) } (type: ${typeof selector}) ` +
                 'to a filesystem node selector');
         }
 

src/backend/src/modules/puterfs/PuterFSModule.js

@@ -22,7 +22,6 @@ const FSNodeContext = require('../../filesystem/FSNodeContext');
 const capabilities = require('../../filesystem/definitions/capabilities');
 const selectors = require('../../filesystem/node/selectors');
 const { RuntimeModule } = require('../../extension/RuntimeModule');
-const { TmpProxyFSProvider } = require('./TmpProxyFSProvider');
 const { MODE_READ, MODE_WRITE } = require('../../services/fs/FSLockService');
 const { UploadProgressTracker } = require('../../filesystem/storage/UploadProgressTracker');
 
@@ -39,7 +38,6 @@ class PuterFSModule extends AdvancedBase {
                 capabilities,
                 selectors,
                 FSNodeContext,
-                TmpProxyFSProvider,
                 lock: {
                     MODE_READ,
                     MODE_WRITE,

src/backend/src/modules/puterfs/PuterFSService.js

@@ -1,10 +1,9 @@
-const APIError = require("../../api/APIError");
-const eggspress = require("../../api/eggspress");
-const FSNodeParam = require("../../api/filesystem/FSNodeParam");
-const StringParam = require("../../api/filesystem/StringParam");
-const { is_valid_url } = require("../../helpers");
-const { PuterFSProvider } = require("../../modules/puterfs/lib/PuterFSProvider");
-const { Context } = require("../../util/context");
+const APIError = require('../../api/APIError');
+const eggspress = require('../../api/eggspress');
+const FSNodeParam = require('../../api/filesystem/FSNodeParam');
+const StringParam = require('../../api/filesystem/StringParam');
+const { is_valid_url } = require('../../helpers');
+const { Context } = require('../../util/context');
 
 module.exports = eggspress('/update-fsentry-thumbnail', {
     subdomain: 'api',
@@ -25,22 +24,22 @@ module.exports = eggspress('/update-fsentry-thumbnail', {
             got: typeof req.values.thumbnail,
         });
     }
-    
+
     if ( ! await req.values.fsNode.exists() ) {
         throw new APIError.create('subject_does_not_exist');
     }
-    
+
     const svc = Context.get('services');
-    
+
     const svc_mountpoint = svc.get('mountpoint');
     const provider =
         await svc_mountpoint.get_provider(req.values.fsNode.selector);
-        
+
     provider.update_thumbnail({
         context: Context.get(),
         node: req.values.fsNode,
         thumbnail: req.body.thumbnail,
     });
-    
+
     res.json({});
 });