[Bug]: Invalid strategies all of a sudden

[pillmuncher]

Neovim version

0.10.3

Language affected

Lua

Query

No response

Strategy

No response

Description

After the latest update I'm getting :check_health errors:

rainbow-delimiters: require("rainbow-delimiters.health").check()

Custom strategies ~
- ERROR Invalid custom default strategy.
  - ADVICE:
    - See :help |rb-delimiters-strategy| for the strategy protocol
- ERROR Invalid custom strategy for 'vim'
  - ADVICE:
    - See :help |rb-delimiters-strategy| for the strategy protocol

I haven't changed my strategy settings:

return {
    'HiPhish/rainbow-delimiters.nvim',
    config = function()
        local rainbow_delimiters = require('rainbow-delimiters')
        require('rainbow-delimiters.setup').setup({
            strategy = {
                [''] = rainbow_delimiters.strategy['global'],
                vim = rainbow_delimiters.strategy['local'],
            },
            query = {
                [''] = 'rainbow-delimiters',
                lua = 'rainbow-blocks',
            },
            priority = {
                [''] = 110,
                lua = 210,
            },
            highlight = {
                'RainbowDelimiterRed',
                'RainbowDelimiterYellow',
                'RainbowDelimiterBlue',
                'RainbowDelimiterOrange',
                'RainbowDelimiterGreen',
                'RainbowDelimiterViolet',
                'RainbowDelimiterCyan',
            }
        })
    end
}

[HiPhish]

Looks like I forgot to update the health check. You can ignore the error until I fix it. I have made it possible to specify the strategy as a string now in order to avoid calling require. The require function needs to traverse all plugins, which is not very expensive, but it does add up when every plugin does it. That is also why setup functions are a bad idea. You could improve your startup time even more by dropping the require call in your function and specifying the strategies as strings. Please refer to the documentation for the possible values.

[HiPhish]

Please try the current master branch, it should be fixed now.

[HaleTom]

Should the README be updated to reflect this faster string-type way of specifying strategies?

[HaleTom]

Custom strategies ~
- ERROR Invalid custom default strategy.
  - ADVICE:
    - See :help |rb-delimiters-strategy| for the strategy protocol

Commit:
03347f9 Release version 0.9.0 (HEAD -> master, tag: v0.9.0, origin/master, origin/HEAD)[19 hours ago HiPhish]

    vim.g.rainbow_delimiters = {
      strategy = {
          -- Use global strategy by default
        [''] = "rainbow-delimiters.strategy.global",
        html = select_strategy,
        latex = select_strategy,
        vim = select_strategy,
      },
      query = {
        [''] = 'rainbow-delimiters',
        lua = 'rainbow-blocks',
      },
      priority = {
        [''] = 110,
        lua = 210,
      },
      -- https://github.com/HiPhish/rainbow-delimiters.nvim/blob/master/plugin/rainbow-delimiters.lua#L34
      -- Default highlights:
      highlight = require "rainbow-highlights".highlights,
    }

[HaleTom]

I notice that the updated README now has strings, but still has:

local rainbow_delimiters = require 'rainbow-delimiters'

Any reason for this?

[HiPhish]

@HaleTom No, my bad. The README should be correct now. The health check was fixed in commit 90e95d6de9a32d9f429f541f6aa01f2885d7390e, which is one after the 0.9.0 release.

[HaleTom]

All green for me! Cheers!