Skip to content

Provide configurable urlBase. #92

@wjziv

Description

@wjziv

This extension does not work when running VSCode through the browser via Code Server while hosted entirely on a separate server.

Expected (upon starting vscode-ungit):

  • Ungit starts running on the external server.
  • VSCode opens a new tab with Ungit.

Actual Results:

  • Ungit starts running on the local device, if possible. (Incorrect)
  • Ungit does not start running on the server.
  • VSCode opens a new tab and points to a local instance of Ungit at localhost:8448, regardless of availability.
  • If Ungit was not able to start (not installed/no access to terminal) window shows "Localhost refused to connect".

Proposed solution:
Ungit provides a method for setting a urlBase other than localhost from the command line, shown in config.js.

If this can be set from .vscode/package.json and propagated throughout vscode-ungit to start/request visuals from Ungit on the correct machine, it may be all that's needed.

Figured I'd throw this out there in case the dev/someone who's closer to this project is able to approach it faster than I can as I acquaint myself with TS.

Below: Reference to the hardcoded localhost.

const url = `http://localhost:8448/?noheader=true#/repository?path=${uri.fsPath}`;

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions