generated from Hochfrequenz/python_template_repository
    
        
        - 
                Notifications
    You must be signed in to change notification settings 
- Fork 1
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Description
Problem
In the mapping class the thing is named "package expression".
ahbicht/src/ahbicht/mapping_results.py
Line 65 in ba70dd6
| package_expression: Optional[str] = attrs.field( | 
But in the resolver it's named "condition expression".
| async def get_condition_expression(self, package_key: str) -> PackageKeyConditionExpressionMapping: | 
It should be consistent.
My guess is that renaming the package_resolver method (with the refactor/rename feature of the IDE) is less hassle than renaming the attribute of the mapping class.
Todos
- fix the inconsistency
- create a release with a new minor version as this is "a little bit breaking" ;)
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers