Skip to content

Harmonization: package_expression vs condition_expression #157

@hf-kklein

Description

@hf-kklein

Problem

In the mapping class the thing is named "package expression".

package_expression: Optional[str] = attrs.field(

But in the resolver it's named "condition expression".

async def get_condition_expression(self, package_key: str) -> PackageKeyConditionExpressionMapping:

It should be consistent.

My guess is that renaming the package_resolver method (with the refactor/rename feature of the IDE) is less hassle than renaming the attribute of the mapping class.

Todos

  • fix the inconsistency
  • create a release with a new minor version as this is "a little bit breaking" ;)

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions