fix(ahb): Bedingung text might be None in XML + SG AHB_Status is not always set (#84)

Author: hf-kklein

src/fundamend/reader/ahbreader.py

@@ -51,14 +51,14 @@ def _to_code(element: ET.Element) -> Code:
 def _to_bedingung(element: ET.Element) -> Bedingung:
     return Bedingung(
         nummer=strip("[", element.attrib["Nummer"], "]"),
-        text=element.text.strip(),  # type:ignore[union-attr]
+        text=(element.text or "").strip(),
     )
 
 
 def _to_ub_bedingung(element: ET.Element) -> UbBedingung:
     return UbBedingung(
         nummer=strip("[", element.attrib["Nummer"], "]"),
-        text=element.text.strip(),  # type:ignore[union-attr]
+        text=(element.text or "").strip(),
     )
 
 
@@ -148,7 +148,11 @@ def _to_segment_group(element: ET.Element) -> SegmentGroup:
     return SegmentGroup(
         id=lstrip("G_SG", element.tag),
         name=element.attrib["Name"],
-        ahb_status=element.attrib["AHB_Status"],
+        ahb_status=(
+            element.attrib["AHB_Status"].strip() or None
+            if "AHB_Status" in element.attrib and element.attrib["AHB_Status"] is not None
+            else None
+        ),
         elements=tuple(list(segments_and_groups)),
     )
 

unittests/test_ahb_serialisierung.py

@@ -8,6 +8,10 @@
 data_path: Path = Path(__file__).parent.parent / "xml-migs-and-ahbs"
 
 
+def private_submodule_is_checked_out() -> bool:
+    return any(data_path.iterdir())
+
+
 @pytest.mark.parametrize(
     "ahb_xml_file_path, expected_date",
     [
@@ -94,11 +98,21 @@
     ],
 )
 def test_read_ahb_xml(ahb_xml_file_path: Path, expected_date: date) -> None:
+    if not private_submodule_is_checked_out():
+        pytest.skip("Skipping test because of missing private submodule")
     reader = AhbReader(ahb_xml_file_path)
     actual = reader.get_publishing_date()
     assert actual == expected_date
 
 
+def test_deserializing_all_ahbs() -> None:
+    if not private_submodule_is_checked_out():
+        pytest.skip("Skipping test because of missing private submodule")
+    for ahb_file_path in data_path.rglob("**/*AHB*.xml"):
+        reader = AhbReader(ahb_file_path)
+        _ = reader.read()  # must not crash
+
+
 @pytest.mark.parametrize(
     "mig_xml_file_path, expected_date",
     [
@@ -185,6 +199,16 @@ def test_read_ahb_xml(ahb_xml_file_path: Path, expected_date: date) -> None:
     ],
 )
 def test_read_mig_xml(mig_xml_file_path: Path, expected_date: date) -> None:
+    if not private_submodule_is_checked_out():
+        pytest.skip("Skipping test because of missing private submodule")
     reader = MigReader(mig_xml_file_path)
     actual = reader.get_publishing_date()
     assert actual == expected_date
+
+
+def test_deserializing_all_migs() -> None:
+    if not private_submodule_is_checked_out():
+        pytest.skip("Skipping test because of missing private submodule")
+    for mig_file_path in data_path.rglob("**/*MIG*.xml"):
+        reader = MigReader(mig_file_path)
+        _ = reader.read()  # must not crash