Skip to content

Commit 8378cc8

Browse files
authored
Merge pull request #17286 from Homebrew/stricter_linkage_test
linkage_checker: test indirect dependencies.
2 parents 4a65df6 + 1c65495 commit 8378cc8

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

Library/Homebrew/linkage_checker.rb

+2-1
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ def display_test_output(puts_output: true, strict: false)
6767
display_items("Conflicting libraries", @version_conflict_deps, puts_output:)
6868
return unless strict
6969

70+
display_items("Indirect dependencies with linkage", @indirect_deps, puts_output:)
7071
display_items("Undeclared dependencies with linkage", @undeclared_deps, puts_output:)
7172
display_items("Files with missing rpath", @files_missing_rpaths, puts_output:)
7273
display_items "@executable_path references in libraries", @executable_path_dylibs, puts_output:
@@ -79,7 +80,7 @@ def broken_library_linkage?(test: false, strict: false)
7980
issues = [@broken_deps, @broken_dylibs]
8081
if test
8182
issues += [@unwanted_system_dylibs, @version_conflict_deps]
82-
issues += [@undeclared_deps, @files_missing_rpaths, @executable_path_dylibs] if strict
83+
issues += [@indirect_deps, @undeclared_deps, @files_missing_rpaths, @executable_path_dylibs] if strict
8384
end
8485
issues.any?(&:present?)
8586
end

0 commit comments

Comments
 (0)