Skip to content

Commit 862c3ba

Browse files
authored
Revert "formula: runtime deps of build deps aren't runtime"
1 parent 6b4de31 commit 862c3ba

File tree

2 files changed

+5
-12
lines changed

2 files changed

+5
-12
lines changed

Library/Homebrew/formula.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -1505,7 +1505,7 @@ def recursive_requirements(&block)
15051505
# Returns a list of Dependency objects that are required at runtime.
15061506
# @private
15071507
def runtime_dependencies
1508-
recursive_dependencies { |_, dep| Dependency.prune if dep.build? }
1508+
recursive_dependencies.reject(&:build?)
15091509
end
15101510

15111511
# Returns a list of formulae depended on by this formula that aren't

Library/Homebrew/test/formula_test.rb

+4-11
Original file line numberDiff line numberDiff line change
@@ -651,19 +651,12 @@ def test_dependencies
651651

652652
f4 = formula("f4") do
653653
url "f4-1.0"
654-
depends_on "f1"
654+
depends_on "f3"
655655
end
656-
stub_formula_loader f4
657656

658-
f5 = formula("f5") do
659-
url "f5-1.0"
660-
depends_on "f3" => :build
661-
depends_on "f4"
662-
end
663-
664-
assert_equal %w[f3 f4], f5.deps.map(&:name)
665-
assert_equal %w[f1 f2 f3 f4], f5.recursive_dependencies.map(&:name)
666-
assert_equal %w[f1 f4], f5.runtime_dependencies.map(&:name)
657+
assert_equal %w[f3], f4.deps.map(&:name)
658+
assert_equal %w[f1 f2 f3], f4.recursive_dependencies.map(&:name)
659+
assert_equal %w[f2 f3], f4.runtime_dependencies.map(&:name)
667660
end
668661

669662
def test_to_hash

0 commit comments

Comments
 (0)