Skip to content

Commit 9cce341

Browse files
authored
Merge pull request #1806 from MikeMcQuaid/audit-virtualenv-setuptools
audit: check virtualenv and setuptools resource.
2 parents df46d62 + 346d68e commit 9cce341

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

Library/Homebrew/dev-cmd/audit.rb

+5
Original file line numberDiff line numberDiff line change
@@ -819,6 +819,11 @@ def audit_text
819819
problem "Formulae should not depend on both OpenSSL and LibreSSL (even optionally)."
820820
end
821821

822+
if text =~ /virtualenv_(create|install_with_resources)/ &&
823+
text =~ /resource\s+['"]setuptools['"]\s+do/
824+
problem "Formulae using virtualenvs do not need a `setuptools` resource."
825+
end
826+
822827
return unless text.include?('require "language/go"') && !text.include?("go_resource")
823828
problem "require \"language/go\" is unnecessary unless using `go_resource`s"
824829
end

0 commit comments

Comments
 (0)