Add --no-vscode and HOMEBREW_BUNDLE_DUMP_NO_VSCODE #1459
Merged
+106
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows excluding VSCode output from `brew bundle dump` with a flag or environment variable. While we're here - generally refactor how we handle command arguments so this logic is pushed into `cmd/bundle` and made more consistent - fix early RSpec failure due to an unstubbed `exec` call - refactor some specs to be more idiomatic
MikeMcQuaid
force-pushed
the
vscode_list_dump
branch
from
a15c4b9
to
1a1866c
Compare
jacobbednarz
approved these changes
Oct 2, 2024
|
Thanks @jacobbednarz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows excluding VSCode output from
brew bundle dumpwith a flag or environment variable.While we're here
cmd/bundleand made more consistentexeccallFixes #1209
Fixes #1212
Fixes #1456