Error: invalid option: --no-lock

[jasonkarns]

I just started getting this error out of the blue by all of our app bootstrap scripts and my own custom dotfiles scripts which all use brew bundle --no-lock ....

I see #1509 has landed which removes the lockfile generation. And by my reading of the PR, it appears that the --no-lock option is supposed to still be accepted (silently? or perhaps with a warning?) as it is now just a no-op.

But surprising to me (and disruptive to all our application tooling), the brew bundle --no-lock command errors out immediately with invalid-option error.

I'm basing this on the wild assumption that hidden: true here (and the fact that the option was not removed from the codebase), that the option was expected to continue to be allowed?

https://github.com/Homebrew/homebrew-bundle/pull/1509/files#diff-2ba13d1d1d9b7abcde49568b7aec20c97f4541f44f6befd62ac6a4d820ddb7ccR76-R78

If the expected behavior is indeed that brew bundle should error with "invalid option"; then this Issue is more about requesting there be a deprecation period and warning for the planned removal of said option.

creating this issue from ill-advised comment on closed PR referenced above:

Originally posted by @jasonkarns in #1509 (comment)

[MikeMcQuaid]

If the expected behavior is indeed that brew bundle should error with "invalid option"; then this Issue is more about requesting there be a deprecation period and warning for the planned removal of said option.

Yes, this is expected.

I'm not sure what the current solution here is, though. Add it back with a deprecation warning?

This is a product of Homebrew/homebrew-bundle not having any sort of stable release process to handle deprecations. Once it's merged into Homebrew/brew: this will get better.

[MikeMcQuaid]

This is a product of Homebrew/homebrew-bundle not having any sort of stable release process to handle deprecations. Once it's merged into Homebrew/brew: this will get better.

This has happened.