-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consul: migrate formula to casks #207023
base: master
Are you sure you want to change the base?
consul: migrate formula to casks #207023
Conversation
It really should be disabled first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please disable this first, thanks!
the fact that this formula was initially migrated from casks complicates things a bit, maybe i should first remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@botantony Please disable this before rerequesting review.
the formula was disabled yesterday (#208102) |
@botantony Thanks! Please rebase this pull-request. Happy to merge just the |
I just tested things locally and |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?see Homebrew/homebrew-cask/pull/200992