Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul: migrate formula to casks #207023

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

botantony
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

see Homebrew/homebrew-cask/pull/200992

@botantony botantony requested review from MikeMcQuaid and a team as code owners February 8, 2025 23:47
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Feb 8, 2025
@SMillerDev
Copy link
Member

It really should be disabled first

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please disable this first, thanks!

@botantony botantony mentioned this pull request Feb 18, 2025
6 tasks
@botantony
Copy link
Contributor Author

the fact that this formula was initially migrated from casks complicates things a bit, maybe i should first remove "consul": "homebrew/core", from tap_migrations.json in cask repo and then do the migration 🤔

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@botantony Please disable this before rerequesting review.

@botantony
Copy link
Contributor Author

the formula was disabled yesterday (#208102)

@MikeMcQuaid
Copy link
Member

@botantony Thanks! Please rebase this pull-request. Happy to merge just the tap_migrations.json change for now and consul.rb changes shouldn't be needed.

@botantony
Copy link
Contributor Author

I just tested things locally and brew audit --except=installed --tap=homebrew/core cannot find consul dependency for disabled envconsul formula (hmm... maybe I should submit formulae removal first)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants