Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 23.9.0 #209037

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

node 23.9.0 #209037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions Formula/n/node.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
class Node < Formula
desc "Platform built on V8 to build network applications"
homepage "https://nodejs.org/"
url "https://nodejs.org/dist/v23.7.0/node-v23.7.0.tar.xz"
sha256 "8de192ef2fee2ee8a230dd8d0e9aee182ee9c9856ccdb5fd95188abe84f77242"
url "https://nodejs.org/dist/v23.9.0/node-v23.9.0.tar.xz"
sha256 "c6b420bedbb049a6538c33af28abaf89011ccc879f0f0f81791675263c238f97"
license "MIT"
head "https://github.com/nodejs/node.git", branch: "main"

Expand Down Expand Up @@ -33,14 +33,13 @@
uses_from_macos "zlib"

on_macos do
depends_on "llvm" => [:build, :test] if DevelopmentTools.clang_build_version <= 1100
depends_on "llvm" => :build if DevelopmentTools.clang_build_version <= 1500
end

# https://github.com/swiftlang/llvm-project/commit/94461822c75d5080bf648f86552f7a59b76905c9
fails_with :clang do
build 1100
cause <<~EOS
error: calling a private constructor of class 'v8::internal::(anonymous namespace)::RegExpParserImpl<uint8_t>'
EOS
build 1500
cause "needs std::ranges::elements_view"
end

# We track major/minor from upstream Node releases.
Expand All @@ -50,8 +49,8 @@
sha256 "5cd1e5ab971ea6333f910bc2d50700167c5ef4e66da279b2a3efc874c6b116e4"
end

def install

Check failure on line 52 in Formula/n/node.rb

View workflow job for this annotation

GitHub Actions / Linux

`brew install --verbose --formula --build-bottle node` failed on Linux! 

  gcc-11 -o /tmp/node-20250226-5350-7waxhp/node-v23.9.0/out/Release/obj.target/zstd/deps/zstd/lib/common/debug.o ../deps/zstd/lib/common/debug.c '-D_GLIBCXX_USE_CXX11_ABI=1' '-DNODE_OPENSSL_CONF_NAME=nodejs_conf' '-DNODE_OPENSSL_CERT_STORE' '-DICU_NO_USER_DATA_OVERRIDE' '-D__STDC_FORMAT_MACROS' '-DXXH_NAMESPACE=ZSTD_' '-DZSTD_MULTITHREAD' '-DZSTD_DISABLE_ASM' -I/home/linuxbrew/.linuxbrew/opt/zlib/include -I/home/linuxbrew/.linuxbrew/opt/libuv/include -I/home/linuxbrew/.linuxbrew/opt/brotli/include -I/home/linuxbrew/.linuxbrew/opt/c-ares/include -I/home/linuxbrew/.linuxbrew/opt/libnghttp2/include -I/home/linuxbrew/.linuxbrew/opt/openssl@3/include -I/home/linuxbrew/.linuxbrew/Cellar/icu4c@76/76.1_1/include -I../deps/zstd/lib  -pthread -Wall -Wextra -Wno-unused-parameter -pthread -m64 -O3 -fno-omit-frame-pointer  -MMD -MF /tmp/node-20250226-5350-7waxhp/node-v23.9.0/out/Release/.deps//tmp/node-20250226-5350-7waxhp/node-v23.9.0/out/Release/obj.target/zstd/deps/zstd/lib/common/debug.o.d.raw   -c
  gcc-11 -o /tmp/node-20250226-5350-7waxhp/node-v23.9.0/out/Release/obj.target/zstd/deps/zstd/lib/common/entropy_common.o ../deps/zstd/lib/common/entropy_common.c '-D_GLIBCXX_USE_CXX11_ABI=1' '-DNODE_OPENSSL_CONF_NAME=nodejs_conf' '-DNODE_OPENSSL_CERT_STORE' '-DICU_NO_USER_DATA_OVERRIDE' '-D__STDC_FORMAT_MACROS' '-DXXH_NAMESPACE=ZSTD_' '-DZSTD_MULTITHREAD' '-DZSTD_DISABLE_ASM' -I/home/linuxbrew/.linuxbrew/opt/zlib/include -I/home/linuxbrew/.linuxbrew/opt/libuv/include -I/home/linuxbrew/.linuxbrew/opt/brotli/include -I/home/linuxbrew/.linuxbrew/opt/c-ares/include -I/home/linuxbrew/.linuxbrew/opt/libnghttp2/include -I/home/linuxbrew/.linuxbrew/opt/openssl@3/include -I/home/linuxbrew/.linuxbrew/Cellar/icu4c@76/76.1_1/include -I../deps/zstd/lib  -pthread -Wall -Wextra -Wno-unused-parameter -pthread -m64 -O3 -fno-omit-frame-pointer  -MMD -MF /tmp/node-20250226-5350-7waxhp/node-v23.9.0/out/Release/.deps//tmp/node-20250226-5350-7waxhp/node-v23.9.0/out/Release/obj.target/zstd/deps/zstd/lib/common/entropy_common.o.d.raw   -c
  gcc-11 -o /tmp/node-20250226-5350-7waxhp/node-v23.9.0/out/Release/obj.target/zstd/deps/zstd/lib/common/fse_decompress.o ../deps/zstd/lib/common/fse_decompress.c '-D_GLIBCXX_USE_CXX11_ABI=1' '-DNODE_OPENSSL_CONF_NAME=nodejs_conf' '-DNODE_OPENSSL_CERT_STORE' '-DICU_NO_USER_DATA_OVERRIDE' '-D__STDC_FORMAT_MACROS' '-DXXH_NAMESPACE=ZSTD_' '-DZSTD_MULTITHREAD' '-DZSTD_DISABLE_ASM' -I/home/linuxbrew/.linuxbrew/opt/zlib/include -I/home/linuxbrew/.linuxbrew/opt/libuv/include -I/home/linuxbrew/.linuxbrew/opt/brotli/include -I/home/linuxbrew/.linuxbrew/opt/c-ares/include -I/home/linuxbrew/.linuxbrew/opt/libnghttp2/include -I/home/linuxbrew/.linuxbrew/opt/openssl@3/include -I/home/linuxbrew/.linuxbrew/Cellar/icu4c@76/76.1_1/include -I../deps/zstd/lib  -pthread -Wall -Wextra -Wno-unused-parameter -pthread -m64 -O3 -fno-omit-frame-pointer  -MMD -MF /tmp/node-20250226-5350-7waxhp/node-v23.9.0/out/Release/.deps//tmp/node-20250226-5350-7waxhp/node-v23.9.0/out/Release/obj.target/zstd/deps/zstd/lib/common/fse_decompress.o.d.raw   -c
In file included from ../deps/ada/ada.cpp:3:
../deps/ada/ada.h: In member function ‘constexpr std::string_view ada::url::get_pathname() const’:
../deps/ada/ada.h:6597:10: error: call to non-‘constexpr’ function ‘std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::operator std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::__sv_type() const [with _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>; std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::__sv_type = std::basic_string_view<char>]’
 6597 |   return path;
      |          ^~~~
In file included from /usr/include/c++/11/string:55,
                 from ../deps/ada/ada.h:20,
                 from ../deps/ada/ada.cpp:3:
/usr/include/c++/11/bits/basic_string.h:806:7: note: ‘std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::operator std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::__sv_type() const [with _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>; std::__cxx11::basic_string<_CharT, _Trai
ENV.llvm_clang if OS.mac? && (DevelopmentTools.clang_build_version <= 1100)
ENV.llvm_clang if OS.mac? && DevelopmentTools.clang_build_version <= 1500

# The new linker crashed during LTO due to high memory usage.
ENV.append "LDFLAGS", "-Wl,-ld_classic" if DevelopmentTools.clang_build_version >= 1500
Expand Down Expand Up @@ -87,9 +86,9 @@

# Enabling LTO errors on Linux with:
# terminate called after throwing an instance of 'std::out_of_range'
# Pre-Catalina macOS also can't build with LTO
# macOS also can't build with LTO when using LLVM Clang
# LTO is unpleasant if you have to build from source.
args << "--enable-lto" if OS.mac? && MacOS.version >= :catalina && build.bottle?
args << "--enable-lto" if OS.mac? && DevelopmentTools.clang_build_version > 1500 && build.bottle?

system "./configure", *args
system "make", "install"
Expand Down
Loading