-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rewrite generation as a Homebrew command based on the API #45
feat: rewrite generation as a Homebrew command based on the API #45
Conversation
d78a05d
to
cd25e97
Compare
Thank you for the contribution. It seems that it's smart. |
1d23589
to
93ae0d4
Compare
71ead20
to
b511a57
Compare
@MikeMcQuaid made the style check continue on error since the generated formulae don't all conform to the style check. Missing tests and unaligned array keys are the big factors there. Otherwise it's ready to go for another review. |
Remove the style check rather than wasting time running it and then ignoring the result. Also, please open an issue for this to be fixed, we shouldn't be generating invalid formulae in an official tap. |
Some can be corrected, some my code fixes, but some are simply because casks don't have as strict a ruleset as formula do. I'll make an issue with a summary of the issues after this PR. |
d8755c5
to
fe45f5f
Compare
Style issue is created. If anyone has an idea how to write tests for these formula we can fix that part already. |
I think either:
|
after these last changes. |
32590b2
to
b43f05e
Compare
b43f05e
to
f1f5ea4
Compare
@MikeMcQuaid I can't merge here so if you're okay with it, go ahead! |
This recreates the CI command as a Homebrew command that's based on the cask API that users also use. This means that it'll be slightly slower to update than it is now, but also more stable.
TODO: