checkstyle

Author: rbri

checkstyle.xml

@@ -256,7 +256,7 @@
         <module name="FinalClass"/>
         <module name="HideUtilityClassConstructor"/>
         <module name="InterfaceIsType"/>
-        <module name="VisibilityModifier"/>
+        <!--module name="VisibilityModifier"/-->
 
         <!-- Miscellaneous other checks.                   -->
         <!-- See http://checkstyle.sf.net/config_misc.html -->
@@ -268,7 +268,6 @@
             <property name="tokens" value="VARIABLE_DEF,PARAMETER_DEF"/>
             <property name="validateEnhancedForLoopVariable" value="true"/>
         </module>
-        <module name="HiddenField"/>
         <module name="MissingOverride"/>
     </module>
 </module>

src/main/java/org/htmlunit/cyberneko/HTMLScanner.java

@@ -1704,7 +1704,7 @@ else if (c == '\r') {
     // infoset utility methods
 
     // Returns an augmentations object with a location item added.
-    protected final Augmentations locationAugs(CurrentEntity currentEntity) {
+    protected final Augmentations locationAugs(final CurrentEntity currentEntity) {
         // we don't have to create a new LocationItem all the time, because the interface says:
         // Methods that receive Augmentations are required to copy the information
         // if it is to be saved for use beyond the scope of the method.

src/main/java/org/htmlunit/cyberneko/HTMLTagBalancer.java

@@ -782,7 +782,7 @@ else if (fTemplateFragment
                 // nothing, don't force/check parent for the direct template children
             }
             else if (!fSeenRootElement && !fDocumentFragment) {
-                String pname = preferedParent.name;
+                final String pname = preferedParent.name;
                 if (fReportErrors) {
                     final String ename = elem.getRawname();
                     fErrorReporter.reportWarning("HTML2002", new Object[]{ename, modifyName(pname, fNamesElems)});

src/main/java/org/htmlunit/cyberneko/xerces/dom/ParentNode.java

@@ -67,12 +67,12 @@ public abstract class ParentNode extends ChildNode {
     /** First child. */
     protected ChildNode firstChild = null;
 
-    /** NodeList cache */
+    /** NodeList cache. */
     protected NodeListCache fNodeListCache = null;
 
     /**
      * No public constructor; only subclasses of ParentNode should be instantiated,
-     * and those normally via a Document's factory methods
+     * and those normally via a Document's factory methods.
      *
      * @param ownerDocument the owner document
      */
@@ -461,7 +461,8 @@ Node internalRemoveChild(final Node oldChild, final boolean replace) throws DOME
         final CoreDocumentImpl ownerDoc = ownerDocument();
         if (ownerDoc.errorChecking) {
             if (oldChild != null && oldChild.getParentNode() != this) {
-                throw new DOMException(DOMException.NOT_FOUND_ERR, DOMMessageFormatter.formatMessage("NOT_FOUND_ERR", null));
+                throw new DOMException(DOMException.NOT_FOUND_ERR,
+                                        DOMMessageFormatter.formatMessage("NOT_FOUND_ERR", null));
             }
         }
 

src/main/java/org/htmlunit/cyberneko/xerces/dom/TextImpl.java

@@ -103,7 +103,7 @@ public String getWholeText() {
 
     /**
      * internal method taking a StringBuffer in parameter and inserts the text
-     * content at the start of the buffer
+     * content at the start of the buffer.
      *
      * @param builder string buffer
      * @throws DOMException on error
@@ -496,7 +496,8 @@ private boolean hasTextOnlyChildren(final Node node) {
     @Override
     public Text splitText(final int offset) throws DOMException {
         if (offset < 0 || offset > data_.length()) {
-            throw new DOMException(DOMException.INDEX_SIZE_ERR, DOMMessageFormatter.formatMessage("INDEX_SIZE_ERR", null));
+            throw new DOMException(DOMException.INDEX_SIZE_ERR,
+                                    DOMMessageFormatter.formatMessage("INDEX_SIZE_ERR", null));
         }
 
         // split text into two separate nodes

src/main/java/org/htmlunit/cyberneko/xerces/xni/NamespaceContext.java

@@ -32,7 +32,7 @@ public interface NamespaceContext {
     /**
      * XML Information Set REC all namespace attributes (including those named
      * xmlns, whose [prefix] property has no value) have a namespace URI of
-     * http://www.w3.org/2000/xmlns/
+     * http://www.w3.org/2000/xmlns/.
      */
     String XMLNS_URI = "http://www.w3.org/2000/xmlns/";
 

src/test/java/org/htmlunit/cyberneko/CanonicalSAXTest.java

@@ -66,8 +66,8 @@ public void runTest(final File dataFile) throws Exception {
         verify(dataFile, saxDataLines);
     }
 
-
-    private static void verify(final File dataFile, final String saxDataLines) throws IOException, AssertionFailedError {
+    private static void verify(final File dataFile, final String saxDataLines)
+                throws IOException, AssertionFailedError {
         try {
             // prepare for future changes where canonical files are next to test file
             File canonicalFile = new File(dataFile.getParentFile(), dataFile.getName() + ".canonical-sax");

src/test/java/org/htmlunit/cyberneko/CanonicalXNITest.java

@@ -103,9 +103,9 @@ private static String getResult(final File infile) throws Exception {
             htmlConfiguration.setFeature(HTMLConfiguration.AUGMENTATIONS, true);
             htmlConfiguration.setDocumentHandler(parser);
 
-
             final String normalized = getCanonical(infile);
-            htmlConfiguration.parse(new XMLInputSource(null, null, null, new StringReader(normalized), StandardCharsets.UTF_8.name()));
+            htmlConfiguration.parse(new XMLInputSource(null, null, null,
+                                            new StringReader(normalized), StandardCharsets.UTF_8.name()));
 
             final StringBuilder sb = new StringBuilder();
 

src/test/java/org/htmlunit/cyberneko/HTMLTagBalancingListenerTest.java

@@ -65,7 +65,7 @@ public void ignoredTags() throws Exception {
     }
 
     /**
-     * HTMLTagBalancer field fSeenFramesetElement was not correctly reset as of 1.19.17
+     * HTMLTagBalancer field fSeenFramesetElement was not correctly reset as of 1.19.17.
      * @throws Exception on error
      */
     @Test
@@ -97,8 +97,8 @@ private static final class TestParser extends AbstractSAXParser implements HTMLT
         }
 
         @Override
-        public void startElement(final QName element, final XMLAttributes attributes, final Augmentations augs) throws XNIException {
-
+        public void startElement(final QName element, final XMLAttributes attributes,
+                final Augmentations augs) throws XNIException {
             messages_.add("start " + element.getRawname());
             super.startElement(element, attributes, augs);
         }

src/test/java/org/htmlunit/cyberneko/HeadNamespaceBugTest.java

@@ -35,7 +35,7 @@
 public class HeadNamespaceBugTest {
 
     /**
-     * Ensure that the inserted head element has the right namespace
+     * Ensure that the inserted head element has the right namespace.
      */
     @Test
     public void headNamespace() throws Exception {
@@ -48,7 +48,8 @@ public void startElement(final String ns, final String name, final String qName,
             }
         };
         final InputSource source = new InputSource();
-        source.setByteStream(new ByteArrayInputStream("<html xmlns='http://www.w3.org/1999/xhtml'><body/></html>".getBytes()));
+        source.setByteStream(new ByteArrayInputStream(
+                                "<html xmlns='http://www.w3.org/1999/xhtml'><body/></html>".getBytes()));
         final HTMLConfiguration conf = new HTMLConfiguration();
         conf.setFeature("http://cyberneko.org/html/features/insert-namespaces", true);
         final AbstractSAXParser parser = new AbstractSAXParser(conf) { };