checkstyle

Author: rbri

src/main/java/org/htmlunit/cyberneko/HTMLConfiguration.java

@@ -267,35 +267,35 @@ public XMLErrorHandler getErrorHandler() {
     }
 
     /**
-     * {@inheritDoc}
+     * @return the configured {@link HTMLElements}
      */
     public HTMLElements getHtmlElements() {
         return htmlElements_;
     }
 
     /**
-     * {@inheritDoc}
+     * @return the configured {@link List} of {@link HTMLComponent}'s
      */
     public List<HTMLComponent> getHtmlComponents() {
         return htmlComponents_;
     }
 
     /**
-     * {@inheritDoc}
+     * @return the configured {@link HTMLScanner}
      */
     public HTMLScanner getDocumentScanner() {
         return documentScanner_;
     }
 
     /**
-     * {@inheritDoc}
+     * @return the configured {@link HTMLTagBalancer}
      */
     public HTMLTagBalancer getTagBalancer() {
         return tagBalancer_;
     }
 
     /**
-     * {@inheritDoc}
+     * @return the configured {@link NamespaceBinder}
      */
     public NamespaceBinder getNamespaceBinder() {
         return namespaceBinder_;

src/main/java/org/htmlunit/cyberneko/HTMLScanner.java

@@ -1005,7 +1005,7 @@ public static String systemId(final String systemId, final String baseSystemId)
                             .replaceAll(" ", "%20");
 
                 }
-                catch (final SecurityException se) {
+                catch (final SecurityException ignored) {
                     dir = "";
                 }
                 if (!dir.endsWith("/")) {
@@ -1024,7 +1024,7 @@ public static String systemId(final String systemId, final String baseSystemId)
                                 // deal with blanks in paths; maybe we have to do better uri encoding here
                                 .replaceAll(" ", "%20");
                     }
-                    catch (final SecurityException se) {
+                    catch (final SecurityException ignored) {
                         dir = "";
                     }
                     if (baseSystemId.indexOf(':') != -1) {
@@ -3656,7 +3656,7 @@ static boolean isEncodingCompatible(final String encoding1, final String encodin
                 try {
                     return canRoundtrip(encoding2, encoding1);
                 }
-                catch (final UnsupportedOperationException e1) {
+                catch (final UnsupportedOperationException ignored) {
                     // encoding2 only supports decode too. Time to give up.
                     return false;
                 }

src/main/java/org/htmlunit/cyberneko/html/dom/HTMLButtonElementImpl.java

@@ -68,7 +68,7 @@ public int getTabIndex() {
         try {
             return Integer.parseInt(getAttribute("tabindex"));
         }
-        catch (final NumberFormatException except) {
+        catch (final NumberFormatException expected) {
             return 0;
         }
     }

src/main/java/org/htmlunit/cyberneko/html/dom/HTMLDocumentImpl.java

@@ -128,9 +128,9 @@ public class HTMLDocumentImpl extends DocumentImpl implements HTMLDocument {
      *
      * @see #createElement
      */
-    private static final FastHashMap<String, ElementTypesHTMLHolder> elementTypesHTMLLower_
+    private static final FastHashMap<String, ElementTypesHTMLHolder> ELEMENT_TYPES_HTML_LOWER
                             = new FastHashMap<>(11, 0.5f);
-    private static final FastHashMap<String, ElementTypesHTMLHolder> elementTypesHTMLUpper_
+    private static final FastHashMap<String, ElementTypesHTMLHolder> ELEMENT_TYPES_HTML_UPPER
                             = new FastHashMap<>(11, 0.5f);
 
     /**
@@ -139,7 +139,7 @@ public class HTMLDocumentImpl extends DocumentImpl implements HTMLDocument {
      *
      * @see #createElement
      */
-    private static final Class<?>[]    elemClassSigHTML_ = new Class[] {HTMLDocumentImpl.class, String.class};
+    private static final Class<?>[] ELEMENT_CLASS_CTOR_SIGNATURE = new Class[] {HTMLDocumentImpl.class, String.class};
 
     static {
         final Map<String, Class<? extends HTMLElementImpl>> tMap = new HashMap<>();
@@ -220,11 +220,11 @@ public class HTMLDocumentImpl extends DocumentImpl implements HTMLDocument {
             final String lKey = key.toLowerCase(Locale.ENGLISH);
 
             try {
-                final Constructor<? extends HTMLElementImpl> ctr = value.getConstructor(elemClassSigHTML_);
+                final Constructor<? extends HTMLElementImpl> ctr = value.getConstructor(ELEMENT_CLASS_CTOR_SIGNATURE);
 
                 final ElementTypesHTMLHolder holder = new ElementTypesHTMLHolder(uKey, ctr);
-                elementTypesHTMLUpper_.put(uKey, holder);
-                elementTypesHTMLLower_.put(lKey, holder);
+                ELEMENT_TYPES_HTML_UPPER.put(uKey, holder);
+                ELEMENT_TYPES_HTML_LOWER.put(lKey, holder);
             }
             catch (NoSuchMethodException | SecurityException ex) {
                 throw new IllegalStateException(
@@ -526,12 +526,12 @@ public Element createElement(final String tagName) throws DOMException {
         // First, make sure tag name is all upper case, next get the associated
         // element class. If no class is found, generate a generic HTML element.
         // Do so also if an unexpected exception occurs.
-        ElementTypesHTMLHolder htmlHolder = elementTypesHTMLLower_.get(tagName);
+        ElementTypesHTMLHolder htmlHolder = ELEMENT_TYPES_HTML_LOWER.get(tagName);
         if (htmlHolder == null) {
             // try uppercase but only if needed and don't use this string to create
             // the element but the stored one to keep the memory usage low when the
             // tree is kept in memory longer
-            htmlHolder = elementTypesHTMLUpper_.get(tagName.toUpperCase(Locale.ENGLISH));
+            htmlHolder = ELEMENT_TYPES_HTML_UPPER.get(tagName.toUpperCase(Locale.ENGLISH));
         }
 
         if (htmlHolder != null) {
@@ -690,8 +690,8 @@ protected boolean canRenameElements(final String newNamespaceURI, final String n
         }
 
         // check whether a class change is required
-        final Constructor<?> newCtr = elementTypesHTMLUpper_.get(newNodeName.toUpperCase(Locale.ENGLISH)).ctr_;
-        final Constructor<?> oldCtr = elementTypesHTMLUpper_.get(el.getTagName().toUpperCase(Locale.ENGLISH)).ctr_;
+        final Constructor<?> newCtr = ELEMENT_TYPES_HTML_UPPER.get(newNodeName.toUpperCase(Locale.ENGLISH)).ctr_;
+        final Constructor<?> oldCtr = ELEMENT_TYPES_HTML_UPPER.get(el.getTagName().toUpperCase(Locale.ENGLISH)).ctr_;
         return newCtr == oldCtr;
     }
 

src/main/java/org/htmlunit/cyberneko/html/dom/HTMLInputElementImpl.java

@@ -172,7 +172,7 @@ public int getTabIndex() {
         try {
             return Integer.parseInt(getAttribute("tabindex"));
         }
-        catch (final NumberFormatException except) {
+        catch (final NumberFormatException expected) {
             return 0;
         }
     }

src/main/java/org/htmlunit/cyberneko/html/dom/HTMLObjectElementImpl.java

@@ -150,7 +150,7 @@ public int getTabIndex() {
         try {
             return Integer.parseInt(getAttribute("tabindex"));
         }
-        catch (final NumberFormatException except) {
+        catch (final NumberFormatException expected) {
             return 0;
         }
     }