PR feedback

Author: joe-yeager

lang/en.lyaml

@@ -651,33 +651,10 @@ en:
           componentsThatWillNotBeMigrated: "[NOTE] These component types are not yet supported for migration but will be available later: {{ components }}"
           errors:
             noAppsForProject: "No apps associated with project {{ projectName }}"
-            noAppsEligible: "No apps in account {{ accountId }} are currently migratable"
             noAccountConfig: "There is no account associated with {{ accountId }} in the config file. Please choose another account and try again, or authenticate {{ accountId }} using {{ authCommand }}."
-            invalidAccountTypeTitle: "{{#bold}}Developer account not targeted{{/bold}}"
-            invalidAccountTypeDescription: "Only public apps created in a developer account can be converted to a project component. Select a connected developer account with {{useCommand}} or {{authCommand}} and try again."
             projectAlreadyExists: "A project with name {{ projectName }} already exists. Please choose another name."
             invalidApp: "Could not migrate appId {{ appId }}. This app cannot be migrated at this time. Please choose another public app."
-            appWithAppIdNotFound: "Could not find an app with the id {{ appId }} "
             migrationFailed: 'Migration Failed'
-          prompt:
-            chooseApp: 'Which app would you like to migrate?'
-            inputName: '[--name] What would you like to name the project?'
-            inputDest: '[--dest] Where would you like to save the project?'
-            uidForComponent: 'What UID would you like to use for {{ componentName }}?'
-            proceed: 'Would you like to proceed?'
-          spinners:
-            beginningMigration: "Beginning migration"
-            unableToStartMigration: "Unable to begin migration"
-            finishingMigration: "Wrapping up migration"
-            migrationComplete: "Migration completed"
-            migrationFailed: "Migration failed"
-            downloadingProjectContents: "Downloading migrated project files"
-            downloadingProjectContentsComplete: "Migrated project files downloaded"
-            downloadingProjectContentsFailed: "Unable to download migrated project files"
-            copyingProjectFiles: "Copying migrated project files"
-            copyingProjectFilesComplete: "Migrated project files copied"
-            copyingProjectFilesFailed: "Unable to copy migrated project files"
-
         cloneApp:
           describe: "Clone a public app using the projects framework."
           examples:

lang/en.ts

@@ -3455,7 +3455,8 @@ export const lib = {
         `Only public apps created in a developer account can be converted to a project component. Select a connected developer account with ${useCommand} or ${authCommand} and try again.`,
       appWithAppIdNotFound: appId =>
         `Could not find an app with the id ${appId} `,
-      noAppsForProject: 'No apps associated with project {{ projectName }}',
+      noAppsForProject: (projectName: string) =>
+        `No apps associated with project ${projectName}`,
       migrationFailed: 'Migration Failed',
     },
     prompt: {

lib/app/migrate.ts

@@ -89,6 +89,14 @@ async function fetchMigrationApps(
     throw new Error(lib.migrate.errors.project.multipleApps);
   }
 
+  if (allApps.length === 0 && projectConfig) {
+    throw new Error(
+      lib.migrate.errors.noAppsForProject(
+        projectConfig?.projectConfig?.name || ''
+      )
+    );
+  }
+
   if (
     allApps.length === 0 ||
     filteredUnmigratableApps.length === allApps.length