Skip to content

Change property sequencing_protocol.local_machine_name #1126

Open
@ESapenaVentura

Description

@ESapenaVentura

For which schema is a change/update being suggested?

I would like an update for the sequencing_protocol.json schema.

What should the change/update be?

Talking with @lauraclarke about how we capture "provenance" information of who did what and with what, we ran into the sequencing_protocol.local_machine_name property.

First, the property should be able to accept multiple machine names for a single sequencing protocol. Options are:

  1. Move the property to sequence_file json so that you can list the machine for each sequencing file provided
  2. Transform property into array of strings. (Undesirable, as we wouldn't be able to tell which machines sequenced which cell suspensions)

Second, the property doesn't feel right being part of a type schema property. We should think about moving it to the process schema. Main problem is, if loaded as a property in the process schema, it can be loaded into any other schema, therefore you could add a "local_machine_name" to a donor, which doesn't feel right either. There needs to be discussion about these changes.

What new field(s) need to be changed/added?

Depends on discussion about 2nd change requested.

Why is the change requested?

The way this property is represented in the schema, it assumes that there is only one machine per sequencing protocol, which is not realistic. There are 2 main problems with it:

  • Data contributors should be able to use multiple names for the machines.
  • This property should belong to the process schema, as we define a process as the execution of a protocol

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions