Skip to content
This repository was archived by the owner on Apr 18, 2024. It is now read-only.

Commit 2dfda8a

Browse files
fix: DEV-2806: Unable to delete relationships between regions (#734)
* fix: DEV-2806: Unable to delete relationships between regions * minor cleanup * minor improvement to be clearer
1 parent 510331f commit 2dfda8a

File tree

2 files changed

+16
-7
lines changed

2 files changed

+16
-7
lines changed

Diff for: src/components/SidePanels/DetailsPanel/Relations.tsx

+15-7
Original file line numberDiff line numberDiff line change
@@ -37,15 +37,19 @@ const RelationItem: FC<{relation: any}> = observer(({ relation }) => {
3737
const [hovered, setHovered] = useState(false);
3838

3939
const onMouseEnter= useCallback(() => {
40-
setHovered(true);
41-
relation.toggleHighlight();
42-
relation.setSelfHighlight(true);
40+
if(!!relation.node1 && !!relation.node2){
41+
setHovered(true);
42+
relation.toggleHighlight();
43+
relation.setSelfHighlight(true);
44+
}
4345
}, []);
4446

4547
const onMouseLeave = useCallback(() => {
46-
setHovered(false);
47-
relation.toggleHighlight();
48-
relation.setSelfHighlight(false);
48+
if(!!relation.node1 && !!relation.node2){
49+
setHovered(false);
50+
relation.toggleHighlight();
51+
relation.setSelfHighlight(false);
52+
}
4953
}, []);
5054

5155
const directionIcon = useMemo(() => {
@@ -105,7 +109,11 @@ const RelationItem: FC<{relation: any}> = observer(({ relation }) => {
105109
</Elem>
106110
<Elem name="action">
107111
{hovered && (
108-
<Button type="text" danger>
112+
<Button type="text" danger onClick={() => {
113+
relation.node1.setHighlight(false);
114+
relation.node2.setHighlight(false);
115+
relation.parent.deleteRelation(relation);
116+
}}>
109117
<IconTrash/>
110118
</Button>
111119
)}

Diff for: src/stores/RelationStore.js

+1
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ const RelationStore = types
142142
},
143143

144144
deleteRelation(rl) {
145+
self._relations = self._relations.filter( r => r.id !== rl.id);
145146
destroy(rl);
146147
},
147148

0 commit comments

Comments
 (0)