fix: LSDV-5164: Unselect labels with tools (#1460)

* create a method for unselecting ajacent labels with tools and fire on toolswitch

* move to actions, double on checks

* unselect all exists already

* check if tool is segmentation tool and only unselect on segmentation tools

* filter segmentation tools with lables before unselect all

* Fix visual discrepancy with multi labels in Info tab

* Fix Label unselection with broken results

When we have broken region with incompatible labels assigned,
we should be able to unassign wrong ones (like with wrong tool).

---------

Co-authored-by: hlomzik <[email protected]>
Co-authored-by: hlomzik <[email protected]>

Author: Travis1282

Diff for: src/components/SidePanels/DetailsPanel/RegionLabels.tsx

@@ -1,8 +1,9 @@
 import { FC } from 'react';
+import { observer } from 'mobx-react';
 
 import { Block } from '../../../utils/bem';
 
-export const RegionLabels: FC<{region: LSFRegion}> = ({ region }) => {
+export const RegionLabels: FC<{region: LSFRegion}> = observer(({ region }) => {
   const labelsInResults = region.results
     .filter(result => result.type.endsWith('labels'))
     .map((result: any) => result.selectedLabels || []);
@@ -24,4 +25,4 @@ export const RegionLabels: FC<{region: LSFRegion}> = ({ region }) => {
       })}
     </Block>
   );
-};
+});

Diff for: src/tags/control/Label.js

@@ -154,14 +154,22 @@ const Model = types.model({
     // is changing the label we need to make sure that region is
     // not going to end up without labels at all
     const applicableRegions = affectedRegions.filter(region => {
+      // if that's the only selected label, the only labelset assigned to region,
+      // and we are trying to unselect it, then don't allow that
+      // (except for rare labelsets that allow empty labels)
       if (
         labels.selectedLabels.length === 1 &&
         self.selected &&
         region.labelings.length === 1 &&
-        (!self.parent?.allowempty || self.isEmpty)
+        (!labels?.allowempty || self.isEmpty)
       )
         return false;
-      if (self.parent?.type !== 'labels' && !self.parent?.type.includes(region.results[0].type)) return false;
+      // @todo rewrite this check and add more named vars
+      // @todo select only related specific labels
+      // @todo unselect any label, but only if that won't leave region without specific labels!
+      // @todo but check for regions created by tools
+      // @todo lot of tests!
+      if (!self.selected && labels.type !== 'labels' && !labels.type.includes(region.type.replace(/region$/, ''))) return false;
       return true;
     });
 

Diff for: src/tools/Manager.js

@@ -100,6 +100,24 @@ class ToolsManager {
 
   selectTool(tool, selected) {
     const currentTool = this.findSelectedTool();
+    const newSelection = tool?.group;
+
+    // if there are no tools selected, there are no specific labels to unselect
+    // also this will skip annotation init
+    if (currentTool && newSelection === 'segmentation') {
+      const toolType = tool.control.type.replace(/labels$/, '');
+      const currentLabels = tool.obj.activeStates();
+      // labels of different types; we can't create regions with different tools simultaneously, so we have to unselect them
+      const unrelatedLabels = currentLabels.filter(tag => {
+        const type = tag.type.replace(/labels$/, '');
+
+        if (tag.type === 'labels') return false;
+        if (type === toolType) return false;
+        return true;
+      });
+
+      unrelatedLabels.forEach(tag => tag.unselectAll());
+    }
 
     if (currentTool && currentTool.handleToolSwitch) {
       currentTool.handleToolSwitch(tool);