Skip to content
This repository was archived by the owner on Apr 18, 2024. It is now read-only.

Commit d56dd55

Browse files
authored
fix: LSDV-4541: Audio segment is being deleted by pressing delete button (#1182)
* fix: LSDV-4541: Audio segment is deleted with delete button * change hotkey name and test name
1 parent 46cf260 commit d56dd55

File tree

3 files changed

+34
-0
lines changed

3 files changed

+34
-0
lines changed

Diff for: e2e/tests/audio.test.js

+26
Original file line numberDiff line numberDiff line change
@@ -88,3 +88,29 @@ Scenario('Check if regions is selected', async function({ I, LabelStudio, AtAudi
8888
AtAudioView.clickAt(220);
8989
AtSidebar.dontSeeSelectedRegion();
9090
});
91+
92+
Scenario('Delete region by pressing delete hotkey', async function({ I, LabelStudio, AtAudioView, AtSidebar }) {
93+
LabelStudio.setFeatureFlags({
94+
ff_front_dev_2715_audio_3_280722_short: true,
95+
});
96+
I.amOnPage('/');
97+
98+
LabelStudio.init(params);
99+
100+
await AtAudioView.waitForAudio();
101+
102+
I.waitForDetached('loading-progress-bar', 10);
103+
104+
await AtAudioView.lookForStage();
105+
106+
AtSidebar.seeRegions(1);
107+
108+
// creating a new region
109+
AtAudioView.dragAudioRegion(160,80);
110+
111+
I.pressKey('Delete');
112+
113+
I.pressKey('1');
114+
115+
AtSidebar.seeRegions(1);
116+
});

Diff for: src/core/settings/keymap.json

+4
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,10 @@
111111
"mac": "command+d",
112112
"description": "Duplicate selected region"
113113
},
114+
"segment:delete": {
115+
"key": "delete",
116+
"description": "Delete selected region"
117+
},
114118
"media:playpause": {
115119
"key": "alt+space",
116120
"description": "Play/pause"

Diff for: src/tags/object/AudioUltra/view.tsx

+4
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,10 @@ const AudioUltraView: FC<AudioUltraProps> = ({ item }) => {
125125
waveform.current?.regions.clearSegments(false);
126126
});
127127

128+
hotkeys.addNamed('segment:delete', () => {
129+
waveform.current?.regions.clearSegments(false);
130+
});
131+
128132
hotkeys.addNamed('region:delete-all', () => {
129133
waveform.current?.regions.clearSegments();
130134
});

0 commit comments

Comments
 (0)