Skip to content

Comments

fix: FIT-1439: FSM State Manager must not attempt to transition state with Anonymous users it should be None#9466

Open
bmartel wants to merge 1 commit intodevelopfrom
fb-FIT-1439
Open

fix: FIT-1439: FSM State Manager must not attempt to transition state with Anonymous users it should be None#9466
bmartel wants to merge 1 commit intodevelopfrom
fb-FIT-1439

Conversation

@bmartel
Copy link
Contributor

@bmartel bmartel commented Feb 24, 2026

This pull request introduces an improvement to how state transitions are handled when triggered by anonymous users, ensuring that the triggered_by field is set appropriately. It also adds a new test to verify this behavior.

Enhancement to state transition logic:

  • Updated the transition_state method in state_manager.py to set triggered_by to None if the user is not authenticated, preventing anonymous users from being incorrectly recorded as the trigger.

Testing improvements:

  • Added a test case in test_fsm_integration.py to verify that state transitions with an AnonymousUser succeed and that triggered_by is set to None.

@netlify
Copy link

netlify bot commented Feb 24, 2026

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 657c341
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/699e2824738c390008a381a5

@netlify
Copy link

netlify bot commented Feb 24, 2026

Deploy Preview for label-studio-storybook canceled.

Name Link
🔨 Latest commit 657c341
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/699e2824c76ae6000865ce23

@netlify
Copy link

netlify bot commented Feb 24, 2026

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 657c341
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/699e2824a71acf000865b606

@github-actions github-actions bot added the fix label Feb 24, 2026
@netlify
Copy link

netlify bot commented Feb 24, 2026

Deploy Preview for label-studio-playground canceled.

Name Link
🔨 Latest commit 657c341
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/699e2824738c390008a381a9

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.60%. Comparing base (3c7db22) to head (657c341).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #9466       +/-   ##
============================================
+ Coverage    68.32%   81.60%   +13.28%     
============================================
  Files         1162      278      -884     
  Lines        68984    25262    -43722     
  Branches     11780        0    -11780     
============================================
- Hits         47133    20616    -26517     
+ Misses       21844     4646    -17198     
+ Partials         7        0        -7     
Flag Coverage Δ
lsf-integration ?
lsf-unit ?
pytests 81.60% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant