fix: FIT-1439: FSM State Manager must not attempt to transition state with Anonymous users it should be None#9466
Open
fix: FIT-1439: FSM State Manager must not attempt to transition state with Anonymous users it should be None#9466
Conversation
… with Anonymous users it should be None
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-storybook canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-playground canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #9466 +/- ##
============================================
+ Coverage 68.32% 81.60% +13.28%
============================================
Files 1162 278 -884
Lines 68984 25262 -43722
Branches 11780 0 -11780
============================================
- Hits 47133 20616 -26517
+ Misses 21844 4646 -17198
+ Partials 7 0 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces an improvement to how state transitions are handled when triggered by anonymous users, ensuring that the
triggered_byfield is set appropriately. It also adds a new test to verify this behavior.Enhancement to state transition logic:
transition_statemethod instate_manager.pyto settriggered_bytoNoneif the user is not authenticated, preventing anonymous users from being incorrectly recorded as the trigger.Testing improvements:
test_fsm_integration.pyto verify that state transitions with anAnonymousUsersucceed and thattriggered_byis set toNone.