Dont swallow errors in fetchAccessToken (#364)

Author: twitchard

src/wrapper/fetchAccessToken.ts

@@ -5,8 +5,6 @@ import { z } from "zod";
  * Fetches a new access token from the Hume API using the provided API key and Secret key.
  *
  * @param args - The arguments for the request.
- * @returns Promise that resolves to the new access token or null.
- * @throws If the base64 encoding fails.
  * @example
  * ```typescript
  * async function getToken() {
@@ -27,11 +25,11 @@ export const fetchAccessToken = async ({
     apiKey: string;
     secretKey: string;
     host?: string;
-}): Promise<string | null> => {
+}): Promise<string> => {
     const authString = `${apiKey}:${secretKey}`;
     const encoded = base64Encode(authString);
 
-    const response = await fetch(`https://${host}/oauth2-cc/token`, {
+    const res = await fetch(`https://${host}/oauth2-cc/token`, {
         method: "POST",
         headers: {
             "Content-Type": "application/x-www-form-urlencoded",
@@ -41,36 +39,13 @@ export const fetchAccessToken = async ({
             grant_type: "client_credentials",
         }).toString(),
         cache: "no-cache",
-    })
-        .then((res) => {
-            // if reading response as json fails, return empty object
-            // this can happen when request returns XML due to server error
-            return res
-                .json()
-                .then((d: unknown) => d)
-                .catch(() => ({}));
+    });
+    return z
+        .object({
+            access_token: z.string(),
         })
-        .then((data: unknown) => {
-            // extract access_token value from received object
-            return z
-                .object({
-                    access_token: z.string(),
-                })
-                .transform((data) => {
-                    return data.access_token;
-                })
-                .safeParse(data);
+        .transform((data) => {
+            return data.access_token;
         })
-        .catch(
-            () =>
-                ({
-                    success: false,
-                }) as const,
-        );
-
-    if (!response.success) {
-        return null;
-    }
-
-    return response.data;
+        .parse(await res.json());
 };