-
Notifications
You must be signed in to change notification settings - Fork 0
Add session keys to wallet contract #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maxgttph
wants to merge
32
commits into
main
Choose a base branch
from
session-key
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BertrandD
reviewed
May 14, 2025
Comment on lines
-170
to
-184
<p> | ||
The password is used to encrypt your wallet. Make sure to remember it, as it will be required for future logins. It isn't stored on any server, there is no recovery possible. | ||
</p> | ||
<p> | ||
The wallet is created using zk proofs, ensuring that your credentials are never exposed. The password is hashed with your wallet id and stored securely on the blockchain. | ||
</p> | ||
<p> | ||
Your username is unique and will be used to identify your wallet. Make sure to choose a name that you will remember. | ||
</p> | ||
<p> | ||
After creating your wallet, you will be able to send and receive transactions using your unique wallet address. | ||
</p> | ||
<p> | ||
If you have any questions or need assistance, please contact our support team. | ||
</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dommage de retirer l'explication je trouve, on peut peut-être rephraser, mais imho il faut expliquer ce qu'on fait. C'est un peu un objectif du testnet si je me trompes pas
Wallet as module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.