Skip to content

clone is potentially overused #20

Open
@pufferfish101007

Description

@pufferfish101007

There's nothing wrong with a few clone()s scattered about in places to satisfy the borrow checker, but there are literally hundreds of them in HyperQuark at the moment, many of which are probably operating on potentially quite large data structures. Where possible, clones should be avoided. cloneing an Rc is fine and inevitable of course and perhaps more references (or smart pointers of some sort) should be used to help this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomershelp wantedwe'd like more people to get involved in this

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions