chore: Convert from ValueTask to Task

Author: bradwilson

src/Hyphen.Sdk/Abstractions/INetInfo.cs

@@ -17,5 +17,5 @@ public interface INetInfo
 	/// <remarks>
 	/// This API supports both IPv4 and IPv6 addresses.
 	/// </remarks>
-	ValueTask<NetInfoResult[]> GetIPInfos(string[] ips, CancellationToken cancellationToken);
+	Task<NetInfoResult[]> GetIPInfos(string[] ips, CancellationToken cancellationToken);
 }

src/Hyphen.Sdk/Extensions/HyphenSdkNetInfoExtensions.cs

@@ -20,7 +20,7 @@ public static class HyphenSdkNetInfoExtensions
 	/// <remarks>
 	/// This API supports both IPv4 and IPv6 addresses.
 	/// </remarks>
-	public static async ValueTask<NetInfoResult> GetIPInfo(this INetInfo netInfo) =>
+	public static async Task<NetInfoResult> GetIPInfo(this INetInfo netInfo) =>
 		(await Guard.ArgumentNotNull(netInfo).GetIPInfos([], default).ConfigureAwait(false))[0];
 
 	/// <summary>
@@ -35,7 +35,7 @@ public static async ValueTask<NetInfoResult> GetIPInfo(this INetInfo netInfo) =>
 	/// <remarks>
 	/// This API supports both IPv4 and IPv6 addresses.
 	/// </remarks>
-	public static async ValueTask<NetInfoResult> GetIPInfo(this INetInfo netInfo, CancellationToken cancellationToken) =>
+	public static async Task<NetInfoResult> GetIPInfo(this INetInfo netInfo, CancellationToken cancellationToken) =>
 		(await Guard.ArgumentNotNull(netInfo).GetIPInfos([], cancellationToken).ConfigureAwait(false))[0];
 
 	/// <summary>
@@ -50,7 +50,7 @@ public static async ValueTask<NetInfoResult> GetIPInfo(this INetInfo netInfo, Ca
 	/// <remarks>
 	/// This API supports both IPv4 and IPv6 addresses.
 	/// </remarks>
-	public static async ValueTask<NetInfoResult> GetIPInfo(this INetInfo netInfo, string ip) =>
+	public static async Task<NetInfoResult> GetIPInfo(this INetInfo netInfo, string ip) =>
 		(await Guard.ArgumentNotNull(netInfo).GetIPInfos([ip], default).ConfigureAwait(false))[0];
 
 	/// <summary>
@@ -66,7 +66,7 @@ public static async ValueTask<NetInfoResult> GetIPInfo(this INetInfo netInfo, st
 	/// <remarks>
 	/// This API supports both IPv4 and IPv6 addresses.
 	/// </remarks>
-	public static async ValueTask<NetInfoResult> GetIPInfo(this INetInfo netInfo, string ip, CancellationToken cancellationToken) =>
+	public static async Task<NetInfoResult> GetIPInfo(this INetInfo netInfo, string ip, CancellationToken cancellationToken) =>
 		(await Guard.ArgumentNotNull(netInfo).GetIPInfos([ip], cancellationToken).ConfigureAwait(false))[0];
 
 	/// <summary>
@@ -81,6 +81,6 @@ public static async ValueTask<NetInfoResult> GetIPInfo(this INetInfo netInfo, st
 	/// <remarks>
 	/// This API supports both IPv4 and IPv6 addresses.
 	/// </remarks>
-	public static ValueTask<NetInfoResult[]> GetIPInfos(this INetInfo netInfo, params string[] ips) =>
+	public static Task<NetInfoResult[]> GetIPInfos(this INetInfo netInfo, params string[] ips) =>
 		Guard.ArgumentNotNull(netInfo).GetIPInfos(ips, default);
 }

src/Hyphen.Sdk/Services/NetInfo.cs

@@ -11,7 +11,7 @@ internal class NetInfo(IHttpClientFactory httpClientFactory, ILogger<INetInfo> l
 		Guard.ArgumentNotNull(options).Value.BaseUri
 			?? (Env.IsDevEnvironment ? new("https://dev.net.info") : new("https://net.info"));
 
-	public ValueTask<NetInfoResult[]> GetIPInfos(string[] ips, CancellationToken cancellationToken)
+	public Task<NetInfoResult[]> GetIPInfos(string[] ips, CancellationToken cancellationToken)
 	{
 		Guard.ArgumentNotNull(ips);
 
@@ -35,7 +35,7 @@ public ValueTask<NetInfoResult[]> GetIPInfos(string[] ips, CancellationToken can
 			);
 	}
 
-	async static ValueTask<NetInfoResult[]> ProcessResponse<T>(
+	async static Task<NetInfoResult[]> ProcessResponse<T>(
 		string[] ips,
 		Func<Task<HttpResponseMessage>> requestThunk,
 		Func<T, NetInfoResult[]> contentProcessor,

test/Hyphen.Sdk.Tests/Services/NetInfoTests.cs

@@ -227,7 +227,7 @@ public async ValueTask GuardClause()
 		{
 			var netInfo = new NetInfo(httpClientFactory, logger, Options.Create(options));
 
-			await Assert.ThrowsAsync<ArgumentNullException>("ips", () => netInfo.GetIPInfos(null!, TestContext.Current.CancellationToken).AsTask());
+			await Assert.ThrowsAsync<ArgumentNullException>("ips", () => netInfo.GetIPInfos(null!, TestContext.Current.CancellationToken));
 		}
 
 		[Fact]