Corrected logic for removing elements from array.

rolivieri · rolivieri · commit 1dafb23b7fef · 2017-04-06T17:19:28.000-04:00
diff --git a/lib/common.sh b/lib/common.sh
@@ -105,6 +105,9 @@ download_dependency() {
 }
 
 download_packages() {
+  # Using unset to remove elements from an array did not always yield
+  # the expected outcome... for instance, removing "python2.7-doc"
+  # resulted in the following error: invalid arithmetic operator (error token is ".7-doc")
   local packages=("$@")
   local pkgs=()
   for package in "${packages[@]}"; do

Original file line number	Diff line number	Diff line change
`@@ -105,6 +105,9 @@ download_dependency() {`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`download_packages() {`
	`108`	`+ # Using unset to remove elements from an array did not always yield`
	`109`	`+ # the expected outcome... for instance, removing "python2.7-doc"`
	`110`	`+ # resulted in the following error: invalid arithmetic operator (error token is ".7-doc")`
`108`	`111`	`local packages=("$@")`
`109`	`112`	`local pkgs=()`
`110`	`113`	`for package in "${packages[@]}"; do`