complete test coverage (#92)

* complete test coverage

* complete test coverage

* complete test coverage

Author: Christian Compton

spec/app_management/initial_startup_spec.rb

@@ -56,7 +56,7 @@ module InitialStartup
     end
   end
 
-  describe '#run' do 
+  describe '#run' do
     context 'there are no handlers' do
       it 'returns nil' do
         expect(run(app_dir, {}, false)).to be_nil
@@ -171,6 +171,58 @@ module InitialStartup
     end
   end
 
+  describe '#startup_with_handlers' do
+    context 'proxy is required' do
+      context 'it is not the first index' do
+        before do
+          ENV['VCAP_APPLICATION'] =  {"instance_index": 1}.to_json
+        end
+
+        it 'calls start_runtime' do
+          allow_any_instance_of(Object).to receive(:handler_list).and_return(%w[handler1 handler2])
+          allow_any_instance_of(Utils::Handlers).to receive(:proxy_required?).and_return(true)
+          allow_any_instance_of(Object).to receive(:start_runtime).with(anything)
+          expect_any_instance_of(Object).to receive(:start_runtime).with(app_dir)
+          startup_with_handlers(app_dir)
+        end
+
+        after do
+          ENV['VCAP_APPLICATION'] = nil
+        end
+      end
+
+      context 'it is the first index' do
+        before do
+          ENV['VCAP_APPLICATION'] = {"instance_index": 0}.to_json
+        end
+
+        it 'calls run_handlers, write_json, and start_proxy' do
+          allow_any_instance_of(Object).to receive(:handler_list).and_return(%w[handler1 handler2])
+          allow_any_instance_of(Utils::Handlers).to receive(:proxy_required?).and_return(true)
+          expect_any_instance_of(Object).to receive(:run_handlers)
+          expect_any_instance_of(Object).to receive(:write_json)
+          expect_any_instance_of(Object).to receive(:start_proxy)
+          startup_with_handlers(app_dir)
+        end
+
+        after do
+          ENV['VCAP_APPLICATION'] = nil
+        end
+
+      end
+    end
+
+    context 'proxy not required' do
+      it 'calls run_handlers and start_runtime' do
+        allow_any_instance_of(Object).to receive(:handler_list).and_return(%w[handler1 handler2])
+        allow_any_instance_of(Utils::Handlers).to receive(:proxy_required?).and_return(false)
+        allow_any_instance_of(Object).to receive(:start_runtime).with(anything)
+        expect_any_instance_of(Object).to receive(:start_runtime).with(app_dir)
+        startup_with_handlers(app_dir)
+      end
+    end
+  end
+
   describe '#startup' do
     context 'handler_list is nil' do
       it 'calls start_runtime and not startup_with_handlers' do

spec/app_management/utils/droplet_utils_spec.rb

@@ -2,6 +2,7 @@
 require 'spec_helper'
 require 'rspec'
 require 'tmpdir'
+require 'timeout'
 require 'socket'
 require_relative '../../../app_management/utils/droplet_utils.rb'
 
@@ -29,6 +30,13 @@
         s.close
       end
     end
+
+    context 'there is a timeout error' do
+      it 'returns false' do
+        allow(Timeout).to receive(:timeout).and_raise(Timeout::Error)
+        expect(DropletUtils.port_bound?(server_port)).not_to be_truthy
+      end
+    end
   end
 
   describe '#find_port' do