It turns out off does not mean disable in logging terms. Fixing PAM module to not print literally everything. (#636)

mew2057 · web-flow · commit e20279cb4151 · 2019-04-08T15:02:09.000-04:00
diff --git a/csmd/src/pamd/src/csm_pam.cc b/csmd/src/pamd/src/csm_pam.cc
@@ -39,7 +39,7 @@ int check_users(const char* userName, char migrate_pid)
         return PAM_SUCCESS;
 
     // Disable logging.
-    csmutil_logging_level_set((char*)"off");
+    csmutil_logging_level_set((char*)"disable");
 
     // 1. Check the active list if the NO_CG flag is not set.
     csm_init_lib();
diff --git a/csmutil/src/csmutil_logging.c b/csmutil/src/csmutil_logging.c
@@ -42,7 +42,7 @@ void csmutil_logging_level_set(char *aLevelStr)
     if (strcasecmp(csmutil_logging_str[i], aLevelStr) == 0) break;
   if (i < NUM_SEVERITIES)
   {
-     fprintf( fp, "[csmapi]: The default log level: %s...\n", aLevelStr);
+     //fprintf( fp, "[csmapi]: The default log level: %s...\n", aLevelStr);
      default_log_level = (csmutil_logging_level) i;
   }
   else

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ void csmutil_logging_level_set(char *aLevelStr)`
`42`	`42`	`if (strcasecmp(csmutil_logging_str[i], aLevelStr) == 0) break;`
`43`	`43`	`if (i < NUM_SEVERITIES)`
`44`	`44`	`{`
`45`		`- fprintf( fp, "[csmapi]: The default log level: %s...\n", aLevelStr);`
	`45`	`+ //fprintf( fp, "[csmapi]: The default log level: %s...\n", aLevelStr);`
`46`	`46`	`default_log_level = (csmutil_logging_level) i;`
`47`	`47`	`}`
`48`	`48`	`else`