Issue 736: fix bbcmds CSM timeout handling

Author: tgooding

bb/scripts/stagein_admin.pl

@@ -68,7 +68,7 @@ ()
 
     print "Creating mount point $BBPATH\n";
     $result = bbcmd("$TARGET_ALL mkdir --path=$BBPATH");
-    push(@cleanup, "$TARGET_ALL rmdir --path=$BBPATH") if(bbgetsuccess($resullt) > 0);
+    push(@cleanup, "$TARGET_ALL rmdir --path=$BBPATH") if(bbgetsuccess($result) > 0);
     failureCleanAndExit("mkdir failed") if(bbgetrc($result) != 0);
 
     print "Changing mount point $BBPATH ownership to $JOBUSER\n";
@@ -81,7 +81,7 @@ ()
 
     print "Creating logical volume $BBPATH with size $BB_SSD_MIN\n";
     $result = bbcmd("$TARGET_ALL create --mount=$BBPATH --size=$BB_SSD_MIN");
-    push(@cleanup, "$TARGET_ALL remove --mount=$BBPATH") if(bbgetsuccess($resullt) > 0);
+    push(@cleanup, "$TARGET_ALL remove --mount=$BBPATH") if(bbgetsuccess($result) > 0);
     failureCleanAndExit("create LV failed") if(bbgetrc($result) != 0);
 }
 

bb/src/nodecontroller_csm.cc

@@ -616,10 +616,14 @@ int NodeController_CSM::bbcmd(std::vector<std::uint32_t> ranklist,
             {
                 output.boost::property_tree::ptree::put_child(results[0].front().first, results[0].front().second); // pick first (good) result
             }
-            else
+            else if(cuml_badresult.size() > 0)
             {
                 output.boost::property_tree::ptree::put_child(cuml_rank, cuml_badresult.front().second); // pick first bad result
             }
+            else
+            {
+                LOG(bb,info) << "bbcmd failure not specific to a node.  rc=" << cuml_rankrc;
+            }
         }
     }
     catch(exception& e)