Refactor JUnit 5 Tests for BaseTestDSASignatureInterop

Replace multiple test classes extending BaseTestDSASignatureInterop with a single JUnit 5 parameterized test class

Signed-off-by: Mohit Rajbhar <mohit.rajbhar@ibm.com>

Author: Mohit-Rajbhar100698

src/test/java/ibm/jceplus/junit/TestMultithread.java

@@ -35,7 +35,6 @@ public class TestMultithread {
             "ibm.jceplus.junit.openjceplus.multithread.TestAliases",
             "ibm.jceplus.junit.openjceplus.multithread.TestDH",
             "ibm.jceplus.junit.openjceplus.multithread.TestDSAKey",
-            "ibm.jceplus.junit.openjceplus.multithread.TestDSASignatureInteropSUN",
             "ibm.jceplus.junit.openjceplus.multithread.TestECDH",
             "ibm.jceplus.junit.openjceplus.multithread.TestECDHInteropSunEC",
             "ibm.jceplus.junit.openjceplus.multithread.TestEdDSASignature",

src/test/java/ibm/jceplus/junit/TestMultithreadFIPS.java

@@ -35,7 +35,6 @@ public class TestMultithreadFIPS {
             "ibm.jceplus.junit.openjceplusfips.multithread.TestAliases",
             "ibm.jceplus.junit.openjceplusfips.multithread.TestDH",
             "ibm.jceplus.junit.openjceplusfips.multithread.TestDSAKey",
-            "ibm.jceplus.junit.openjceplusfips.multithread.TestDSASignatureInteropSUN",
             "ibm.jceplus.junit.openjceplusfips.multithread.TestECDH",
             "ibm.jceplus.junit.openjceplusfips.multithread.TestECDHInteropSunEC",
             "ibm.jceplus.junit.openjceplusfips.multithread.TestHKDF",

src/test/java/ibm/jceplus/junit/openjceplus/TestAll.java

@@ -41,7 +41,6 @@
     TestDSAKey.class,
     TestDSASignature.class,
     TestDSASignatureInteropBC.class,
-    TestDSASignatureInteropSUN.class,
     TestECDH.class,
     TestECDHInteropBC.class,
     TestECDHInteropSunEC.class,

src/test/java/ibm/jceplus/junit/openjceplus/TestDSASignatureInteropSUN.java

@@ -0,0 +1,51 @@
+/*
+ * Copyright IBM Corp. 2023, 2026
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms provided by IBM in the LICENSE file that accompanied
+ * this code, including the "Classpath" Exception described therein.
+ */
+
+package ibm.jceplus.junit.tests;
+
+public class BaseTestInterop extends BaseTest {
+
+    public String interopProviderName;
+    public String interopProviderName2;
+
+    /**
+     * Sets the provider name to interop with.
+     *
+     * @param providerName the provider name associated with this test case for use.
+     */
+    public void setInteropProviderName(String providerName) {
+        this.interopProviderName = providerName;
+    }
+
+    /**
+     * Gets the provider name that is to be used for interop.
+     *
+     * @return The provider name associated with the interop provider name.
+     */
+    public String getInteropProviderName() {
+        return this.interopProviderName;
+    }
+
+    /**
+     * Sets the provider name to interop with.
+     *
+     * @param providerName the provider name associated with this test case for use.
+     */
+    public void setInteropProviderName2(String providerName) {
+        this.interopProviderName2 = providerName;
+    }
+
+    /**
+     * Gets the provider name that is to be used for interop.
+     *
+     * @return The provider name associated with the interop provider name.
+     */
+    public String getInteropProviderName2() {
+        return this.interopProviderName2;
+    }
+}

src/test/java/ibm/jceplus/junit/openjceplus/multithread/TestDSASignatureInteropSUN.java

@@ -0,0 +1,39 @@
+/*
+ * Copyright IBM Corp. 2023, 2026
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms provided by IBM in the LICENSE file that accompanied
+ * this code, including the "Classpath" Exception described therein.
+ */
+
+package ibm.jceplus.junit.tests;
+
+import java.security.PrivateKey;
+import java.security.PublicKey;
+import java.security.Signature;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+public class BaseTestSignatureInterop extends BaseTestInterop {
+
+    protected void doSignVerify(String sigAlgo, byte[] message, PrivateKey privateKey,
+            PublicKey publicKey) throws Exception {
+        doSignVerify(sigAlgo, message, privateKey, publicKey, getProviderName(), getInteropProviderName());
+        doSignVerify(sigAlgo, message, privateKey, publicKey, getInteropProviderName(), getProviderName());
+    }
+
+
+    protected static void doSignVerify(String sigAlgo, byte[] message, PrivateKey privateKey,
+            PublicKey publicKey, String signProvider, String verifyProvider) throws Exception {
+        Signature signing = Signature.getInstance(sigAlgo, signProvider);
+        signing.initSign(privateKey);
+        signing.update(message);
+        byte[] signedBytes = signing.sign();
+
+        Signature verifying = Signature.getInstance(sigAlgo, verifyProvider);
+        verifying.initVerify(publicKey);
+        verifying.update(message);
+
+        assertTrue(verifying.verify(signedBytes), "Signature verification failed");
+    }
+}
+

src/test/java/ibm/jceplus/junit/openjceplusfips/TestDSASignatureInteropSUN.java

@@ -1,12 +1,12 @@
 /*
- * Copyright IBM Corp. 2023, 2024
+ * Copyright IBM Corp. 2023, 2026
  *
  * This code is free software; you can redistribute it and/or modify it
  * under the terms provided by IBM in the LICENSE file that accompanied
  * this code, including the "Classpath" Exception described therein.
  */
 
-package ibm.jceplus.junit.base;
+package ibm.jceplus.junit.tests;
 
 import java.security.InvalidKeyException;
 import java.security.InvalidParameterException;
@@ -21,16 +21,37 @@
 import java.security.spec.PKCS8EncodedKeySpec;
 import java.security.spec.X509EncodedKeySpec;
 import java.util.Arrays;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Tag;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.TestInstance;
+import org.junit.jupiter.params.Parameter;
+import org.junit.jupiter.params.ParameterizedClass;
+import org.junit.jupiter.params.provider.MethodSource;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.junit.jupiter.api.Assertions.fail;
 
-public class BaseTestDSASignatureInterop extends BaseTestSignatureInterop {
+@Tag(Tags.OPENJCEPLUS_NAME)
+@Tag(Tags.OPENJCEPLUS_FIPS_NAME)
+@Tag(Tags.OPENJCEPLUS_MULTITHREAD_NAME)
+@Tag(Tags.OPENJCEPLUS_FIPS_MULTITHREAD_NAME)
+@TestInstance(TestInstance.Lifecycle.PER_CLASS)
+@ParameterizedClass
+@MethodSource("ibm.jceplus.junit.tests.TestArguments#getEnabledProviders")
+public class TestDSASignatureInteropSUN extends BaseTestSignatureInterop {
 
+    @Parameter(0)
+    TestProvider provider;
 
     static final byte[] origMsg = "this is the original message to be signed".getBytes();
 
+    @BeforeEach
+    public void setUp() throws Exception {
+        setAndInsertProvider(provider);
+        setInteropProviderName(TestProvider.SUN.getProviderName());
+    }
+
     @Test
     public void testSHA1withDSA_1024() throws Exception {
         KeyPair keyPair = null;