Add error checking to exec calls

Signed-off-by: Jason Frey <fryguy9@gmail.com>

Author: Fryguy

dist/index.js

@@ -53,17 +53,30 @@ async function installLinux() {
   core.info('Checksum verified successfully')
 
   core.info('Extracting installer...')
-  await exec.exec('tar', ['-xzvf', tarballPath, '-C', tmpDir])
+  let exitCode = await exec.exec('tar', ['-xzvf', tarballPath, '-C', tmpDir])
+  if (exitCode !== 0) {
+    throw new Error(`Failed to extract installer (exit code: ${exitCode})`)
+  }
 
   const extractDir = join(tmpDir, 'Bluemix_CLI')
   core.info('Running installer...')
   const installScript = join(extractDir, 'install')
-  await exec.exec('chmod', ['755', installScript])
-  await exec.exec(installScript, ['-q'])
+  exitCode = await exec.exec('chmod', ['755', installScript])
+  if (exitCode !== 0) {
+    throw new Error(`Failed to set permissions on install script (exit code: ${exitCode})`)
+  }
+
+  exitCode = await exec.exec(installScript, ['-q'])
+  if (exitCode !== 0) {
+    throw new Error(`Installation failed (exit code: ${exitCode})`)
+  }
 
   core.info('Cleaning up temporary files...')
   fs.unlinkSync(tarballPath)
-  await exec.exec('rm', ['-rf', extractDir])
+  exitCode = await exec.exec('rm', ['-rf', extractDir])
+  if (exitCode !== 0) {
+    core.warning(`Failed to clean up temporary directory (exit code: ${exitCode})`)
+  }
 
   core.info('IBM Cloud CLI installed successfully')
 }

dist/index.js.map

@@ -50,7 +50,10 @@ async function installMacOS() {
   core.info('Checksum verified successfully')
 
   core.info('Running installer...')
-  await exec.exec('sudo', ['installer', '-pkg', pkgPath, '-target', '/'])
+  const exitCode = await exec.exec('sudo', ['installer', '-pkg', pkgPath, '-target', '/'])
+  if (exitCode !== 0) {
+    throw new Error(`Installation failed (exit code: ${exitCode})`)
+  }
 
   core.info('Cleaning up temporary files...')
   fs.unlinkSync(pkgPath)

src/install-linux.js

@@ -50,15 +50,21 @@ async function installWindows() {
   core.info('Checksum verified successfully')
 
   core.info('Running installer...')
-  await exec.exec('powershell', ['-command', `& "${installerPath}" /s /v"REBOOT=ReallySuppress /qn"`])
+  let exitCode = await exec.exec('powershell', ['-command', `& "${installerPath}" /s /v"REBOOT=ReallySuppress /qn"`])
+  if (exitCode !== 0) {
+    throw new Error(`Installation failed (exit code: ${exitCode})`)
+  }
 
   core.info('Cleaning up temporary files...')
   fs.unlinkSync(installerPath)
 
   // Add to PATH for the current step
   process.env.PATH += ';C:\\Program Files\\IBM\\Cloud\\bin'
   // Add to GITHUB_PATH for future steps
-  await exec.exec('powershell', ['-command', `Add-Content $env:GITHUB_PATH 'C:\\Program Files\\IBM\\Cloud\\bin'`])
+  exitCode = await exec.exec('powershell', ['-command', `Add-Content $env:GITHUB_PATH 'C:\\Program Files\\IBM\\Cloud\\bin'`])
+  if (exitCode !== 0) {
+    core.warning(`Failed to add IBM Cloud CLI to GITHUB_PATH (exit code: ${exitCode})`)
+  }
 
   core.info('IBM Cloud CLI installed successfully')
 }