fix: transfer removed activity callback and connect not working with allow_dialogs (#197)

Author: dwosk

src/app/core.ts

@@ -211,6 +211,20 @@ export const startTransfer = (transferSpec: TransferSpec, asperaSdkSpec?: Aspera
   if (asperaSdk.useHttpGateway) {
     return transferSpec.direction === 'receive' ? httpDownload(transferSpec, asperaSdkSpec) : httpUpload(transferSpec, asperaSdkSpec);
   } else if (asperaSdk.useConnect) {
+    /**
+     * There is a bug in the Connect transfer client where Connect's HTTP server will no longer return ANY responses if a dialog was opened
+     * when starting the transfer (ex: request or file overwrite confirmation).
+     */
+    if (asperaSdkSpec?.allow_dialogs !== false) {
+      console.warn(
+        '[Aspera SDK] `allow_dialogs` was not set to `false` in AsperaSdkSpec and has been overridden. ' +
+    'Connect dialogs block all subsequent HTTP responses. ' +
+    'Set `allow_dialogs: false` explicitly to suppress this warning. ' +
+    'More info: https://github.com/IBM/aspera-sdk-js/issues/196'
+      );
+      asperaSdkSpec = { ...asperaSdkSpec, allow_dialogs: false };
+    }
+
     return asperaSdk.globals.connect.startTransferPromise(transferSpec as unknown as ConnectTypes.TransferSpec, asperaSdkSpec).then(response => {
       return response.transfer_specs[0] as unknown as AsperaSdkTransfer;
     });

src/models/aspera-sdk.model.ts

@@ -135,15 +135,19 @@ export class ActivityTracking {
   private lastNotifiedWebSocketEvent: WebsocketEvent = undefined;
 
   /**
-   * Notify all consumers when a message is received from the websocket
+   * Notify all consumers when a message is received from the transfer client.
    *
-   * @param message the message received from the websocket
+   * @param message the message received
    */
   handleTransferActivity(message: ActivityMessage): void {
+    const data = message.data && typeof message.data === 'object' && 'transfers' in message.data
+      ? message.data
+      : {transfers: [message.data]};
+
     if (message.type === 'transferUpdated' || message.type === 'transferRemoved') {
       this.activity_callbacks.forEach(callback => {
         if (typeof callback === 'function') {
-          callback(message.data);
+          callback(data);
         }
       });
     }