Skip to content

Commit b6e2d3f

Browse files
committed
Pin upload-artifact and download-artifact versions
Newer versions are not compatible with Ubuntu 18.04. Signed-off-by: Ilya Leoshkevich <[email protected]>
1 parent 45a23fa commit b6e2d3f

File tree

2 files changed

+18
-14
lines changed

2 files changed

+18
-14
lines changed

.github/workflows/dotnet.yml

+11-11
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
- name: Build
4646
run: ARCH=${{ matrix.arch }} ./dotnet-build runtime
4747
- name: Upload the intermediate results
48-
uses: actions/upload-artifact@v3 # Newer versions are not compatible with Ubuntu 18.04
48+
uses: actions/upload-artifact@v3.1.3
4949
with:
5050
name: runtime-${{ matrix.arch }}
5151
path: |
@@ -82,15 +82,15 @@ jobs:
8282
- name: Fix the repository ownership
8383
run: chown -R "$(id -u):$(id -g)" .
8484
- name: Download the previous stage's artifacts
85-
uses: actions/download-artifact@v3 # Newer versions are not compatible with Ubuntu 18.04
85+
uses: actions/download-artifact@v3.0.2
8686
with:
8787
name: runtime-${{ matrix.arch }}
8888
- name: Prepare
8989
run: ./dotnet-prepare msbuild
9090
- name: Build
9191
run: ARCH=${{ matrix.arch }} ./dotnet-build msbuild
9292
- name: Upload the intermediate results
93-
uses: actions/upload-artifact@v3 # Newer versions are not compatible with Ubuntu 18.04
93+
uses: actions/upload-artifact@v3.1.3
9494
with:
9595
name: msbuild-${{ matrix.arch }}
9696
path: |
@@ -127,15 +127,15 @@ jobs:
127127
- name: Fix the repository ownership
128128
run: chown -R "$(id -u):$(id -g)" .
129129
- name: Download the previous stage's artifacts
130-
uses: actions/download-artifact@v3 # Newer versions are not compatible with Ubuntu 18.04
130+
uses: actions/download-artifact@v3.0.2
131131
with:
132132
name: msbuild-${{ matrix.arch }}
133133
- name: Prepare
134134
run: ./dotnet-prepare roslyn
135135
- name: Build
136136
run: ARCH=${{ matrix.arch }} ./dotnet-build roslyn
137137
- name: Upload the intermediate results
138-
uses: actions/upload-artifact@v3 # Newer versions are not compatible with Ubuntu 18.04
138+
uses: actions/upload-artifact@v3.1.3
139139
with:
140140
name: roslyn-${{ matrix.arch }}
141141
path: |
@@ -172,15 +172,15 @@ jobs:
172172
- name: Fix the repository ownership
173173
run: chown -R "$(id -u):$(id -g)" .
174174
- name: Download the previous stage's artifacts
175-
uses: actions/download-artifact@v3 # Newer versions are not compatible with Ubuntu 18.04
175+
uses: actions/download-artifact@v3.0.2
176176
with:
177177
name: roslyn-${{ matrix.arch }}
178178
- name: Prepare
179179
run: ./dotnet-prepare aspnetcore
180180
- name: Build
181181
run: ARCH=${{ matrix.arch }} ./dotnet-build aspnetcore
182182
- name: Upload the intermediate results
183-
uses: actions/upload-artifact@v3 # Newer versions are not compatible with Ubuntu 18.04
183+
uses: actions/upload-artifact@v3.1.3
184184
with:
185185
name: aspnetcore-${{ matrix.arch }}
186186
path: |
@@ -217,15 +217,15 @@ jobs:
217217
- name: Fix the repository ownership
218218
run: chown -R "$(id -u):$(id -g)" .
219219
- name: Download the previous stage's artifacts
220-
uses: actions/download-artifact@v3 # Newer versions are not compatible with Ubuntu 18.04
220+
uses: actions/download-artifact@v3.0.2
221221
with:
222222
name: aspnetcore-${{ matrix.arch }}
223223
- name: Prepare
224224
run: ./dotnet-prepare sdk
225225
- name: Build
226226
run: ARCH=${{ matrix.arch }} ./dotnet-build sdk
227227
- name: Upload the intermediate results
228-
uses: actions/upload-artifact@v3 # Newer versions are not compatible with Ubuntu 18.04
228+
uses: actions/upload-artifact@v3.1.3
229229
with:
230230
name: sdk-${{ matrix.arch }}
231231
path: |
@@ -256,12 +256,12 @@ jobs:
256256
- name: Fix the repository ownership
257257
run: chown -R "$(id -u):$(id -g)" .
258258
- name: Download the ppc64le sdk artifacts
259-
uses: actions/download-artifact@v3 # Newer versions are not compatible with Ubuntu 18.04
259+
uses: actions/download-artifact@v3.0.2
260260
with:
261261
name: sdk-ppc64le
262262
if: ${{ !startsWith(github.ref, 'refs/tags/v6.') }}
263263
- name: Download the s390x sdk artifacts
264-
uses: actions/download-artifact@v3 # Newer versions are not compatible with Ubuntu 18.04
264+
uses: actions/download-artifact@v3.0.2
265265
with:
266266
name: sdk-s390x
267267
- name: Create a release

.github/workflows/dotnet.yml.j2

+7-3
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,10 @@ permissions:
5353
run: chown -R "$(id -u):$(id -g)" .
5454
{%- endset %}
5555

56+
{#- Newer versions use node20 binary, which is not compatible with Ubuntu 18.04 #}
57+
{%- set download_artifact -%}actions/[email protected]{%- endset %}
58+
{%- set upload_artifact -%}actions/[email protected]{%- endset %}
59+
5660
jobs:
5761
{%- for i in range(projects | length) %}
5862
{{ projects[i] }}:
@@ -66,7 +70,7 @@ jobs:
6670
{{ checkout_steps }}
6771
{%- if i != 0 %}
6872
- name: Download the previous stage's artifacts
69-
uses: actions/download-artifact@v3 # Newer versions are not compatible with Ubuntu 18.04
73+
uses: {{ download_artifact }}
7074
with:
7175
name: {{ projects[i - 1] }}-{% raw %}${{ matrix.arch }}{% endraw %}
7276
{%- endif %}
@@ -75,7 +79,7 @@ jobs:
7579
- name: Build
7680
run: ARCH={% raw %}${{ matrix.arch }}{% endraw %} ./dotnet-build {{ projects[i] }}
7781
- name: Upload the intermediate results
78-
uses: actions/upload-artifact@v3 # Newer versions are not compatible with Ubuntu 18.04
82+
uses: {{ upload_artifact }}
7983
with:
8084
name: {{ projects[i] }}-{% raw %}${{ matrix.arch }}{% endraw %}
8185
path: |
@@ -95,7 +99,7 @@ jobs:
9599
{{ checkout_steps }}
96100
{%- for arch in arches %}
97101
- name: Download the {{ arch }} sdk artifacts
98-
uses: actions/download-artifact@v3 # Newer versions are not compatible with Ubuntu 18.04
102+
uses: {{ download_artifact }}
99103
with:
100104
name: sdk-{{ arch }}
101105
{%- if arch == 'ppc64le' %}

0 commit comments

Comments
 (0)