[FIX][API]: Propagate gateway visibility to linked tools/prompts/resources (#3476)

* fix: propagate visibility to linked tools/prompts/resources when gateway is updated

Closes #3475

Signed-off-by: Madhav Kandukuri <madhav165@gmail.com>

* fix(test): assert db.commit() in visibility propagation test

Ensure the test verifies that visibility changes to linked
tools/resources/prompts are actually persisted to the database
when gateway initialization fails.

Closes #3475

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Madhav Kandukuri <madhav165@gmail.com>
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Co-authored-by: Mihai Criveti <crivetimihai@gmail.com>
Signed-off-by: Yosief Eyob <yosiefogbazion@gmail.com>

Author: 2 people

mcpgateway/services/gateway_service.py

@@ -1897,8 +1897,15 @@ async def update_gateway(
                     gateway.tags = gateway_update.tags
                 if gateway_update.visibility is not None:
                     gateway.visibility = gateway_update.visibility
-                if gateway_update.visibility is not None:
-                    gateway.visibility = gateway_update.visibility
+                    # Propagate visibility to all linked items immediately so it
+                    # takes effect even when the upstream server is unreachable
+                    # and _initialize_gateway fails.
+                    for tool in gateway.tools:
+                        tool.visibility = gateway.visibility
+                    for resource in gateway.resources:
+                        resource.visibility = gateway.visibility
+                    for prompt in gateway.prompts:
+                        prompt.visibility = gateway.visibility
                 if gateway_update.passthrough_headers is not None:
                     if isinstance(gateway_update.passthrough_headers, list):
                         gateway.passthrough_headers = gateway_update.passthrough_headers

tests/unit/mcpgateway/services/test_gateway_service.py

@@ -1059,6 +1059,56 @@ async def test_update_gateway_url_initialization_failure(self, gateway_service,
         assert mock_gateway.url == url
         test_db.commit.assert_called_once()
 
+    @pytest.mark.asyncio
+    async def test_update_gateway_visibility_propagates_when_init_fails(self, gateway_service, mock_gateway, test_db):
+        """Visibility change must propagate to linked tools/prompts/resources even when gateway init fails."""
+        # Set up linked items with old visibility
+        mock_tool = MagicMock(spec=DbTool)
+        mock_tool.visibility = "public"
+        mock_resource = MagicMock(spec=DbResource)
+        mock_resource.visibility = "public"
+        mock_prompt = MagicMock(spec=DbPrompt)
+        mock_prompt.visibility = "public"
+
+        mock_gateway.visibility = "public"
+        mock_gateway.auth_type = "bearer"
+        mock_gateway.oauth_config = None
+        mock_gateway.auth_query_params = None
+        mock_gateway.slug = "test_gateway"
+        mock_gateway.tools = [mock_tool]
+        mock_gateway.resources = [mock_resource]
+        mock_gateway.prompts = [mock_prompt]
+
+        test_db.execute = Mock(return_value=_make_execute_result(scalar=mock_gateway))
+        test_db.commit = Mock()
+        test_db.refresh = Mock()
+        mock_query = Mock()
+        mock_query.filter.return_value = mock_query
+        mock_query.first.return_value = None
+        mock_query.all.return_value = []
+        test_db.query = Mock(return_value=mock_query)
+
+        # Gateway is unreachable
+        gateway_service._initialize_gateway = AsyncMock(side_effect=GatewayConnectionError("Connection failed"))
+        gateway_service._notify_gateway_updated = AsyncMock()
+
+        gateway_update = GatewayUpdate(visibility="team")
+
+        mock_gateway_read = MagicMock()
+        mock_gateway_read.masked.return_value = mock_gateway_read
+
+        with patch("mcpgateway.services.gateway_service.GatewayRead.model_validate", return_value=mock_gateway_read):
+            await gateway_service.update_gateway(test_db, 1, gateway_update)
+
+        # Gateway visibility updated
+        assert mock_gateway.visibility == "team"
+        # Linked items must also be updated even though init failed
+        assert mock_tool.visibility == "team", "Tool visibility not propagated when gateway init failed"
+        assert mock_resource.visibility == "team", "Resource visibility not propagated when gateway init failed"
+        assert mock_prompt.visibility == "team", "Prompt visibility not propagated when gateway init failed"
+        # Visibility changes must be persisted
+        test_db.commit.assert_called_once()
+
     @pytest.mark.asyncio
     async def test_update_gateway_partial_update(self, gateway_service, mock_gateway, test_db):
         """Test updating only some fields."""