fix(ui): preserve visibility selection when editing entities (#3402)

* fix: append visibility in edit form handlers to retain selection across edits

Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk>

* fix(ui): add visibility append to A2A edit handler for consistency

The handleEditA2AAgentFormSubmit handler was missing the
formData.append("visibility", ...) call that all other edit
and create handlers have. This ensures visibility is preserved
when editing A2A agents, matching the pattern in the other five
edit handlers.

Closes #3391

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test(ui): add tests for visibility preservation in edit form handlers

Cover all six edit form submit handlers to verify that the
visibility field selected by the user is included in the
submitted FormData: tool, prompt, gateway, server, resource,
and A2A agent.

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix(ui): use formData.set() instead of append() to prevent duplicate visibility entries

formData.append() creates a second visibility key in the submitted
FormData. Since Starlette's ImmutableMultiDict resolves duplicate
keys to the last value, this introduces ordering-dependent behavior.

Replace all 12 append("visibility", ...) calls (6 create + 6 edit
handlers) with set(), which replaces the existing entry instead of
duplicating it. Also strengthen tests to assert exactly one
visibility entry (toEqual([value]) instead of toContain(value)),
so they now fail if duplicates are reintroduced.

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* chore: fix trailing whitespace in sandbox.rs tests

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk>
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Co-authored-by: Mihai Criveti <crivetimihai@gmail.com>

Author: omorros

mcp-servers/rust/filesystem-server/src/sandbox.rs

@@ -83,7 +83,7 @@ mod tests {
         let sandbox = Sandbox::new(vec![path.clone()]).await.unwrap();
         let roots = sandbox.get_roots();
         assert_eq!(roots.len(), 1);
-        
+
         // On macOS, temp paths may be canonicalized from /var to /private/var
         // So we compare the canonicalized version of the temp_dir path
         let expected_canon = fs::canonicalize(temp_dir.path()).await.unwrap();
@@ -131,7 +131,7 @@ mod tests {
             .resolve_path(file_path.to_str().unwrap())
             .await
             .unwrap();
-        
+
         // On macOS, temp paths may be canonicalized from /var to /private/var
         // So we compare against the canonicalized temp_dir path
         let expected_canon = fs::canonicalize(temp_dir.path()).await.unwrap();

mcpgateway/static/admin.js

@@ -15627,7 +15627,7 @@ async function handleGatewayFormSubmit(e) {
             formData.set("oauth_grant_type", "");
         }
 
-        formData.append("visibility", formData.get("visibility"));
+        formData.set("visibility", formData.get("visibility"));
 
         const teamId = new URL(window.location.href).searchParams.get(
             "team_id",
@@ -15714,7 +15714,7 @@ async function handleResourceFormSubmit(e) {
 
         const isInactiveCheckedBool = isInactiveChecked("resources");
         formData.append("is_inactive_checked", isInactiveCheckedBool);
-        formData.append("visibility", formData.get("visibility"));
+        formData.set("visibility", formData.get("visibility"));
         const teamId = new URL(window.location.href).searchParams.get(
             "team_id",
         );
@@ -15784,7 +15784,7 @@ async function handlePromptFormSubmit(e) {
 
         const isInactiveCheckedBool = isInactiveChecked("prompts");
         formData.append("is_inactive_checked", isInactiveCheckedBool);
-        formData.append("visibility", formData.get("visibility"));
+        formData.set("visibility", formData.get("visibility"));
         const teamId = new URL(window.location.href).searchParams.get(
             "team_id",
         );
@@ -15854,6 +15854,7 @@ async function handleEditPromptFormSubmit(e) {
 
         const isInactiveCheckedBool = isInactiveChecked("prompts");
         formData.append("is_inactive_checked", isInactiveCheckedBool);
+        formData.set("visibility", formData.get("visibility"));
 
         // Submit via fetch
         const response = await fetch(form.action, {
@@ -15916,7 +15917,7 @@ async function handleServerFormSubmit(e) {
         const isInactiveCheckedBool = isInactiveChecked("servers");
         formData.append("is_inactive_checked", isInactiveCheckedBool);
 
-        formData.append("visibility", formData.get("visibility"));
+        formData.set("visibility", formData.get("visibility"));
         const teamId = new URL(window.location.href).searchParams.get(
             "team_id",
         );
@@ -16093,7 +16094,7 @@ async function handleA2AFormSubmit(e) {
 
         // ✅ Ensure visibility is captured from checked radio button
         // formData.set("visibility", visibility);
-        formData.append("visibility", formData.get("visibility"));
+        formData.set("visibility", formData.get("visibility"));
         const teamId = new URL(window.location.href).searchParams.get(
             "team_id",
         );
@@ -16195,7 +16196,7 @@ async function handleToolFormSubmit(event) {
         const isInactiveCheckedBool = isInactiveChecked("tools");
         formData.append("is_inactive_checked", isInactiveCheckedBool);
 
-        formData.append("visibility", formData.get("visibility"));
+        formData.set("visibility", formData.get("visibility"));
         const teamId = new URL(window.location.href).searchParams.get(
             "team_id",
         );
@@ -16265,6 +16266,7 @@ async function handleEditToolFormSubmit(event) {
 
         const isInactiveCheckedBool = isInactiveChecked("tools");
         formData.append("is_inactive_checked", isInactiveCheckedBool);
+        formData.set("visibility", formData.get("visibility"));
 
         // Submit via fetch
         const response = await fetch(form.action, {
@@ -16360,6 +16362,7 @@ async function handleEditGatewayFormSubmit(e) {
 
         const isInactiveCheckedBool = isInactiveChecked("gateways");
         formData.append("is_inactive_checked", isInactiveCheckedBool);
+        formData.set("visibility", formData.get("visibility"));
         // Submit via fetch
         const response = await fetch(form.action, {
             method: "POST",
@@ -16459,6 +16462,7 @@ async function handleEditA2AAgentFormSubmit(e) {
 
         const isInactiveCheckedBool = isInactiveChecked("a2a-agents");
         formData.append("is_inactive_checked", isInactiveCheckedBool);
+        formData.set("visibility", formData.get("visibility"));
         // Submit via fetch
         const response = await fetch(form.action, {
             method: "POST",
@@ -16513,6 +16517,7 @@ async function handleEditServerFormSubmit(e) {
 
         const isInactiveCheckedBool = isInactiveChecked("servers");
         formData.append("is_inactive_checked", isInactiveCheckedBool);
+        formData.set("visibility", formData.get("visibility"));
 
         // Merge persistent selection store into FormData so off-screen selections are included
         [
@@ -16622,6 +16627,7 @@ async function handleEditResFormSubmit(e) {
 
         const isInactiveCheckedBool = isInactiveChecked("resources");
         formData.append("is_inactive_checked", isInactiveCheckedBool);
+        formData.set("visibility", formData.get("visibility"));
         // Submit via fetch
         const response = await fetch(form.action, {
             method: "POST",