add missing test coverage

Signed-off-by: Keval Mahajan <mahajankeval23@gmail.com>

Author: kevalmahajan

tests/unit/mcpgateway/services/test_team_management_service.py

@@ -2312,3 +2312,217 @@ async def test_get_user_personal_team_filters_correctly(self, mock_db):
         # Verify execute was called (query construction is internal)
         mock_db.execute.assert_called_once()
         mock_db.commit.assert_called_once()
+
+    def test_should_include_personal_team_all_filters_pass(self):
+        """Test should_include_personal_team returns True when all filters pass."""
+        mock_team = MagicMock(spec=EmailTeam)
+        mock_team.is_active = True
+        mock_team.visibility = "private"
+        mock_team.name = "Test Team"
+        mock_team.slug = "test-team"
+        mock_team.description = "A test description"
+        
+        result = TeamManagementService.should_include_personal_team(
+            mock_team, include_inactive=True, visibility=None, search_query=None
+        )
+        
+        assert result is True
+
+    def test_should_include_personal_team_filters_inactive_team(self):
+        """Test should_include_personal_team filters out inactive teams when include_inactive=False."""
+        mock_team = MagicMock(spec=EmailTeam)
+        mock_team.is_active = False
+        mock_team.visibility = "private"
+        mock_team.name = "Inactive Team"
+        mock_team.slug = "inactive-team"
+        mock_team.description = "An inactive team"
+        
+        result = TeamManagementService.should_include_personal_team(
+            mock_team, include_inactive=False, visibility=None, search_query=None
+        )
+        
+        assert result is False
+
+    def test_should_include_personal_team_includes_inactive_when_flag_set(self):
+        """Test should_include_personal_team includes inactive teams when include_inactive=True."""
+        mock_team = MagicMock(spec=EmailTeam)
+        mock_team.is_active = False
+        mock_team.visibility = "private"
+        mock_team.name = "Inactive Team"
+        mock_team.slug = "inactive-team"
+        mock_team.description = "An inactive team"
+        
+        result = TeamManagementService.should_include_personal_team(
+            mock_team, include_inactive=True, visibility=None, search_query=None
+        )
+        
+        assert result is True
+
+    def test_should_include_personal_team_filters_by_visibility(self):
+        """Test should_include_personal_team filters teams by visibility."""
+        mock_team = MagicMock(spec=EmailTeam)
+        mock_team.is_active = True
+        mock_team.visibility = "private"
+        mock_team.name = "Private Team"
+        mock_team.slug = "private-team"
+        mock_team.description = "A private team"
+        
+        # Should filter out when visibility doesn't match
+        result = TeamManagementService.should_include_personal_team(
+            mock_team, include_inactive=False, visibility="public", search_query=None
+        )
+        
+        assert result is False
+
+    def test_should_include_personal_team_matches_visibility(self):
+        """Test should_include_personal_team includes teams when visibility matches."""
+        mock_team = MagicMock(spec=EmailTeam)
+        mock_team.is_active = True
+        mock_team.visibility = "public"
+        mock_team.name = "Public Team"
+        mock_team.slug = "public-team"
+        mock_team.description = "A public team"
+        
+        result = TeamManagementService.should_include_personal_team(
+            mock_team, include_inactive=False, visibility="public", search_query=None
+        )
+        
+        assert result is True
+
+    def test_should_include_personal_team_search_matches_name(self):
+        """Test should_include_personal_team search query matches team name."""
+        mock_team = MagicMock(spec=EmailTeam)
+        mock_team.is_active = True
+        mock_team.visibility = "private"
+        mock_team.name = "Engineering Team"
+        mock_team.slug = "eng-team"
+        mock_team.description = "Team for engineers"
+        
+        result = TeamManagementService.should_include_personal_team(
+            mock_team, include_inactive=False, visibility=None, search_query="engineering"
+        )
+        
+        assert result is True
+
+    def test_should_include_personal_team_search_matches_slug(self):
+        """Test should_include_personal_team search query matches team slug."""
+        mock_team = MagicMock(spec=EmailTeam)
+        mock_team.is_active = True
+        mock_team.visibility = "private"
+        mock_team.name = "Team Alpha"
+        mock_team.slug = "alpha-squad"
+        mock_team.description = "First team"
+        
+        result = TeamManagementService.should_include_personal_team(
+            mock_team, include_inactive=False, visibility=None, search_query="squad"
+        )
+        
+        assert result is True
+
+    def test_should_include_personal_team_search_matches_description(self):
+        """Test should_include_personal_team search query matches team description."""
+        mock_team = MagicMock(spec=EmailTeam)
+        mock_team.is_active = True
+        mock_team.visibility = "private"
+        mock_team.name = "Team Beta"
+        mock_team.slug = "beta"
+        mock_team.description = "Specialized operations team"
+        
+        result = TeamManagementService.should_include_personal_team(
+            mock_team, include_inactive=False, visibility=None, search_query="operations"
+        )
+        
+        assert result is True
+
+    def test_should_include_personal_team_search_case_insensitive(self):
+        """Test should_include_personal_team search is case-insensitive."""
+        mock_team = MagicMock(spec=EmailTeam)
+        mock_team.is_active = True
+        mock_team.visibility = "private"
+        mock_team.name = "DevOps Team"
+        mock_team.slug = "devops"
+        mock_team.description = "Infrastructure team"
+        
+        result = TeamManagementService.should_include_personal_team(
+            mock_team, include_inactive=False, visibility=None, search_query="DEVOPS"
+        )
+        
+        assert result is True
+
+    def test_should_include_personal_team_search_no_match(self):
+        """Test should_include_personal_team filters out teams when search doesn't match."""
+        mock_team = MagicMock(spec=EmailTeam)
+        mock_team.is_active = True
+        mock_team.visibility = "private"
+        mock_team.name = "Marketing Team"
+        mock_team.slug = "marketing"
+        mock_team.description = "Marketing operations"
+        
+        result = TeamManagementService.should_include_personal_team(
+            mock_team, include_inactive=False, visibility=None, search_query="engineering"
+        )
+        
+        assert result is False
+
+    def test_should_include_personal_team_search_with_none_description(self):
+        """Test should_include_personal_team handles None description in search."""
+        mock_team = MagicMock(spec=EmailTeam)
+        mock_team.is_active = True
+        mock_team.visibility = "private"
+        mock_team.name = "Sales Team"
+        mock_team.slug = "sales"
+        mock_team.description = None
+        
+        # Should not match description (None), but should match name
+        result = TeamManagementService.should_include_personal_team(
+            mock_team, include_inactive=False, visibility=None, search_query="sales"
+        )
+        
+        assert result is True
+
+    def test_should_include_personal_team_search_no_match_with_none_description(self):
+        """Test should_include_personal_team filters out when search doesn't match and description is None."""
+        mock_team = MagicMock(spec=EmailTeam)
+        mock_team.is_active = True
+        mock_team.visibility = "private"
+        mock_team.name = "Finance Team"
+        mock_team.slug = "finance"
+        mock_team.description = None
+        
+        result = TeamManagementService.should_include_personal_team(
+            mock_team, include_inactive=False, visibility=None, search_query="marketing"
+        )
+        
+        assert result is False
+
+    def test_should_include_personal_team_multiple_filters_combined(self):
+        """Test should_include_personal_team with multiple filters applied together."""
+        mock_team = MagicMock(spec=EmailTeam)
+        mock_team.is_active = True
+        mock_team.visibility = "public"
+        mock_team.name = "Open Source Team"
+        mock_team.slug = "opensource"
+        mock_team.description = "Public contributions"
+        
+        # All filters should pass
+        result = TeamManagementService.should_include_personal_team(
+            mock_team, include_inactive=False, visibility="public", search_query="open"
+        )
+        
+        assert result is True
+
+    def test_should_include_personal_team_multiple_filters_one_fails(self):
+        """Test should_include_personal_team returns False when one filter fails."""
+        mock_team = MagicMock(spec=EmailTeam)
+        mock_team.is_active = True
+        mock_team.visibility = "private"
+        mock_team.name = "Internal Team"
+        mock_team.slug = "internal"
+        mock_team.description = "Private operations"
+        
+        # Visibility filter should fail
+        result = TeamManagementService.should_include_personal_team(
+            mock_team, include_inactive=False, visibility="public", search_query="internal"
+        )
+        
+        assert result is False