-
Notifications
You must be signed in to change notification settings - Fork 12
Open
Description
Describe the bug
We noted that Build for Github Action did not fail even after the test cases failed.
To Reproduce
- Open any PR. PR for reference - feat: bot management #107
- Go to checks for the PR
- Open Analyze (go) on the left side tab
- Expand the Autobuild step and check test cases
Expected behavior
It is expected for Github Action to fail, as the test cases have failed.
Must gather (please complete the following information):
- SDK Version [e.g. 1.2.1] - v0.36.0
- Go Version [e.g. 1.12.15] - go1.18.1 darwin/amd64
- Name of service that you're trying to use (if applicable)
- Name of operation that you're trying to invoke (if applicable)
Additional context
It is expected for Github Action to fail, if the test cases are failing. This breaks the basic idea of building and testing the PR before merging it to the master.
Point to mention that we have Travis build for merge commits only.
Metadata
Metadata
Assignees
Labels
No labels
