Skip to content

Commit 821a0c5

Browse files
author
Kenny Scharm
authored
Fix e2e test redis image name (#10)
* Fix e2e test redis image name
1 parent 9c7f1fe commit 821a0c5

File tree

5 files changed

+16
-12
lines changed

5 files changed

+16
-12
lines changed

.github/workflows/pull_request.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ jobs:
158158
- name: Build images
159159
run: |
160160
docker build -f Dockerfile.operator -t ibmcom/operator-for-redis:local .
161-
docker build -f Dockerfile.node -t ibmcom/node-for-redis:local .
161+
docker build -f Dockerfile.node -t ibmcom/node-for-redis:local -t ibmcom/node-for-redis:new .
162162
docker build -f Dockerfile.metrics -t ibmcom/metrics-for-redis:local .
163163
164164
- name: kind create cluster
@@ -174,6 +174,7 @@ jobs:
174174
run: |
175175
kind load docker-image ibmcom/operator-for-redis:local
176176
kind load docker-image ibmcom/node-for-redis:local
177+
kind load docker-image ibmcom/node-for-redis:new
177178
kind load docker-image ibmcom/metrics-for-redis:local
178179
179180
- name: Install operator-for-redis with Helm

docs/docs/cookbook.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -155,21 +155,21 @@ If you followed the steps for creating a `kind` cluster with the e2e test config
155155

156156
Build the required docker images:
157157
```console
158-
make container PREFIX= TAG=local
159-
make container-node PREFIX= TAG=new
158+
make container PREFIX=ibmcom/ TAG=local
159+
make container-node PREFIX=ibmcom/ TAG=new
160160
```
161161
Note that we need both `local` and `new` image tags for a rolling update e2e test case.
162162

163163
Load the required images into the kind cluster:
164164
```console
165-
$ kind load docker-image operator-for-redis:local
166-
$ kind load docker-image node-for-redis:local
167-
$ kind load docker-image node-for-redis:new
165+
$ kind load docker-image ibmcom/operator-for-redis:local
166+
$ kind load docker-image ibmcom/node-for-redis:local
167+
$ kind load docker-image ibmcom/node-for-redis:new
168168
```
169169

170170
Once the kind cluster is up and running, deploy the `operator-for-redis` Helm chart:
171171
```console
172-
$ helm install op charts/operator-for-redis --wait --set image.repository=operator-for-redis --set image.tag=local
172+
$ helm install op charts/operator-for-redis --wait --set image.repository=ibmcom/operator-for-redis --set image.tag=local
173173
NAME: op
174174
LAST DEPLOYED: Thu Oct 21 15:11:51 2021
175175
NAMESPACE: default

docs/docs/home.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,12 +97,11 @@ make TAG=<Your-TAG> container
9797

9898
### How to Release the Redis Operator
9999

100-
> THIS IS FOR RELEASE INTO ICM REPOS:
101100
>
102101
> Do the following in `main` branch:
103102
> 1. Create a tag on commit
104103
> 2. Push the commit and tag
105-
> 3. ICM automation will build and push docker images and helm charts with git tag version
104+
> 3. Github actions automation will build and push docker images and helm charts with release version
106105
>
107106
> NOTE: If you need to test the build prior to the above steps, you can run: `make build` and resolve any issues.
108107

docs/docusaurus.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ module.exports = {
1818
},
1919
navbar: {
2020
hideOnScroll: false,
21-
title: 'ICM Redis Operator',
21+
title: 'Operator for Redis Cluster',
2222
logo: {
2323
src: 'images/logo.svg',
2424
srcDark: 'images/logo.svg',

test/e2e/framework/redis_cluster_handlers.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,10 @@ import (
2727
"k8s.io/apimachinery/pkg/util/intstr"
2828
)
2929

30+
const (
31+
redisImageName = "ibmcom/node-for-redis"
32+
)
33+
3034
// NewRedisCluster builds and returns a new RedisCluster instance
3135
func NewRedisCluster(name, namespace, tag string, nbPrimary, replication int32) *rapi.RedisCluster {
3236
cluster := &rapi.RedisCluster{
@@ -67,7 +71,7 @@ func NewRedisCluster(name, namespace, tag string, nbPrimary, replication int32)
6771
Containers: []v1.Container{
6872
{
6973
Name: "redis",
70-
Image: fmt.Sprintf("icm-redis-node:%s", tag),
74+
Image: fmt.Sprintf("%s:%s", redisImageName, tag),
7175
ImagePullPolicy: v1.PullIfNotPresent,
7276
Args: []string{
7377
"--v=6",
@@ -472,7 +476,7 @@ func CreateRedisNodeServiceAccountFunc(kubeClient kclient.Client, redisCluster *
472476
}
473477

474478
// IsPodDisruptionBudgetCreatedFunc returns the func that checks if the PodDisruptionBudget
475-
// associated with the the RedisCluster has been created properly.
479+
// associated with the RedisCluster has been created properly.
476480
func IsPodDisruptionBudgetCreatedFunc(kubeClient kclient.Client, redisCluster *rapi.RedisCluster) func() error {
477481
return func() error {
478482
pdbName := types.NamespacedName{Namespace: redisCluster.Namespace, Name: redisCluster.Name}

0 commit comments

Comments
 (0)