-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Expand file tree
/
Copy pathadmin_transactions_test.go
More file actions
831 lines (730 loc) · 31.5 KB
/
Copy pathadmin_transactions_test.go
File metadata and controls
831 lines (730 loc) · 31.5 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
//go:build !functional
package sarama
import (
"errors"
"fmt"
"io"
"testing"
"github.com/stretchr/testify/require"
)
func TestClusterAdminDescribeProducers(t *testing.T) {
topicName := "my_topic"
seedBroker := NewMockBroker(t, 1)
defer seedBroker.Close()
producer := ProducerState{ProducerID: 1234, ProducerEpoch: 5, LastSequence: 10}
seedBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()).
SetLeader(topicName, 0, seedBroker.BrokerID()).
SetLeader(topicName, 1, seedBroker.BrokerID()),
"DescribeProducersRequest": NewMockDescribeProducersResponse(t).
AddProducer(topicName, 0, producer),
})
config := NewTestConfig()
config.Version = V2_8_0_0
admin, err := NewClusterAdmin([]string{seedBroker.Addr()}, config)
require.NoError(t, err)
defer func() { _ = admin.Close() }()
txAdmin := admin.(TransactionClusterAdmin)
result, err := txAdmin.DescribeProducers(map[string][]int32{topicName: {0, 1}})
require.NoError(t, err)
require.Len(t, result[topicName], 2)
require.Equal(t, int64(1234), result[topicName][0].ActiveProducers[0].ProducerID)
require.Empty(t, result[topicName][1].ActiveProducers)
}
func TestClusterAdminDescribeProducersMultiBroker(t *testing.T) {
topicName := "my_topic"
seedBroker := NewMockBroker(t, 1)
secondBroker := NewMockBroker(t, 2)
defer seedBroker.Close()
defer secondBroker.Close()
seedBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()).
SetBroker(secondBroker.Addr(), secondBroker.BrokerID()).
SetLeader(topicName, 0, seedBroker.BrokerID()).
SetLeader(topicName, 1, secondBroker.BrokerID()),
"DescribeProducersRequest": NewMockDescribeProducersResponse(t).
AddProducer(topicName, 0, ProducerState{ProducerID: 1}),
})
secondBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()).
SetBroker(secondBroker.Addr(), secondBroker.BrokerID()).
SetLeader(topicName, 0, seedBroker.BrokerID()).
SetLeader(topicName, 1, secondBroker.BrokerID()),
"DescribeProducersRequest": NewMockDescribeProducersResponse(t).
AddProducer(topicName, 1, ProducerState{ProducerID: 2}),
})
config := NewTestConfig()
config.Version = V2_8_0_0
admin, err := NewClusterAdmin([]string{seedBroker.Addr()}, config)
require.NoError(t, err)
defer func() { _ = admin.Close() }()
txAdmin := admin.(TransactionClusterAdmin)
result, err := txAdmin.DescribeProducers(map[string][]int32{topicName: {0, 1}})
require.NoError(t, err)
require.Len(t, result[topicName], 2)
require.Equal(t, int64(1), result[topicName][0].ActiveProducers[0].ProducerID)
require.Equal(t, int64(2), result[topicName][1].ActiveProducers[0].ProducerID)
}
func TestClusterAdminDescribeProducersEmpty(t *testing.T) {
seedBroker := NewMockBroker(t, 1)
defer seedBroker.Close()
seedBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()),
})
config := NewTestConfig()
config.Version = V2_8_0_0
admin, err := NewClusterAdmin([]string{seedBroker.Addr()}, config)
require.NoError(t, err)
defer func() { _ = admin.Close() }()
txAdmin := admin.(TransactionClusterAdmin)
// No DescribeProducersRequest handler is registered: if the method issued a
// request for empty input the mock broker would error.
result, err := txAdmin.DescribeProducers(nil)
require.NoError(t, err)
require.Empty(t, result)
}
func TestClusterAdminDescribeProducersPartialFailure(t *testing.T) {
topicName := "my_topic"
seedBroker := NewMockBroker(t, 1)
defer seedBroker.Close()
seedBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()).
SetLeader(topicName, 0, seedBroker.BrokerID()),
"DescribeProducersRequest": NewMockDescribeProducersResponse(t).
AddProducer(topicName, 0, ProducerState{ProducerID: 7}),
})
config := NewTestConfig()
config.Version = V2_8_0_0
admin, err := NewClusterAdmin([]string{seedBroker.Addr()}, config)
require.NoError(t, err)
defer func() { _ = admin.Close() }()
txAdmin := admin.(TransactionClusterAdmin)
// Partition 0 has a leader; partition 99 does not, so its leader lookup fails
// while the reachable partition still returns a result.
result, err := txAdmin.DescribeProducers(map[string][]int32{topicName: {0, 99}})
require.Error(t, err)
// The leader-lookup failure is wrapped with the partition and topic it was for.
require.ErrorContains(t, err, fmt.Sprintf("find leader for partition 99 of topic %s", topicName))
require.Equal(t, int64(7), result[topicName][0].ActiveProducers[0].ProducerID)
}
func TestClusterAdminDescribeProducersSurfacesPartitionError(t *testing.T) {
topicName := "my_topic"
seedBroker := NewMockBroker(t, 1)
defer seedBroker.Close()
seedBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()).
SetLeader(topicName, 0, seedBroker.BrokerID()),
"DescribeProducersRequest": NewMockDescribeProducersResponse(t).
SetError(topicName, 0, ErrClusterAuthorizationFailed),
})
config := NewTestConfig()
config.Version = V2_8_0_0
admin, err := NewClusterAdmin([]string{seedBroker.Addr()}, config)
require.NoError(t, err)
defer func() { _ = admin.Close() }()
txAdmin := admin.(TransactionClusterAdmin)
result, err := txAdmin.DescribeProducers(map[string][]int32{topicName: {0}})
// A per-partition error code is carried through in the struct, not lifted to
// the aggregate error.
require.NoError(t, err)
require.Equal(t, ErrClusterAuthorizationFailed, result[topicName][0].ErrorCode)
}
func TestClusterAdminDescribeProducersBrokerTransportError(t *testing.T) {
topicName := "my_topic"
seedBroker := NewMockBroker(t, 1)
secondBroker := NewMockBroker(t, 2)
defer seedBroker.Close()
secondClosed := false
defer func() {
if !secondClosed {
secondBroker.Close()
}
}()
metadata := NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()).
SetBroker(secondBroker.Addr(), secondBroker.BrokerID()).
SetLeader(topicName, 0, seedBroker.BrokerID()).
SetLeader(topicName, 1, secondBroker.BrokerID())
seedBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": metadata,
"DescribeProducersRequest": NewMockDescribeProducersResponse(t).
AddProducer(topicName, 0, ProducerState{ProducerID: 7}),
})
secondBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": metadata,
})
config := NewTestConfig()
config.Version = V2_8_0_0
admin, err := NewClusterAdmin([]string{seedBroker.Addr()}, config)
require.NoError(t, err)
defer func() { _ = admin.Close() }()
// Cache both partition leaders while the brokers are reachable, then close the
// leader of partition 1 so its request fails at the transport layer while
// partition 0's leader still answers.
secondAddr := secondBroker.Addr()
ca := admin.(*clusterAdmin)
require.NoError(t, ca.client.RefreshMetadata(topicName))
secondBroker.Close()
secondClosed = true
txAdmin := admin.(TransactionClusterAdmin)
result, err := txAdmin.DescribeProducers(map[string][]int32{topicName: {0, 1}})
// The reachable partition is returned; the unreachable partition is dropped and
// its transport failure surfaces in the aggregate error, wrapped with the broker
// it was sent to.
require.Error(t, err)
require.ErrorContains(t, err, fmt.Sprintf("describe producers on broker %s", secondAddr))
require.Equal(t, int64(7), result[topicName][0].ActiveProducers[0].ProducerID)
_, present := result[topicName][1]
require.False(t, present)
}
func TestClusterAdminDescribeTransactions(t *testing.T) {
txID := "my-tx"
seedBroker := NewMockBroker(t, 1)
defer seedBroker.Close()
seedBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()),
"FindCoordinatorRequest": NewMockFindCoordinatorResponse(t).
SetCoordinator(CoordinatorTransaction, txID, seedBroker),
"DescribeTransactionsRequest": NewMockDescribeTransactionsResponse(t).
AddTransaction(txID, TransactionState{TransactionState: TransactionStateOngoing, ProducerID: 42}),
})
config := NewTestConfig()
config.Version = V3_0_0_0
admin, err := NewClusterAdmin([]string{seedBroker.Addr()}, config)
require.NoError(t, err)
defer func() { _ = admin.Close() }()
txAdmin := admin.(TransactionClusterAdmin)
result, err := txAdmin.DescribeTransactions([]string{txID})
require.NoError(t, err)
require.Len(t, result, 1)
require.Equal(t, TransactionStateOngoing, result[txID].TransactionState)
require.Equal(t, int64(42), result[txID].ProducerID)
}
func TestClusterAdminDescribeTransactionsMultiCoordinator(t *testing.T) {
firstTx := "tx-1"
secondTx := "tx-2"
seedBroker := NewMockBroker(t, 1)
secondBroker := NewMockBroker(t, 2)
defer seedBroker.Close()
defer secondBroker.Close()
seedBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()).
SetBroker(secondBroker.Addr(), secondBroker.BrokerID()),
"FindCoordinatorRequest": NewMockFindCoordinatorResponse(t).
SetCoordinator(CoordinatorTransaction, firstTx, seedBroker).
SetCoordinator(CoordinatorTransaction, secondTx, secondBroker),
"DescribeTransactionsRequest": NewMockDescribeTransactionsResponse(t).
AddTransaction(firstTx, TransactionState{TransactionState: TransactionStateOngoing}),
})
secondBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()).
SetBroker(secondBroker.Addr(), secondBroker.BrokerID()),
"DescribeTransactionsRequest": NewMockDescribeTransactionsResponse(t).
AddTransaction(secondTx, TransactionState{TransactionState: TransactionStateEmpty}),
})
config := NewTestConfig()
config.Version = V3_0_0_0
admin, err := NewClusterAdmin([]string{seedBroker.Addr()}, config)
require.NoError(t, err)
defer func() { _ = admin.Close() }()
txAdmin := admin.(TransactionClusterAdmin)
result, err := txAdmin.DescribeTransactions([]string{firstTx, secondTx})
require.NoError(t, err)
require.Len(t, result, 2)
require.Equal(t, TransactionStateOngoing, result[firstTx].TransactionState)
require.Equal(t, TransactionStateEmpty, result[secondTx].TransactionState)
}
func TestClusterAdminDescribeTransactionsEmpty(t *testing.T) {
seedBroker := NewMockBroker(t, 1)
defer seedBroker.Close()
seedBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()),
})
config := NewTestConfig()
config.Version = V3_0_0_0
admin, err := NewClusterAdmin([]string{seedBroker.Addr()}, config)
require.NoError(t, err)
defer func() { _ = admin.Close() }()
txAdmin := admin.(TransactionClusterAdmin)
// No FindCoordinator/DescribeTransactions handlers: if the method looked up a
// coordinator for empty input the mock broker would error.
result, err := txAdmin.DescribeTransactions(nil)
require.NoError(t, err)
require.Empty(t, result)
}
func TestClusterAdminDescribeTransactionsRetriesOnRetriableCoordinatorError(t *testing.T) {
for _, kerr := range []KError{ErrNotCoordinatorForConsumer, ErrConsumerCoordinatorNotAvailable, ErrOffsetsLoadInProgress} {
t.Run(kerr.Error(), func(t *testing.T) {
txID := "my-tx"
seedBroker := NewMockBroker(t, 1)
defer seedBroker.Close()
seedBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()),
"FindCoordinatorRequest": NewMockFindCoordinatorResponse(t).
SetCoordinator(CoordinatorTransaction, txID, seedBroker),
// The coordinator first answers successfully but tags the
// transaction with a retriable coordinator code, then succeeds.
"DescribeTransactionsRequest": NewMockSequence(
NewMockDescribeTransactionsResponse(t).SetError(txID, kerr),
NewMockDescribeTransactionsResponse(t).
AddTransaction(txID, TransactionState{TransactionState: TransactionStateOngoing}),
),
})
config := NewTestConfig()
config.Version = V3_0_0_0
config.Admin.Retry.Backoff = 0
admin, err := NewClusterAdmin([]string{seedBroker.Addr()}, config)
require.NoError(t, err)
defer func() { _ = admin.Close() }()
txAdmin := admin.(TransactionClusterAdmin)
result, err := txAdmin.DescribeTransactions([]string{txID})
require.NoError(t, err)
require.Equal(t, TransactionStateOngoing, result[txID].TransactionState)
require.Equal(t, ErrNoError, result[txID].ErrorCode)
})
}
}
func TestClusterAdminDescribeTransactionsRegroupsCoordinatorsOnRetry(t *testing.T) {
firstTx := "tx-1"
secondTx := "tx-2"
seedBroker := NewMockBroker(t, 1)
secondBroker := NewMockBroker(t, 2)
defer seedBroker.Close()
defer secondBroker.Close()
metadata := NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()).
SetBroker(secondBroker.Addr(), secondBroker.BrokerID())
// Both transactions initially resolve to the seed broker, so they are grouped
// into a single request. The initial grouping issues exactly one
// FindCoordinator per id (both -> seed), consuming the first two sequence
// entries; every refresh afterwards sees tx-2 moved to the second broker.
seedBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": metadata,
"FindCoordinatorRequest": NewMockSequence(
NewMockFindCoordinatorResponse(t).
SetCoordinator(CoordinatorTransaction, firstTx, seedBroker).
SetCoordinator(CoordinatorTransaction, secondTx, seedBroker),
NewMockFindCoordinatorResponse(t).
SetCoordinator(CoordinatorTransaction, firstTx, seedBroker).
SetCoordinator(CoordinatorTransaction, secondTx, seedBroker),
NewMockFindCoordinatorResponse(t).
SetCoordinator(CoordinatorTransaction, firstTx, seedBroker).
SetCoordinator(CoordinatorTransaction, secondTx, secondBroker),
),
// The seed broker owns tx-1 but not tx-2, which it rejects with
// NOT_COORDINATOR on every attempt. The pre-fix code sent the whole group
// to ids[0]'s coordinator on retry, so tx-2 could never succeed here.
"DescribeTransactionsRequest": NewMockDescribeTransactionsResponse(t).
AddTransaction(firstTx, TransactionState{TransactionState: TransactionStateOngoing}).
SetError(secondTx, ErrNotCoordinatorForConsumer),
})
secondBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": metadata,
"DescribeTransactionsRequest": NewMockDescribeTransactionsResponse(t).
AddTransaction(secondTx, TransactionState{TransactionState: TransactionStateEmpty}),
})
config := NewTestConfig()
config.Version = V3_0_0_0
config.Admin.Retry.Backoff = 0
admin, err := NewClusterAdmin([]string{seedBroker.Addr()}, config)
require.NoError(t, err)
defer func() { _ = admin.Close() }()
txAdmin := admin.(TransactionClusterAdmin)
result, err := txAdmin.DescribeTransactions([]string{firstTx, secondTx})
require.NoError(t, err)
require.Len(t, result, 2)
require.Equal(t, TransactionStateOngoing, result[firstTx].TransactionState)
require.Equal(t, TransactionStateEmpty, result[secondTx].TransactionState)
}
func TestClusterAdminDescribeTransactionsPartialFailure(t *testing.T) {
okTx := "ok-tx"
badTx := "bad-tx"
seedBroker := NewMockBroker(t, 1)
defer seedBroker.Close()
seedBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()),
"FindCoordinatorRequest": NewMockFindCoordinatorResponse(t).
SetCoordinator(CoordinatorTransaction, okTx, seedBroker).
SetError(CoordinatorTransaction, badTx, ErrClusterAuthorizationFailed),
"DescribeTransactionsRequest": NewMockDescribeTransactionsResponse(t).
AddTransaction(okTx, TransactionState{TransactionState: TransactionStateOngoing}),
})
config := NewTestConfig()
config.Version = V3_0_0_0
config.Admin.Retry.Backoff = 0
admin, err := NewClusterAdmin([]string{seedBroker.Addr()}, config)
require.NoError(t, err)
defer func() { _ = admin.Close() }()
txAdmin := admin.(TransactionClusterAdmin)
result, err := txAdmin.DescribeTransactions([]string{okTx, badTx})
require.Error(t, err)
// The coordinator-lookup failure is wrapped with the transactional id it was for.
require.ErrorContains(t, err, fmt.Sprintf("find coordinator for transactional id %s", badTx))
require.Equal(t, TransactionStateOngoing, result[okTx].TransactionState)
_, present := result[badTx]
require.False(t, present)
}
func TestClusterAdminDescribeTransactionsSurfacesTerminalError(t *testing.T) {
txID := "my-tx"
seedBroker := NewMockBroker(t, 1)
defer seedBroker.Close()
seedBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()),
"FindCoordinatorRequest": NewMockFindCoordinatorResponse(t).
SetCoordinator(CoordinatorTransaction, txID, seedBroker),
"DescribeTransactionsRequest": NewMockDescribeTransactionsResponse(t).
SetError(txID, ErrTransactionalIDAuthorizationFailed),
})
config := NewTestConfig()
config.Version = V3_0_0_0
config.Admin.Retry.Backoff = 0
admin, err := NewClusterAdmin([]string{seedBroker.Addr()}, config)
require.NoError(t, err)
defer func() { _ = admin.Close() }()
txAdmin := admin.(TransactionClusterAdmin)
result, err := txAdmin.DescribeTransactions([]string{txID})
// A terminal per-transaction code is carried through in the struct, not lifted
// to the aggregate error and not retried.
require.NoError(t, err)
require.Equal(t, ErrTransactionalIDAuthorizationFailed, result[txID].ErrorCode)
}
func TestClusterAdminDescribeTransactionsExhaustsRetries(t *testing.T) {
txID := "my-tx"
seedBroker := NewMockBroker(t, 1)
defer seedBroker.Close()
seedBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()),
"FindCoordinatorRequest": NewMockFindCoordinatorResponse(t).
SetCoordinator(CoordinatorTransaction, txID, seedBroker),
// The coordinator tags the transaction with a retriable code on every
// attempt, so refreshing and retrying never clears it.
"DescribeTransactionsRequest": NewMockDescribeTransactionsResponse(t).
SetError(txID, ErrNotCoordinatorForConsumer),
})
config := NewTestConfig()
config.Version = V3_0_0_0
config.Admin.Retry.Max = 2
config.Admin.Retry.Backoff = 0
admin, err := NewClusterAdmin([]string{seedBroker.Addr()}, config)
require.NoError(t, err)
defer func() { _ = admin.Close() }()
txAdmin := admin.(TransactionClusterAdmin)
result, err := txAdmin.DescribeTransactions([]string{txID})
// Retries are bounded: once exhausted the retriable code is surfaced as the
// aggregate error and the transaction is left out of the result.
require.Error(t, err)
require.ErrorIs(t, err, ErrNotCoordinatorForConsumer)
// The surfaced error is wrapped with the transactional ids the request covered,
// while %w keeps the underlying coordinator code matchable above.
require.ErrorContains(t, err, fmt.Sprintf("describe transactions for %s", txID))
_, present := result[txID]
require.False(t, present)
}
func TestClusterAdminDescribeTransactionsPartialResultOnRetryExhaustion(t *testing.T) {
okTx := "ok-tx"
badTx := "bad-tx"
seedBroker := NewMockBroker(t, 1)
secondBroker := NewMockBroker(t, 2)
defer seedBroker.Close()
defer secondBroker.Close()
metadata := NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()).
SetBroker(secondBroker.Addr(), secondBroker.BrokerID())
// ok-tx and bad-tx resolve to distinct coordinators, one goroutine each. bad-tx's
// coordinator tags it with a retriable code on every attempt, so that goroutine
// exhausts its describe retries and errors through the results channel while ok-tx
// succeeds.
findCoordinator := NewMockFindCoordinatorResponse(t).
SetCoordinator(CoordinatorTransaction, okTx, seedBroker).
SetCoordinator(CoordinatorTransaction, badTx, secondBroker)
seedBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": metadata,
"FindCoordinatorRequest": findCoordinator,
"DescribeTransactionsRequest": NewMockDescribeTransactionsResponse(t).
AddTransaction(okTx, TransactionState{TransactionState: TransactionStateOngoing}),
})
secondBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": metadata,
"FindCoordinatorRequest": findCoordinator,
"DescribeTransactionsRequest": NewMockDescribeTransactionsResponse(t).
SetError(badTx, ErrNotCoordinatorForConsumer),
})
config := NewTestConfig()
config.Version = V3_0_0_0
config.Admin.Retry.Max = 2
config.Admin.Retry.Backoff = 0
admin, err := NewClusterAdmin([]string{seedBroker.Addr()}, config)
require.NoError(t, err)
defer func() { _ = admin.Close() }()
txAdmin := admin.(TransactionClusterAdmin)
result, err := txAdmin.DescribeTransactions([]string{okTx, badTx})
// bad-tx's exhausted retriable code is surfaced as the aggregate error, wrapped
// with the transactional id its request covered.
require.Error(t, err)
require.ErrorIs(t, err, ErrNotCoordinatorForConsumer)
require.ErrorContains(t, err, fmt.Sprintf("describe transactions for %s", badTx))
// ok-tx's result survives alongside the error; bad-tx is absent from the map.
require.Equal(t, TransactionStateOngoing, result[okTx].TransactionState)
require.Equal(t, ErrNoError, result[okTx].ErrorCode)
_, present := result[badTx]
require.False(t, present)
}
func TestIsRetriableTransactionCoordinatorError(t *testing.T) {
// The full "coordinator dropped an established connection" path cannot be
// reproduced deterministically with MockBroker, so the io.EOF branch is
// pinned here at the predicate level; the retry machinery that consumes it is
// exercised by TestClusterAdminDescribeTransactionsRetriesOnRetriableCoordinatorError.
tests := []struct {
name string
err error
want bool
}{
{"coordinator not available", ErrConsumerCoordinatorNotAvailable, true},
{"not coordinator", ErrNotCoordinatorForConsumer, true},
{"coordinator load in progress", ErrOffsetsLoadInProgress, true},
{"dropped connection", io.EOF, true},
{"wrapped dropped connection", fmt.Errorf("reading response: %w", io.EOF), true},
{"terminal authorization error", ErrTransactionalIDAuthorizationFailed, false},
{"unrelated error", errors.New("boom"), false},
{"nil", nil, false},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
require.Equal(t, tt.want, isRetriableTransactionCoordinatorError(tt.err))
})
}
}
func TestClusterAdminListTransactions(t *testing.T) {
seedBroker := NewMockBroker(t, 1)
defer seedBroker.Close()
seedBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()),
"ListTransactionsRequest": NewMockListTransactionsResponse(t).
AddTransaction("tx-1", 100, TransactionStateOngoing),
})
config := NewTestConfig()
config.Version = V3_0_0_0
admin, err := NewClusterAdmin([]string{seedBroker.Addr()}, config)
require.NoError(t, err)
defer func() { _ = admin.Close() }()
txAdmin := admin.(TransactionClusterAdmin)
result, err := txAdmin.ListTransactions(nil, nil, -1)
require.NoError(t, err)
require.Len(t, result, 1)
require.Equal(t, "tx-1", result[0].TransactionalID)
require.Equal(t, int64(100), result[0].ProducerID)
require.Equal(t, TransactionStateOngoing, result[0].TransactionState)
}
func TestClusterAdminListTransactionsMultiBroker(t *testing.T) {
seedBroker := NewMockBroker(t, 1)
secondBroker := NewMockBroker(t, 2)
defer seedBroker.Close()
defer secondBroker.Close()
seedBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()).
SetBroker(secondBroker.Addr(), secondBroker.BrokerID()),
"ListTransactionsRequest": NewMockListTransactionsResponse(t).
AddTransaction("tx-1", 1, TransactionStateOngoing),
})
secondBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()).
SetBroker(secondBroker.Addr(), secondBroker.BrokerID()),
"ListTransactionsRequest": NewMockListTransactionsResponse(t).
AddTransaction("tx-2", 2, TransactionStateEmpty),
})
config := NewTestConfig()
config.Version = V3_0_0_0
admin, err := NewClusterAdmin([]string{seedBroker.Addr()}, config)
require.NoError(t, err)
defer func() { _ = admin.Close() }()
txAdmin := admin.(TransactionClusterAdmin)
result, err := txAdmin.ListTransactions(nil, nil, -1)
require.NoError(t, err)
require.Len(t, result, 2)
ids := map[string]bool{}
for _, s := range result {
ids[s.TransactionalID] = true
}
require.True(t, ids["tx-1"])
require.True(t, ids["tx-2"])
}
func TestClusterAdminListTransactionsUsesV1WithDurationFilter(t *testing.T) {
seedBroker := NewMockBroker(t, 1)
defer seedBroker.Close()
mock := NewMockListTransactionsResponse(t).AddTransaction("tx-1", 1, TransactionStateOngoing)
seedBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()),
"ListTransactionsRequest": mock,
})
config := NewTestConfig()
config.Version = V3_8_0_0
admin, err := NewClusterAdmin([]string{seedBroker.Addr()}, config)
require.NoError(t, err)
defer func() { _ = admin.Close() }()
txAdmin := admin.(TransactionClusterAdmin)
_, err = txAdmin.ListTransactions([]string{TransactionStateOngoing}, []int64{7}, 5000)
require.NoError(t, err)
req := mock.LastRequest()
require.Equal(t, int16(1), req.Version)
require.Equal(t, int64(5000), req.DurationFilter)
require.Equal(t, []string{TransactionStateOngoing}, req.StateFilters)
require.Equal(t, []int64{7}, req.ProducerIDFilters)
}
func TestClusterAdminListTransactionsUsesV0BelowV3_8(t *testing.T) {
seedBroker := NewMockBroker(t, 1)
defer seedBroker.Close()
mock := NewMockListTransactionsResponse(t)
seedBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()),
"ListTransactionsRequest": mock,
})
config := NewTestConfig()
config.Version = V3_0_0_0
admin, err := NewClusterAdmin([]string{seedBroker.Addr()}, config)
require.NoError(t, err)
defer func() { _ = admin.Close() }()
txAdmin := admin.(TransactionClusterAdmin)
// No duration filter is requested (disabled), so a v0 request is sent and the
// duration filter never reaches the wire.
_, err = txAdmin.ListTransactions(nil, nil, -1)
require.NoError(t, err)
req := mock.LastRequest()
require.Equal(t, int16(0), req.Version)
require.Equal(t, int64(-1), req.DurationFilter)
}
func TestClusterAdminListTransactionsRejectsDurationFilterBelowV3_8(t *testing.T) {
seedBroker := NewMockBroker(t, 1)
defer seedBroker.Close()
seedBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()),
})
config := NewTestConfig()
config.Version = V3_0_0_0
admin, err := NewClusterAdmin([]string{seedBroker.Addr()}, config)
require.NoError(t, err)
defer func() { _ = admin.Close() }()
txAdmin := admin.(TransactionClusterAdmin)
// A real duration filter needs ListTransactions v1 (Kafka 3.8.0.0+); below
// that it must be rejected rather than silently ignored.
result, err := txAdmin.ListTransactions(nil, nil, 5000)
require.Nil(t, result)
var configErr ConfigurationError
require.ErrorAs(t, err, &configErr)
}
func TestClusterAdminListTransactionsPartialFailure(t *testing.T) {
seedBroker := NewMockBroker(t, 1)
secondBroker := NewMockBroker(t, 2)
defer seedBroker.Close()
defer secondBroker.Close()
seedBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()).
SetBroker(secondBroker.Addr(), secondBroker.BrokerID()),
"ListTransactionsRequest": NewMockListTransactionsResponse(t).
AddTransaction("tx-1", 1, TransactionStateOngoing),
})
secondBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()).
SetBroker(secondBroker.Addr(), secondBroker.BrokerID()),
"ListTransactionsRequest": NewMockListTransactionsResponse(t).
SetError(ErrClusterAuthorizationFailed),
})
config := NewTestConfig()
config.Version = V3_0_0_0
admin, err := NewClusterAdmin([]string{seedBroker.Addr()}, config)
require.NoError(t, err)
defer func() { _ = admin.Close() }()
txAdmin := admin.(TransactionClusterAdmin)
result, err := txAdmin.ListTransactions(nil, nil, -1)
require.Error(t, err)
// The failing broker's error is wrapped with its address, while %w keeps the
// underlying code matchable.
require.ErrorIs(t, err, ErrClusterAuthorizationFailed)
require.ErrorContains(t, err, fmt.Sprintf("list transactions on broker %s", secondBroker.Addr()))
require.Len(t, result, 1)
require.Equal(t, "tx-1", result[0].TransactionalID)
}
func TestClusterAdminListTransactionsSurfacesTopLevelError(t *testing.T) {
seedBroker := NewMockBroker(t, 1)
defer seedBroker.Close()
seedBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()),
"ListTransactionsRequest": NewMockListTransactionsResponse(t).
SetError(ErrClusterAuthorizationFailed),
})
config := NewTestConfig()
config.Version = V3_0_0_0
admin, err := NewClusterAdmin([]string{seedBroker.Addr()}, config)
require.NoError(t, err)
defer func() { _ = admin.Close() }()
txAdmin := admin.(TransactionClusterAdmin)
result, err := txAdmin.ListTransactions(nil, nil, -1)
require.Error(t, err)
require.ErrorIs(t, err, ErrClusterAuthorizationFailed)
require.ErrorContains(t, err, fmt.Sprintf("list transactions on broker %s", seedBroker.Addr()))
require.Empty(t, result)
}
func TestClusterAdminImplementsTransactionClusterAdmin(t *testing.T) {
seedBroker := NewMockBroker(t, 1)
defer seedBroker.Close()
seedBroker.SetHandlerByMap(map[string]MockResponse{
"MetadataRequest": NewMockMetadataResponse(t).
SetController(seedBroker.BrokerID()).
SetBroker(seedBroker.Addr(), seedBroker.BrokerID()),
})
config := NewTestConfig()
config.Version = V3_0_0_0
admin, err := NewClusterAdmin([]string{seedBroker.Addr()}, config)
require.NoError(t, err)
defer func() { _ = admin.Close() }()
_, ok := admin.(TransactionClusterAdmin)
require.True(t, ok, "NewClusterAdmin result should implement TransactionClusterAdmin")
}