Include *.trc files in site-packages (non-editable) installation (#642)

* Add check to test site-packages (non-editable) installation of IDAES

* Fix pytest CLI flag

* Remove failing timing-based test

* Include *.trc files in site-packages (non-editable) installation

* Move site-packages pytest job to integration workflow

* Enable color output for pytest

* Limit tests to run for debugging

* Try to see if failures are due to using more recent version of Ubuntu

* Restore normal job conditions

* Also install optional dependencies

Author: lbianchi-lbl

.github/workflows/integration.yml

@@ -26,6 +26,7 @@ on:
 
 env:
   IDAES_CONDA_ENV_NAME_DEV: idaes-pse-dev
+  PYTEST_ADDOPTS: "--color=yes"
 
 defaults:
   run:
@@ -193,3 +194,35 @@ jobs:
         working-directory: ${{ runner.temp }}
         run: |
           cat *errors.txt || echo "No error logs found"
+
+  pytest-site-packages:
+    name: Run tests from site-packages (non-editable) installation
+    # NOTE: using ubuntu-latest (20.04) instead of 18.04 results in failures in power_generation/carbon_capture/mea_solvent_system/unit_models/tests/test_column.py
+    runs-on: ubuntu-18.04
+    needs: [precheck]
+    if: >-
+      (
+        needs.precheck.outputs.workflow-trigger == 'user_dispatch'
+        || needs.precheck.outputs.workflow-trigger == 'not_pr'
+        || needs.precheck.outputs.workflow-trigger == 'approved_pr'
+      )
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Conda environment
+        uses: conda-incubator/[email protected]
+        with:
+          activate-environment: idaes-env
+          python-version: '3.8'
+      - name: Set up idaes (non-editable installation)
+        uses: ./.github/actions/setup-idaes
+        with:
+          install-target: '.[optional]'
+      - name: Install test dependencies and run pytest in empty directory
+        run: |
+          pushd "$(mktemp -d)"
+          # TODO this could be an optional [testing] dependency
+          pip install pytest addheader
+          # TODO downloading pytest.ini is still needed for the tests to pass
+          # eventually it will be moved to the root conftest.py so that is installed as Python code
+          wget https://raw.githubusercontent.com/IDAES/idaes-pse/main/pytest.ini 
+          pytest --pyargs idaes

idaes/dmf/tests/test_getver.py

@@ -89,19 +89,3 @@ def test_bad_import(garbage):
 def test_bad_pip(make_pip_garbage):
     ver = getver.Versioned("traitlets")
     assert ver is not None
-
-
-@pytest.mark.unit
-def test_repeated_calls():
-    import time
-
-    t0 = time.time()
-    vv = getver.Versioned("idaes")
-    i1 = vv.get_info()
-    t1 = time.time()
-    for i in range(20):
-        i2 = vv.get_info()
-        assert i2 == i1
-    t2 = time.time()
-    # time to get 1st should be much, much longer than subsequent
-    assert t2 - t1 < t1 - t0

setup.py

@@ -103,6 +103,7 @@ def rglob(path, glob):
             "*.json.gz",
             "*.dat",
             "*.h5",
+            "*.trc",
         ]
     },
     include_package_data=True,