Merge pull request #1206 from IETS3/bugfix/code_completion_menus

Author: Alexander Pann

CHANGELOG.md

@@ -5,6 +5,13 @@ All notable changes to this project are documented in this file.
 Format of the log is _loosely_ based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 The project does _not_ follow Semantic Versioning and the changes are documented in reverse chronological order, grouped by calendar month.
 
+## Feburary 2025
+
+### Fixed
+
+- Strings are not comparable with strings with constraints.
+- The usability of editors (code completion menu, color) was improved.
+
 ## January 2025
 
 ### Added

code/languages/org.iets3.opensource/languages/org.iets3.components.core/models/editor.mps

@@ -1157,6 +1157,7 @@
     <property role="TrG5h" value="PortTypeSpecificPortType" />
     <property role="EcuMT" value="2244552513307947405" />
     <property role="R4oN_" value="a port type of a specific port type" />
+    <property role="34LRSv" value="port" />
     <ref role="1TJDcQ" to="hm2y:6sdnDbSlaok" resolve="Type" />
     <node concept="1TJgyj" id="1WAg9Tzrz6g" role="1TKVEi">
       <property role="20lmBu" value="fLJjDmT/aggregation" />

code/languages/org.iets3.opensource/languages/org.iets3.components.core/models/structure.mps

@@ -10,6 +10,7 @@
     <import index="330h" ref="r:23d7e401-548b-485c-bdf1-c060e259073c(org.iets3.core.assessment.structure)" />
     <import index="tpck" ref="r:00000000-0000-4000-0000-011c89590288(jetbrains.mps.lang.core.structure)" />
     <import index="tpcu" ref="r:00000000-0000-4000-0000-011c89590282(jetbrains.mps.lang.core.behavior)" implicit="true" />
+    <import index="vs0r" ref="r:f7764ca4-8c75-4049-922b-08516400a727(com.mbeddr.core.base.structure)" implicit="true" />
   </imports>
   <registry>
     <language id="18bc6592-03a6-4e29-a83a-7ff23bde13ba" name="jetbrains.mps.lang.editor">
@@ -25,6 +26,12 @@
       <concept id="1080736578640" name="jetbrains.mps.lang.editor.structure.BaseEditorComponent" flags="ig" index="2wURMF">
         <child id="1080736633877" name="cellModel" index="2wV5jI" />
       </concept>
+      <concept id="1164824717996" name="jetbrains.mps.lang.editor.structure.CellMenuDescriptor" flags="ng" index="OXEIz">
+        <child id="1164824815888" name="cellMenuPart" index="OY2wv" />
+      </concept>
+      <concept id="1164914519156" name="jetbrains.mps.lang.editor.structure.CellMenuPart_ReplaceNode_CustomNodeConcept" flags="ng" index="UkePV">
+        <reference id="1164914727930" name="replacementConcept" index="Ul1FP" />
+      </concept>
       <concept id="1186403694788" name="jetbrains.mps.lang.editor.structure.ColorStyleClassItem" flags="ln" index="VaVBg">
         <property id="1186403713874" name="color" index="Vb096" />
       </concept>
@@ -39,9 +46,13 @@
       </concept>
       <concept id="1088185857835" name="jetbrains.mps.lang.editor.structure.InlineEditorComponent" flags="ig" index="1sVBvm" />
       <concept id="1139848536355" name="jetbrains.mps.lang.editor.structure.CellModel_WithRole" flags="ng" index="1$h60E">
+        <property id="1139852716018" name="noTargetText" index="1$x2rV" />
         <property id="1140017977771" name="readOnly" index="1Intyy" />
         <reference id="1140103550593" name="relationDeclaration" index="1NtTu8" />
       </concept>
+      <concept id="1073389214265" name="jetbrains.mps.lang.editor.structure.EditorCellModel" flags="ng" index="3EYTF0">
+        <child id="1164826688380" name="menuDescriptor" index="P5bDN" />
+      </concept>
       <concept id="1073389446423" name="jetbrains.mps.lang.editor.structure.CellModel_Collection" flags="sn" stub="3013115976261988961" index="3EZMnI">
         <child id="1106270802874" name="cellLayout" index="2iSdaV" />
         <child id="1073389446424" name="childCellModel" index="3EZMnx" />
@@ -282,25 +293,22 @@
     <node concept="3EZMnI" id="5ZLQMNq2l6w" role="2wV5jI">
       <node concept="3F0ifn" id="5ZLQMNq2l6B" role="3EZMnx">
         <property role="3F0ifm" value="generic trace query" />
+        <node concept="OXEIz" id="4MeRni499VS" role="P5bDN">
+          <node concept="UkePV" id="4MeRni499VT" role="OY2wv">
+            <ref role="Ul1FP" to="vs0r:K292flwD4r" resolve="AssessmentQuery" />
+          </node>
+        </node>
       </node>
       <node concept="3F0ifn" id="5ZLQMNq2l6V" role="3EZMnx">
-        <property role="3F0ifm" value="kind&lt;" />
-        <node concept="11LMrY" id="5ZLQMNq7BlE" role="3F10Kt">
-          <property role="VOm3f" value="true" />
-        </node>
+        <property role="3F0ifm" value="of kind" />
       </node>
       <node concept="3F1sOY" id="5ZLQMNq2l7d" role="3EZMnx">
+        <property role="1$x2rV" value="no kind" />
         <ref role="1NtTu8" to="330h:5ZLQMNq2hPP" resolve="traceKind" />
         <node concept="VechU" id="1SeAacxoe9D" role="3F10Kt">
           <property role="Vb096" value="g1_qRwE/darkGreen" />
         </node>
       </node>
-      <node concept="3F0ifn" id="5ZLQMNq2l7p" role="3EZMnx">
-        <property role="3F0ifm" value="&gt;" />
-        <node concept="11L4FC" id="5ZLQMNq7BpT" role="3F10Kt">
-          <property role="VOm3f" value="true" />
-        </node>
-      </node>
       <node concept="3F0ifn" id="5ZLQMNq2l7B" role="3EZMnx">
         <property role="3F0ifm" value="from:" />
       </node>
@@ -364,6 +372,11 @@
     <node concept="3EZMnI" id="378sigX35m1" role="2wV5jI">
       <node concept="3F0ifn" id="378sigX35ma" role="3EZMnx">
         <property role="3F0ifm" value="elements like" />
+        <node concept="OXEIz" id="4MeRni45Kdq" role="P5bDN">
+          <node concept="UkePV" id="4MeRni45Kfs" role="OY2wv">
+            <ref role="Ul1FP" to="vs0r:K292flwD4r" resolve="AssessmentQuery" />
+          </node>
+        </node>
       </node>
       <node concept="1iCGBv" id="378sigX4UXW" role="3EZMnx">
         <ref role="1NtTu8" to="330h:378sigX35lt" resolve="like" />

code/languages/org.iets3.opensource/languages/org.iets3.core.assessment/models/editor.mps

@@ -76,6 +76,7 @@
     <property role="EcuMT" value="6913547888673489335" />
     <property role="TrG5h" value="GenericTraceQuery" />
     <property role="R4oN_" value="a generic trace query" />
+    <property role="34LRSv" value="generic trace query" />
     <ref role="1TJDcQ" to="vs0r:K292flwD4r" resolve="AssessmentQuery" />
     <node concept="1TJgyj" id="5ZLQMNq2hPS" role="1TKVEi">
       <property role="IQ2ns" value="6913547888673496440" />

code/languages/org.iets3.opensource/languages/org.iets3.core.assessment/models/structure.mps

@@ -10,6 +10,7 @@
     <use id="fd392034-7849-419d-9071-12563d152375" name="jetbrains.mps.baseLanguage.closures" version="-1" />
     <use id="9d69e719-78c8-4286-90db-fb19c107d049" name="com.mbeddr.mpsutil.grammarcells" version="2" />
     <use id="b1ab8c10-c118-4755-bf2a-cebab35cf533" name="jetbrains.mps.lang.editor.tooltips" version="0" />
+    <use id="1919c723-b60b-4592-9318-9ce96d91da44" name="de.itemis.mps.editor.celllayout" version="0" />
     <devkit ref="2677cb18-f558-4e33-bc38-a5139cee06dc(jetbrains.mps.devkit.language-design)" />
   </languages>
   <imports>
@@ -41,9 +42,6 @@
         <child id="1140524464359" name="emptyCellModel" index="2czzBI" />
         <child id="6046489571270834038" name="foldedCellModel" index="3EmGlc" />
       </concept>
-      <concept id="1078308402140" name="jetbrains.mps.lang.editor.structure.CellModel_Custom" flags="sg" stub="8104358048506730068" index="gc7cB">
-        <child id="1176795024817" name="cellProvider" index="3YsKMw" />
-      </concept>
       <concept id="1106270571710" name="jetbrains.mps.lang.editor.structure.CellLayout_Vertical" flags="nn" index="2iRkQZ" />
       <concept id="1237303669825" name="jetbrains.mps.lang.editor.structure.CellLayout_Indent" flags="nn" index="l2Vlx" />
       <concept id="1237307900041" name="jetbrains.mps.lang.editor.structure.IndentLayoutIndentStyleClassItem" flags="ln" index="lj46D" />
@@ -63,6 +61,9 @@
       <concept id="1078939183254" name="jetbrains.mps.lang.editor.structure.CellModel_Component" flags="sg" stub="3162947552742194261" index="PMmxH">
         <reference id="1078939183255" name="editorComponent" index="PMmxG" />
       </concept>
+      <concept id="1164914519156" name="jetbrains.mps.lang.editor.structure.CellMenuPart_ReplaceNode_CustomNodeConcept" flags="ng" index="UkePV">
+        <reference id="1164914727930" name="replacementConcept" index="Ul1FP" />
+      </concept>
       <concept id="1186403694788" name="jetbrains.mps.lang.editor.structure.ColorStyleClassItem" flags="ln" index="VaVBg">
         <property id="1186403713874" name="color" index="Vb096" />
         <child id="1186403803051" name="query" index="VblUZ" />
@@ -110,6 +111,7 @@
       </concept>
       <concept id="1073389214265" name="jetbrains.mps.lang.editor.structure.EditorCellModel" flags="ng" index="3EYTF0">
         <child id="1142887637401" name="renderingCondition" index="pqm2j" />
+        <child id="1164826688380" name="menuDescriptor" index="P5bDN" />
         <child id="4202667662392416064" name="transformationMenu" index="3vIgyS" />
       </concept>
       <concept id="1073389446423" name="jetbrains.mps.lang.editor.structure.CellModel_Collection" flags="sn" stub="3013115976261988961" index="3EZMnI">
@@ -136,7 +138,6 @@
         <child id="1225900141900" name="modelAccessor" index="1HlULh" />
       </concept>
       <concept id="1176717841777" name="jetbrains.mps.lang.editor.structure.QueryFunction_ModelAccess_Getter" flags="in" index="3TQlhw" />
-      <concept id="1176749715029" name="jetbrains.mps.lang.editor.structure.QueryFunction_CellProvider" flags="in" index="3VJUX4" />
       <concept id="1166049232041" name="jetbrains.mps.lang.editor.structure.AbstractComponent" flags="ng" index="1XWOmA">
         <reference id="1166049300910" name="conceptDeclaration" index="1XX52x" />
       </concept>
@@ -162,9 +163,6 @@
       <concept id="1081236700937" name="jetbrains.mps.baseLanguage.structure.StaticMethodCall" flags="nn" index="2YIFZM">
         <reference id="1144433194310" name="classConcept" index="1Pybhc" />
       </concept>
-      <concept id="1070533707846" name="jetbrains.mps.baseLanguage.structure.StaticFieldReference" flags="nn" index="10M0yZ">
-        <reference id="1144433057691" name="classifier" index="1PxDUh" />
-      </concept>
       <concept id="1070534058343" name="jetbrains.mps.baseLanguage.structure.NullLiteral" flags="nn" index="10Nm6u" />
       <concept id="1068498886296" name="jetbrains.mps.baseLanguage.structure.VariableReference" flags="nn" index="37vLTw">
         <reference id="1068581517664" name="variableDeclaration" index="3cqZAo" />
@@ -186,7 +184,6 @@
         <reference id="1068499141037" name="baseMethodDeclaration" index="37wK5l" />
         <child id="1068499141038" name="actualArgument" index="37wK5m" />
       </concept>
-      <concept id="1212685548494" name="jetbrains.mps.baseLanguage.structure.ClassCreator" flags="nn" index="1pGfFk" />
       <concept id="1081773326031" name="jetbrains.mps.baseLanguage.structure.BinaryOperation" flags="nn" index="3uHJSO">
         <child id="1081773367579" name="rightExpression" index="3uHU7w" />
         <child id="1081773367580" name="leftExpression" index="3uHU7B" />
@@ -220,6 +217,10 @@
       </concept>
       <concept id="6349233906483558394" name="com.mbeddr.mpsutil.grammarcells.structure.Parameter_wrappedConcept" flags="ng" index="1ZN7lz" />
     </language>
+    <language id="1919c723-b60b-4592-9318-9ce96d91da44" name="de.itemis.mps.editor.celllayout">
+      <concept id="4682418030828844315" name="de.itemis.mps.editor.celllayout.structure.HorizontalLineColorStyle" flags="lg" index="2T_bXS" />
+      <concept id="4682418030828725523" name="de.itemis.mps.editor.celllayout.structure.HorizontalLineCell" flags="ng" index="2T_mXK" />
+    </language>
     <language id="120e1c9d-4e27-4478-b2af-b2c3bd3850b0" name="com.mbeddr.mpsutil.editor.querylist">
       <concept id="6202678563380238499" name="com.mbeddr.mpsutil.editor.querylist.structure.Function_GetElements" flags="ig" index="s8sZD" />
       <concept id="6202678563380233810" name="com.mbeddr.mpsutil.editor.querylist.structure.CellModel_QueryList" flags="ng" index="s8t4o">
@@ -303,25 +304,12 @@
       <node concept="3F0ifn" id="3NBP8_OgMYn" role="3EZMnx">
         <property role="3F0ifm" value="Attributes" />
       </node>
-      <node concept="2iRkQZ" id="3NBP8_OgMYj" role="2iSdaV" />
-      <node concept="gc7cB" id="3NBP8_OgMYx" role="3EZMnx">
-        <node concept="3VJUX4" id="3NBP8_OgMYz" role="3YsKMw">
-          <node concept="3clFbS" id="3NBP8_OgMY_" role="2VODD2">
-            <node concept="3clFbF" id="3NBP8_OgMZ5" role="3cqZAp">
-              <node concept="2ShNRf" id="3NBP8_OgMZ3" role="3clFbG">
-                <node concept="1pGfFk" id="3NBP8_OgZP2" role="2ShVmc">
-                  <ref role="37wK5l" to="r4b4:5gTlpakv6nY" resolve="HorizLineCell" />
-                  <node concept="pncrf" id="3NBP8_OgZPG" role="37wK5m" />
-                  <node concept="10M0yZ" id="38mO9wfTp0_" role="37wK5m">
-                    <ref role="3cqZAo" to="lzb2:~JBColor.gray" resolve="gray" />
-                    <ref role="1PxDUh" to="lzb2:~JBColor" resolve="JBColor" />
-                  </node>
-                </node>
-              </node>
-            </node>
-          </node>
+      <node concept="2T_mXK" id="1znK7yYSqZq" role="3EZMnx">
+        <node concept="2T_bXS" id="1znK7yYSrhg" role="3F10Kt">
+          <property role="Vb096" value="fLJRk5_/gray" />
         </node>
       </node>
+      <node concept="2iRkQZ" id="3NBP8_OgMYj" role="2iSdaV" />
       <node concept="3F2HdR" id="3NBP8_Oh0ap" role="3EZMnx">
         <ref role="1NtTu8" to="138:3NBP8_OgMVe" resolve="attributes" />
         <node concept="4$FPG" id="4fgA7QrG5RE" role="4_6I_">
@@ -339,22 +327,9 @@
         </node>
         <node concept="2EHx9g" id="1HqphBIQEz$" role="2czzBx" />
       </node>
-      <node concept="gc7cB" id="3NBP8_Ohq9D" role="3EZMnx">
-        <node concept="3VJUX4" id="3NBP8_Ohq9E" role="3YsKMw">
-          <node concept="3clFbS" id="3NBP8_Ohq9F" role="2VODD2">
-            <node concept="3clFbF" id="3NBP8_Ohq9G" role="3cqZAp">
-              <node concept="2ShNRf" id="3NBP8_Ohq9H" role="3clFbG">
-                <node concept="1pGfFk" id="3NBP8_Ohq9I" role="2ShVmc">
-                  <ref role="37wK5l" to="r4b4:5gTlpakv6nY" resolve="HorizLineCell" />
-                  <node concept="pncrf" id="3NBP8_Ohq9J" role="37wK5m" />
-                  <node concept="10M0yZ" id="38mO9wfTpb6" role="37wK5m">
-                    <ref role="3cqZAo" to="lzb2:~JBColor.gray" resolve="gray" />
-                    <ref role="1PxDUh" to="lzb2:~JBColor" resolve="JBColor" />
-                  </node>
-                </node>
-              </node>
-            </node>
-          </node>
+      <node concept="2T_mXK" id="1znK7yYSrx7" role="3EZMnx">
+        <node concept="2T_bXS" id="1znK7yYSrx8" role="3F10Kt">
+          <property role="Vb096" value="fLJRk5_/gray" />
         </node>
       </node>
     </node>
@@ -930,6 +905,11 @@
     <node concept="3EZMnI" id="43MQ47XI4aZ" role="2wV5jI">
       <node concept="PMmxH" id="43MQ47XI4bc" role="3EZMnx">
         <ref role="PMmxG" to="tpco:2wZex4PafBj" resolve="alias" />
+        <node concept="OXEIz" id="1znK7yYStfN" role="P5bDN">
+          <node concept="UkePV" id="1znK7yYSthP" role="OY2wv">
+            <ref role="Ul1FP" to="138:3NBP8_OgMyV" resolve="IAttribute" />
+          </node>
+        </node>
       </node>
       <node concept="3F0ifn" id="43MQ47XI4bn" role="3EZMnx">
         <property role="3F0ifm" value=":" />

code/languages/org.iets3.opensource/languages/org.iets3.core.attributes/models/editor.mps

@@ -24,6 +24,7 @@
     <language slang="l:120e1c9d-4e27-4478-b2af-b2c3bd3850b0:com.mbeddr.mpsutil.editor.querylist" version="0" />
     <language slang="l:9d69e719-78c8-4286-90db-fb19c107d049:com.mbeddr.mpsutil.grammarcells" version="2" />
     <language slang="l:b4f35ed8-45af-4efa-abe4-00ac26956e69:com.mbeddr.mpsutil.grammarcells.runtimelang" version="0" />
+    <language slang="l:1919c723-b60b-4592-9318-9ce96d91da44:de.itemis.mps.editor.celllayout" version="0" />
     <language slang="l:f3061a53-9226-4cc5-a443-f952ceaf5816:jetbrains.mps.baseLanguage" version="12" />
     <language slang="l:443f4c36-fcf5-4eb6-9500-8d06ed259e3e:jetbrains.mps.baseLanguage.classifiers" version="0" />
     <language slang="l:fd392034-7849-419d-9071-12563d152375:jetbrains.mps.baseLanguage.closures" version="0" />

code/languages/org.iets3.opensource/languages/org.iets3.core.attributes/org.iets3.core.attributes.mpl

@@ -1389,5 +1389,9 @@
     <ref role="aqKnT" to="4kwy:7z6TQkzL3oZ" resolve="OriginalNodeInfo" />
     <node concept="22hDWj" id="7z6TQkzL3p3" role="22hAXT" />
   </node>
+  <node concept="22mcaB" id="1znK7yYSSFq">
+    <ref role="aqKnT" to="4kwy:cJpacq408a" resolve="OptionalNameSpecifier" />
+    <node concept="22hDWj" id="1znK7yYSSJt" role="22hAXT" />
+  </node>
 </model>