Skip to content

Commit 28436f1

Browse files
build: remove jarNameOverride, specify dependency type
Explicitly specifying the type of the takari-cpsuite dependency makes it unnecessary to override its jar name.
1 parent 9b6473f commit 28436f1

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

build.gradle

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -134,24 +134,19 @@ class BundledDep {
134134
String libSolutionName
135135
Closure configClosure = { transitive = false }
136136
// in case a legacy dependency has a broken artifact name, e.g. w/o extension
137-
String jarNameOverride
138137
String getConfigName() {
139138
name + '_bundled'
140139
}
141140
String getResolveTaskName() {
142141
'resolve_' + this.configName
143142
}
144-
BundledDep overrideArtifactName(String artifactName) {
145-
this.jarNameOverride = artifactName
146-
this
147-
}
148143
}
149144

150145
def bundledDeps = [
151146
new BundledDep('pcollections', ['org.pcollections:pcollections:4.0.2'], 'org.iets3.core.expr.base.collections.stubs'),
152147
new BundledDep('bigMath', ['ch.obermuhlner:big-math:2.3.2'], 'org.iets3.core.expr.math.interpreter'),
153148
new BundledDep('functionalJava', ['org.functionaljava:functionaljava:5.0'], 'org.iets3.core.expr.genjava.functionalJava'),
154-
new BundledDep('cpsSuite', ['io.takari.junit:takari-cpsuite:1.2.7'], 'org.iets3.opensource.build.gentests.rt').overrideArtifactName('takari-cpsuite.jar')
149+
new BundledDep('cpsSuite', ['io.takari.junit:takari-cpsuite:1.2.7@jar'], 'org.iets3.opensource.build.gentests.rt')
155150
]
156151

157152
bundledDeps.each { dep ->
@@ -171,9 +166,7 @@ bundledDeps.each { dep ->
171166
rename { filename ->
172167
def ra = configurations.getByName(dep.configName).resolvedConfiguration.resolvedArtifacts.find { ResolvedArtifact ra -> ra.file.name == filename }
173168
String finalName
174-
if (dep.jarNameOverride != null) {
175-
finalName = dep.jarNameOverride
176-
} else if (ra.classifier != null) {
169+
if (ra.classifier != null) {
177170
finalName = "${ra.name}-${ra.classifier}.${ra.extension}"
178171
} else {
179172
finalName = "${ra.name}.${ra.extension}"

0 commit comments

Comments
 (0)