From f8083acb942d63c14cb6fc5d71b42c54c56049fc Mon Sep 17 00:00:00 2001 From: Torsten Goerg Date: Thu, 18 Dec 2025 04:25:45 +0100 Subject: [PATCH 1/2] Improve handling of root constraints in conjunction with grouping (#1552). Details: - Editor improvements for feature model root constraints. - Added repositioning of feature model root constraints on constraint group assignment changes. - Improved the the root constraints editor according to the review comments. - Updated CHANGELOG.md. --- CHANGELOG.md | 2 + ...3.variability.featuremodel.base.editor.mps | 1148 ++++++++++------- ...riability.featuremodel.base.intentions.mps | 758 +++++++++++ ...rg.iets3.variability.featuremodel.base.mpl | 2 + .../org/iets3/opensource/build/build.mps | 5 + 5 files changed, 1432 insertions(+), 483 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7095f34d1d..1a4ebe51b9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,6 +19,8 @@ The project does _not_ follow Semantic Versioning and the changes are documented - Variability: Remove deprecated concepts `VariabilityModelChunk_old`, and some related concepts. - Typesystem: All usages of colon casts were transformed to the 'as' cast for null safety. From now on no colon casts are allowed in the typesystem, also read this issue for more info: https://github.com/IETS3/iets3.opensource/issues/688 +- Variability: The grouping of root constraints has been improved. New root constraints will be added next to the other constraints in the respective groups. This helps to avoid merge conflicts. + ## November 2025 diff --git a/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps b/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps index 01d467ffd0..8e83e43ff2 100644 --- a/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps +++ b/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps @@ -59,6 +59,7 @@ + @@ -963,37 +964,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - @@ -1209,243 +1179,239 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - + + + + + + + + - - - - - - - - + + + + + + + + - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + - - - - + + + + - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + - - - + + + - - - - - - - - - - + + + + + + + + + + @@ -1453,92 +1419,92 @@ - - - + + + - - - - - - - - + + + + + + + + - - - - - - - - - - - - - + + + + + + + - - - - - - - - - - - - - - + + + + + - - - - - - + + + + + - - - + + + + + - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - + - @@ -1546,33 +1512,33 @@ - - - - - - - - - - - + + + + + + + + + + + - - - - - - - - - - - - + + + + + + + + + + + + @@ -1582,41 +1548,41 @@ - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - - - + + + + + + + + + + @@ -1624,92 +1590,92 @@ - - - - - - - - - - - + + + + + + + + + + + + + + - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + - - - - - - - - - - - - - - - + + + + + + + + + + - - - - - - - - - - - - - - - - - - - + + + + - - - - + + + + + + + + + - - + + - - - + + + + + - - + + + + + + + + + + @@ -1724,50 +1690,50 @@ - - - - - - - - - - + + + + + + + + + + - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + - - + + - - - + - - - - - + + + + @@ -1775,42 +1741,73 @@ - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + - - + + - - - + - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + @@ -11753,7 +11750,97 @@ - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + @@ -12753,5 +12840,100 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.intentions.mps b/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.intentions.mps index a63164b430..d063d5b8ca 100644 --- a/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.intentions.mps +++ b/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.intentions.mps @@ -67,6 +67,8 @@ + + @@ -310,6 +312,7 @@ + @@ -320,6 +323,9 @@ + + + @@ -331,6 +337,9 @@ + + + @@ -347,7 +356,9 @@ + + @@ -386,6 +397,7 @@ + @@ -489,6 +501,7 @@ + @@ -6358,6 +6371,22 @@ + + + + + + + + + + + + + + + + @@ -6371,6 +6400,62 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + @@ -6455,6 +6540,23 @@ + + + + + + + + + + + + + + + + + @@ -6498,6 +6600,662 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/org.iets3.variability.featuremodel.base.mpl b/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/org.iets3.variability.featuremodel.base.mpl index 06ae68f2c2..90fead4ffb 100644 --- a/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/org.iets3.variability.featuremodel.base.mpl +++ b/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/org.iets3.variability.featuremodel.base.mpl @@ -40,6 +40,7 @@ 8e98f4e2-decf-4e97-bf80-9109e8b759ee(jetbrains.mps.lang.constraints.rules.runtime) 9b66c5c9-38bf-4315-a96f-9f4e212c69cb(org.iets3.variability.base) 71226ee2-bbc4-45d2-a41d-20b97237156c(org.iets3.variability.configuration.base) + 6fd1293f-7f65-4ffd-99dc-4719eca7c171(jetbrains.mps.ide.vcs.platform) @@ -152,6 +153,7 @@ + diff --git a/code/languages/org.iets3.opensource/solutions/org.iets3.opensource.build/models/org/iets3/opensource/build/build.mps b/code/languages/org.iets3.opensource/solutions/org.iets3.opensource.build/models/org/iets3/opensource/build/build.mps index 478ef5584f..6a12da4247 100644 --- a/code/languages/org.iets3.opensource/solutions/org.iets3.opensource.build/models/org/iets3/opensource/build/build.mps +++ b/code/languages/org.iets3.opensource/solutions/org.iets3.opensource.build/models/org/iets3/opensource/build/build.mps @@ -2336,6 +2336,11 @@ + + + + + From 7c13fe45aa4d7598309905bd410ddb441cec8544 Mon Sep 17 00:00:00 2001 From: Torsten Goerg Date: Thu, 18 Dec 2025 15:23:36 +0100 Subject: [PATCH 2/2] #1552: Executed 'Force Save All' within MPS. --- ...3.variability.featuremodel.base.editor.mps | 36 +++++++++---------- ...riability.featuremodel.base.intentions.mps | 12 +++---- 2 files changed, 24 insertions(+), 24 deletions(-) diff --git a/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps b/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps index 8e83e43ff2..3a522a8bae 100644 --- a/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps +++ b/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps @@ -1253,7 +1253,7 @@ - + @@ -1281,7 +1281,7 @@ - + @@ -1299,7 +1299,7 @@ - + @@ -1485,7 +1485,7 @@ - + @@ -1500,7 +1500,7 @@ - + @@ -1698,7 +1698,7 @@ - + @@ -1719,11 +1719,11 @@ - + - + @@ -1744,7 +1744,7 @@ - + @@ -1761,11 +1761,11 @@ - + - + @@ -1797,7 +1797,7 @@ - + @@ -11762,11 +11762,11 @@ - + - + @@ -11819,11 +11819,11 @@ - + - + @@ -12859,7 +12859,7 @@ - + @@ -12924,7 +12924,7 @@ - + diff --git a/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.intentions.mps b/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.intentions.mps index d063d5b8ca..45f177660b 100644 --- a/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.intentions.mps +++ b/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.intentions.mps @@ -7102,7 +7102,7 @@ - + @@ -7157,7 +7157,7 @@ - + @@ -7182,7 +7182,7 @@ - + @@ -7218,14 +7218,14 @@ - + - + @@ -7245,7 +7245,7 @@ - +