removed redundant function

Author: vineetbansal

imap_processing/lo/l1c/lo_l1c.py

@@ -23,6 +23,7 @@
     frame_transform_az_el,
     get_spacecraft_to_instrument_spin_phase_offset,
     lo_instrument_pointing,
+    spherical_to_cartesian,
 )
 from imap_processing.spice.repoint import get_pointing_times
 from imap_processing.spice.spin import get_spin_data, get_spin_number
@@ -1262,36 +1263,13 @@ def create_ra_dec(
     ecl_lats : list of float
         Ecliptic latitude (degrees) for each of the 60 bin centers.
     """
-
-    def radec2cart(ra: float, colatitude_deg: float) -> np.ndarray:
-        """
-        Convert right ascension and colatitude to a Cartesian unit vector.
-
-        Parameters
-        ----------
-        ra : float
-            Right ascension in degrees.
-        colatitude_deg : float
-            Colatitude (90° − latitude) in degrees.
-
-        Returns
-        -------
-        np.ndarray
-            3-element unit vector [x, y, z].
-        """
-        x = np.cos(np.radians(ra)) * np.sin(np.radians(colatitude_deg))
-        y = np.sin(np.radians(ra)) * np.sin(np.radians(colatitude_deg))
-        z = np.cos(np.radians(colatitude_deg))
-
-        return np.array([x, y, z])
-
-    spin_colatitude_deg = 90.0 - spin_ecl_lat
-
     pivot_angle_rad = np.radians(pivot_angle)
 
     # In ECLIPJ2000 the NEP is [0, 0, 1].
     nep_unit = np.array([0.0, 0.0, 1.0])
-    spin_axis_unit = radec2cart(spin_ecl_lon, spin_colatitude_deg)
+    spin_axis_unit = spherical_to_cartesian(
+        np.array([[1.0, spin_ecl_lon, spin_ecl_lat]])
+    )[0]
     spin_axis_unit /= np.linalg.norm(spin_axis_unit)
 
     # Build a right-handed frame in the plane perpendicular to the spin axis,