MNT/TST: Update tests and ignore module level imports in tests

We don't care if the tests import things later which enables
mocks to be set up before any external imports

Author: greglucas

lambda_layer/database/requirements.txt

@@ -169,6 +169,7 @@ psycopg2-binary==2.9.10 ; python_version >= "3.10" and python_version < "4" \
     --hash=sha256:245159e7ab20a71d989da00f280ca57da7641fa2cdcf71749c193cea540a74f7 \
     --hash=sha256:26540d4a9a4e2b096f1ff9cce51253d0504dca5a85872c7f7be23be5a53eb18d \
     --hash=sha256:270934a475a0e4b6925b5f804e3809dd5f90f8613621d062848dd82f9cd62007 \
+    --hash=sha256:27422aa5f11fbcd9b18da48373eb67081243662f9b46e6fd07c3eb46e4535142 \
     --hash=sha256:2ad26b467a405c798aaa1458ba09d7e2b6e5f96b1ce0ac15d82fd9f95dc38a92 \
     --hash=sha256:2b3d2491d4d78b6b14f76881905c7a8a8abcf974aad4a8a0b065273a0ed7a2cb \
     --hash=sha256:2ce3e21dc3437b1d960521eca599d57408a695a0d3c26797ea0f72e834c7ffe5 \

poetry.lock

@@ -128,3 +128,6 @@ lint.ignore = ["D104", "D203", "D213", "D300", "D413", "S101", "S104", "PLR0913"
 # subprocess calls within these modules are expected
 "tests/lambda_endpoints/conftest.py" = ["S"]
 "tests/infrastructure/test_website_cloudfront_function.py" = ["S"]
+# Module level imports which we sometimes want within functions to
+# make for easier moto mocking
+"tests/*" = ["PLC0415"]

pyproject.toml

@@ -14,16 +14,6 @@
 import pytest
 from moto import mock_dynamodb
 
-from sds_data_manager.lambda_code.authorization.lambda_api_key_authorizer import (
-    get_api_key_metadata,
-    lambda_handler,
-)
-from sds_data_manager.lambda_code.authorization.manage_api_keys import (
-    add_key_to_db,
-    get_keys,
-    remove_key_from_db,
-)
-
 TABLE_NAME = "imap-sdc-api-keys"
 
 
@@ -45,6 +35,16 @@ def dynamodb_table():
 
 def test_api_key_management(dynamodb_table):
     """Test API key management operations."""
+    # Import after mocks are set up
+    from sds_data_manager.lambda_code.authorization.lambda_api_key_authorizer import (
+        lambda_handler,
+    )
+    from sds_data_manager.lambda_code.authorization.manage_api_keys import (
+        add_key_to_db,
+        get_keys,
+        remove_key_from_db,
+    )
+
     # Test adding a key
     test_key = "test123456789abcdef"
     add_key_to_db(
@@ -58,8 +58,8 @@ def test_api_key_management(dynamodb_table):
     assert keys[test_key]["email"] == "test@example.com"
     assert keys[test_key]["scope"] == "full"
 
-    # Test getting metadata for authorization
-    metadata = get_api_key_metadata(test_key)
+    # Test getting metadata for authorization (direct table access)
+    metadata = dynamodb_table.get_item(Key={"api_key": test_key}).get("Item")
     assert metadata is not None
     assert metadata["owner"] == "Test User"
 
@@ -88,6 +88,14 @@ def test_api_key_management(dynamodb_table):
 
 def test_scope_restrictions(dynamodb_table):
     """Test scope-based access restrictions."""
+    # Import after mocks are set up
+    from sds_data_manager.lambda_code.authorization.lambda_api_key_authorizer import (
+        lambda_handler,
+    )
+    from sds_data_manager.lambda_code.authorization.manage_api_keys import (
+        add_key_to_db,
+    )
+
     # Add a key with limited scope
     limited_key = "limited123456789abc"
     add_key_to_db(

tests/infrastructure/test_api_key_dynamodb.py

@@ -1,5 +1,4 @@
 """Tests for the I-ALiRT DB Query API Lambda function."""
-# ruff: noqa: PLC0415
 
 import importlib
 import json

tests/lambda_endpoints/test_ialirt_db_query_api.py

@@ -1,5 +1,4 @@
 """Tests for the I-ALiRT DB Query API Lambda function."""
-# ruff: noqa: PLC0415
 
 import importlib
 import json